build: use SIZEOF_INT128 for checking __int128 availability #23761

1. 
   fanquake commented at 1:33 pm on December 13, 2021: member

   We already use this in the blockfilter code,

   https://github.com/bitcoin/bitcoin/blob/bf66e258a84e18935fde3ebb9a4b0392bf883222/src/blockfilter.cpp#L34-L36

   so not sure we need to maintain two different ways of testing for the same functionality. Consolidate on testing for __SIZEOF_INT128__, which we already use, is supported by the compilers we care about, and is also used by libsecp256k1.

2. build: use __SIZEOF_INT128__ for checking __int128 availability

   We already use this in the blockfilter code, so not sure we need to maintain two
   different ways of testing for the same functionality. Consolidate on testing
   for __SIZEOF_INT128__, which we already use, is supported by the compilers we
   care about, and is also used by libsecp256k1.

   e9440aeb5c
3. MarcoFalke added the label Build system on Dec 13, 2021
4. MarcoFalke added the label DrahtBot Guix build requested on Dec 13, 2021
5. 
   Zero-1729 commented at 4:02 pm on December 13, 2021: contributor

   crACK e9440aeb5cad98fea9971f5126461e0a2b30ab54

   Makes sense to consolidate, given it’s already in use in the codebase.

6. 
   sipa commented at 4:02 pm on December 13, 2021: member

   utACK e9440aeb5cad98fea9971f5126461e0a2b30ab54
7. MarcoFalke removed the label DrahtBot Guix build requested on Dec 13, 2021
8. MarcoFalke merged this on Dec 13, 2021
9. MarcoFalke closed this on Dec 13, 2021

   ---

10. sidhujag referenced this in commit 07c2141ac9 on Dec 13, 2021
11. fanquake deleted the branch on Dec 14, 2021
12. PastaPastaPasta referenced this in commit 3a04329a68 on Apr 28, 2022
13. PastaPastaPasta referenced this in commit 0277d06767 on Apr 28, 2022
14. DrahtBot locked this on Dec 14, 2022

Contributors
fanquake Zero-1729 sipa

Labels
Build system