validation: Revert "de-duplicate package transactions already in mempool" #23793

pull laanwj wants to merge 2 commits into bitcoin:master from laanwj:2021-12-revert-package-dedup changing 4 files +3 −81

laanwj commented at 2:52 AM on December 16, 2021: member

This commit was added last minute, and was merged without enough review. Revert it for now. See #22674#pullrequestreview-833528437.

Reverts e12fafda2dfbbdf63f125e5af797ecfaa6488f66 and a test introduced in 046e8ff264be6b888c0f9a9d822e32aa74e19b78.
laanwj added the label Mempool on Dec 16, 2021

test: Remove test for mempool deduplication

With mempool package deduplication reverted, the test should be removed
as well.

c02c6cca67

Revert "[validation] de-duplicate package transactions already in mempool"
This reverts commit e12fafda2dfbbdf63f125e5af797ecfaa6488f66.
41957c602c
laanwj force-pushed on Dec 16, 2021
achow101 commented at 6:38 PM on December 16, 2021: member

I think it is safe to leave it as the code in question cannot be reached since package relay is not yet implemented. It is currently only used by unit tests. However we should be more careful about merging things in the future. Obviously we can revert it if it is found to be severely deficient, but I think any issues in the review of these two commits can be addressed in a followup rather than reverting and merging them in later following review.
ariard commented at 1:29 AM on December 17, 2021: member

I agree to leave the code in question, in the currently state the code cannot be reached by the user. Unless someone has conceptual disagreement with commit e12fafd, I think we can address the open comments in #22674 as followups.
fanquake commented at 2:08 AM on December 17, 2021: member

Lets close this for now then.
fanquake closed this on Dec 17, 2021
glozow commented at 10:54 AM on December 17, 2021: member

Thanks for looking into it @laanwj @achow101 @ariard!
DrahtBot locked this on Dec 17, 2022

Contributors

Labels