wallet: watchonly support for Miniscript descriptors #23815

pull darosior wants to merge 15 commits into bitcoin:master from darosior:miniscript_wallet_watchonly changing 14 files +3203 −72

darosior commented at 4:30 PM on December 18, 2021: member

Based on #2, this adds Miniscript support for output descriptors without any signing logic (yet).

Reintroduce + and += for Cscript

This was removed in "#18612: script: Remove undocumented and unused
operator+".

aa293218e6

script: make IsPushdataOp non-static

We'll need it for Miniscript

Signed-off-by: Antoine Poinsot <darosior@protonmail.com>

1eaae8a91f

script: move CheckMinimalPush from interpreter to script.h

It is used by Miniscript.

Signed-off-by: Antoine Poinsot <darosior@protonmail.com>

903c2bd600

miniscript: satisfaction support

Co-Authored-By: Pieter Wuille <pieter.wuille@gmail.com>

618e26a286

fuzz: add a fuzz target for Miniscript decoding from Script 2b7357dbbd
miniscript: add a helper to find the deepest insane sub
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
fd72fc7c12

miniscript: introduce a CheckTimeLocksMix helper

This helps to have finer-grained descriptor parsing errors.

aa88cc8578

miniscript: don't check for top level validity at parsing time

Letting the caller perform the checks allows for finer-grained error
reporting.

0ab5a9f260

Basic Miniscript support in output descriptors

Co-Authored-by: Antoine Poinsot <darosior@protonmail.com>

13e3113b37

qa: test descriptors with mixed xpubs and const pubkeys
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
d2f1ed2b53

qa: better error reporting on descriptor parsing error

A nit, but was helpful when writing unit tests for Miniscript parsing

Signed-off-by: Antoine Poinsot <darosior@protonmail.com>

2591f10517

Unit test Miniscript descriptors

Signed-off-by: Antoine Poinsot <darosior@protonmail.com>

8102beaf6f

darosior closed this on Dec 18, 2021
darosior commented at 4:31 PM on December 18, 2021: member

Wooops -- sorry, wrong repo...
jb55 commented at 7:06 PM on December 18, 2021: member

got excited there for a second
darosior commented at 7:11 PM on December 18, 2021: member

Soon (tm)

-------- Original Message -------- On Dec 18, 2021, 20:06, William Casarin wrote:

got excited there for a second

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you modified the open/close state.Message ID: @.***>
DrahtBot locked this on Dec 18, 2022

Contributors