scripted-diff: Rename interfaces::WalletClient to interfaces::WalletLoader #23842

pull ryanofsky wants to merge 1 commits into bitcoin:master from ryanofsky:pr/loader changing 26 files +62 −62

ryanofsky commented at 6:47 PM on December 22, 2021: member

Name has been confusing since it was introduced, and it was pointed in recent review club https://bitcoincore.reviews/10102 that it was particularly unclear how interfaces::WalletClient was different from interfaces::Wallet.

scripted-diff: Rename interfaces::WalletClient to interfaces::WalletLoader

Name has been confusing since it was introduced, and it was pointed in
recent review club as https://bitcoincore.reviews/10102 that it was
particularly unclear how interfaces::WalletClient was different from
interfaces::Wallet.

-BEGIN VERIFY SCRIPT-
ren() { git grep -l "$1" src | xargs sed -i "s/$1/$2/g"; }
ren WalletClient WalletLoader
ren walletClient walletLoader
ren wallet_client wallet_loader
ren "wallet clients release the wallet" "wallet pointer owners release the wallet"
ren "wallet client" "wallet loader"
ren "Wallet client" "Wallet loader"
-END VERIFY SCRIPT-

ff5f6dea53

DrahtBot added the label GUI on Dec 22, 2021
DrahtBot added the label interfaces on Dec 22, 2021
DrahtBot added the label Refactoring on Dec 22, 2021
DrahtBot added the label Wallet on Dec 22, 2021
DrahtBot commented at 6:58 AM on December 23, 2021: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #23732 (refactor: Remove gArgs from bdb.h and sqlite.h by kiminuo)
- #23497 (Add src/node/ and src/wallet/ code to node:: and wallet:: namespaces by ryanofsky)
- #10102 (Multiprocess bitcoin by ryanofsky)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
michaelfolkson commented at 12:06 PM on December 23, 2021: contributor

Concept ACK - WalletLoader is improved naming imo.

Checked there were no remaining references to WalletClient on master after this PR.
w0xlt approved
w0xlt commented at 12:33 PM on December 23, 2021: contributor

ACK ff5f6de

WalletLoader is really a better name for this class.
shaavan commented at 1:08 PM on December 23, 2021: contributor

Concept ACK

WalletLoader is a definite name improvement over WalletClient, considering the purpose of this class.

...also has additional //! methods (called by the GUI) to load and create wallets.

I checked for any more occurrences of WalletClient in PR, and I found none. I was able to compile and run bitcoind successfully on Ubuntu 20.04.

However, I would still like to wait for other reviewers' views on this change before giving an ACK.
MarcoFalke removed the label GUI on Dec 23, 2021
MarcoFalke removed the label Wallet on Dec 23, 2021
MarcoFalke removed the label interfaces on Dec 23, 2021
MarcoFalke merged this on Dec 23, 2021
MarcoFalke closed this on Dec 23, 2021
sidhujag referenced this in commit 05771c53ca on Dec 27, 2021
DrahtBot locked this on Dec 23, 2022

Contributors

Labels

Linked (view graph)

#23847 ci: failure in rpc_scantxoutset.py

scripted-diff: Rename interfaces::WalletClient to interfaces::WalletLoader #23842

Conflicts