refactor: Post-“Chainstate loading sequence coalescence” fixups #23855

1. 
   dongcarl commented at 10:49 pm on December 23, 2021: member

   There are 2 proposed fixups in discussions in #23280 which I have not implemented:

   1. An overhaul to return types and an option type for the two *Chainstate functions: #23280 (comment)
      • The change reintroduces stringy return types and is quite involved. It could be discussed in a separate PR.
   2. Passing in the unix time to VerifyChainstate instead of a callback to get the time: #23280 (review)
      • I’m not sure it matters much whether it’s a callback or just the actual unix time. Also, I think VerifyDB can take quite a while, and I don’t want to impose that the function have to “run quickly” in order to have it be correct.

   If reviewers feel strongly about either of the two fixups listed above, please feel free to open a PR based on mine and I’ll close this one!

2. node/chainstate: Use MAX_FUTURE_BLOCK_TIME 6b83576388
3. docs: Make LoadChainstate comment more accurate 1dd582782d
4. style-only: Rename *Chainstate return values 3401630417
5. init: Use clang-tidy named args syntax e3544c864e
6. DrahtBot added the label Tests on Dec 23, 2021
7. MarcoFalke removed the label Tests on Dec 24, 2021
8. MarcoFalke renamed this:
   Post-"Chainstate loading sequence coalescence" fixups
   refactor: Post-"Chainstate loading sequence coalescence" fixups
   on Dec 24, 2021
9. DrahtBot added the label Refactoring on Dec 24, 2021
10. fanquake requested review from jamesob on Dec 26, 2021
11. ryanofsky approved
12. 
    ryanofsky commented at 6:54 pm on December 27, 2021: member

    Code review ACK e3544c864e3e56867de25b8db7b012d58b378050
13. in src/init.cpp:1422 in e3544c864e

    1435+                                              cache_sizes.coins,
    1436+                                              /*block_tree_db_in_memory=*/false,
    1437+                                              /*coins_db_in_memory=*/false,
    1438+                                              /*shutdown_requested=*/ShutdownRequested,
    1439+                                              /*coins_error_cb=*/[]() {
    1440+                                                  uiInterface.ThreadSafeMessageBox(
    

    ---

    ---

    

    MarcoFalke commented at 12:55 pm on January 6, 2022:

    unrelated: But I think this can just be InitError(...).
14. MarcoFalke approved
15. 
    MarcoFalke commented at 12:55 pm on January 6, 2022: member

    ACK e3544c864e3e56867de25b8db7b012d58b378050 🐸

    Signature:

     0-----BEGIN PGP SIGNED MESSAGE-----
     1Hash: SHA512
     2
     3ACK e3544c864e3e56867de25b8db7b012d58b378050 🐸
     4-----BEGIN PGP SIGNATURE-----
     5
     6iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
     7pUjGQQv+Nvv1zRWaWXIrwOzSvImTCAa1zNaRxiEbDL+L0/tLzKviDRoeB8jVrcvO
     8ZBzC6LKD1eHBBOz54EVMoNAzh72pbJfSFzF6EmVm13r3ydhm8je5WXi8PGOUQUvv
     9zpNvakUUf3nM64fIlq2r+GXRHmP7RmcDXsoNC3d6X3u/I73Mva/sm+M2aljAb0MM
    10YLE2Mat6eWLBtw1wzAkn/GS8r3qxQmGfyuZQRgRn3PcsJZkDTE96wMCSZAuIYCNb
    11/z+SV4QtmbN6+xwCQ0tPwYA19hkBvLJWPhEaDR5kIiiDKlgAFJpsqRBeb25K1Uc+
    12/AYXD/YAW+S+tOXqjtNo46eoN9U/Iq/OQkaP/EEBT8xUnaqGBZZxFA/4ucbx/WYq
    13P5C1VZ47vd2Cp72ckcrCv+ynRicFvL9T175sT1zijFsUQp/wQSpIOKGZ7RUvo7gQ
    14pR+Qy2pts7DlVTWpfLu9l+kyiLu5IDf+livi/Ahy9WS+K1C4t0S3JZxOJ6BrLxfD
    15UMV5AEjK
    16=Ddan
    17-----END PGP SIGNATURE-----
    

16. MarcoFalke merged this on Jan 6, 2022
17. MarcoFalke closed this on Jan 6, 2022

    ---

18. sidhujag referenced this in commit 13dfe4d825 on Jan 6, 2022
19. DrahtBot locked this on Jan 6, 2023

Contributors
dongcarl ryanofsky MarcoFalke

Review Requested
jamesob

Labels
Refactoring