doc: Add gpg key import instructions for Windows #23916

pull dscotese wants to merge 3 commits into bitcoin:master from dscotese:patch-1 changing 1 files +7 −0

dscotese commented at 11:07 PM on December 30, 2021: contributor

I propose this change so that Windows users can more easily import signers' keys.
Added key import code for use with Windows. 7c08622535
DrahtBot added the label Scripts and tools on Dec 30, 2021

in contrib/builder-keys/README.md:28 in 7c08622535 outdated

  23 |  ```sh
  24 |  while read fingerprint keyholder_name; do gpg --keyserver hkps://keys.openpgp.org --recv-keys ${fingerprint}; done < ./keys.txt
  25 |  ```
  26 |  
  27 | +
  28 | +using Windows (tested with Gpg4win 4.0.0, and FAILS with Gp4win 3.1.13, so make sure you're up to date!):

fanquake commented at 2:02 AM on December 31, 2021:

using Windows (requires Gpg4win >= 4.0.0):

fanquake commented at 4:00 PM on March 24, 2022:

@dscotese are you planning on addressing feedback here?

fanquake removed the label Scripts and tools on Mar 24, 2022
fanquake added the label Docs on Mar 24, 2022
in contrib/builder-keys/README.md:22 in 7c08622535 outdated
```
  18 | @@ -19,9 +19,16 @@ gpg --refresh-keys
  19 |  To fetch keys of builders and active developers, feed the list of fingerprints
  20 |  of the primary keys into gpg:
  21 |  
  22 | +using \*NIX:
```
laanwj commented at 12:17 PM on April 6, 2022:

nit: it's more usual to say "on UNIX" and "on Windows", instead of "using"

dscotese commented at 3:11 PM on April 6, 2022:

Accepted and applied.
laanwj renamed this:
~~Added key import code for use with Windows.~~
doc: Add gpg key import instructions for Windows
on Apr 6, 2022

Update contrib/builder-keys/README.md

Co-authored-by: Michael Ford <fanquake@gmail.com>

f15b3ba5eb

Update README.md

OS designations slightly more understandable.

35bceb15d2

fanquake commented at 3:16 PM on April 6, 2022: member

You'll need to squash this to a single commit.
dscotese commented at 3:20 PM on April 6, 2022: contributor

You'll need to squash this to a single commit.

That is not possible on the website, is it?
fanquake commented at 3:23 PM on April 6, 2022: member

That is not possible on the website, is it?

No idea, maybe check the documentation: https://docs.github.com/en.

When you're done the commit message should be doc: Add gpg key import instructions for Windows.
dscotese commented at 3:51 PM on April 6, 2022: contributor

I will make a new pull request with a single commit. The only loss (though I suppose it's recorded here) is that I don't think @fanquake 's help will be attributed.
dscotese closed this on Apr 6, 2022
dscotese commented at 3:54 PM on April 6, 2022: contributor

New PR is #24788
dscotese deleted the branch on Apr 6, 2022
fanquake locked this on Apr 7, 2022
laanwj commented at 9:12 AM on April 7, 2022: member
I wish github did either of two things:
- Add squashing/rebasing/editing commit titles to the website.
- Add an option to disable editing through the website. It doesn't have the features needed to take part in the development process here, always creates frustration.

Contributors

Labels

Linked (view graph)

#24788 doc: Add gpg key import instructions for Windows