build: use host_os instead of TARGET_OS in configure output #23947

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:use_host_os_over_TARGET_OS changing 1 files +1 −1

fanquake commented at 5:13 AM on January 3, 2022: member
TARGET_OS was convenient, as a readable host name for most of our targeted platforms, however unless we add more code to configure to detect more hosts, it's easier just use host_os (it's also more informative).

i.e FreeBSD master
```
  target os       =
  build os        = freebsd13.0
```
this PR:
```
  target os       = freebsd13.0
  build os        = freebsd13.0
```

build: use host_os instead of TARGET_OS in configure output

TARGET_OS was conveninent, as a readable host name for most of our
targetted platforms, however unless we add more code to configure to
detect more hosts, it's easier just use host_os (it's also more
informative).

i.e FreeBSD master
```bash
  target os       =
  build os        = freebsd13.0
```

this PR:
```bash
  target os       = freebsd13.0
  build os        = freebsd13.0
```

1bf3809dd1

fanquake added the label Build system on Jan 3, 2022
hebasto approved
hebasto commented at 9:49 AM on January 3, 2022: member
ACK 1bf3809dd1d73f24ec5cf658733da76fc2ca36a7

A note for reviewers: the host_os variable is being set by the AC_CANONICAL_HOST macro in:https://github.com/bitcoin/bitcoin/blob/d69af93223c4008c3255f7e4848ff05d78c514fa/configure.ac#L38

TBH, I don't see good reasons to use the TARGET_OS variable at all. In follow up lines like these
```
    if test "$TARGET_OS" = "windows"; then
      MINIUPNPC_CPPFLAGS="-DSTATICLIB -DMINIUPNP_STATICLIB"
    fi
```
could be replaced with
```
    AS_CASE([$host_os], [*mingw*], [MINIUPNPC_CPPFLAGS="-DSTATICLIB -DMINIUPNP_STATICLIB"])
```
fanquake merged this on Jan 4, 2022
fanquake closed this on Jan 4, 2022
fanquake deleted the branch on Jan 4, 2022
fanquake commented at 7:37 AM on January 4, 2022: member

TBH, I don't see good reasons to use the TARGET_OS variable at all. In follow up lines like these

Ok. Following up in #23969.
sidhujag referenced this in commit 7e8afea7ce on Jan 4, 2022
DrahtBot locked this on Jan 4, 2023

Contributors

fanquake

hebasto

Labels

Build system