Setup to use the system Clang (11.0.1 as of FreeBSD 13.0).
Doesn’t build the Qt package; that requires a few additional changes. The current issue is that FreeBSDs byacc seems to have an issue parsing something in libxkbcommon. Work in progress branch here: https://github.com/fanquake/bitcoin/tree/depends_support_freebsd_qt. In any case, I don’t think building the Qt libs on FreeBSD is a super high priority (I’d also have no way to test the GUI).
In any case, I don’t think building the Qt libs on FreeBSD is a super high priority (I’d also have no way to test the GUI).
It might be possible to use the system qt with the depends options NO_QT=1 ALLOW_HOST_PACKAGES=1
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
Rebased on master and dropped the base commit.
It might be possible to use the system qt with the depends options NO_QT=1 ALLOW_HOST_PACKAGES=1
Yes I’d think that is possible. I’m just assuming that the number of users wanting to run (depends built) bitcoin-qt on FreeBSD is not large.
I tested it (on FreeBSD 13) and get:
0~/src/bitcoin/depends % gmake NO_QT=1
1Invalid configuration `medea': machine `medea-unknown' not recognized
2shasum: hosts/.mk: No such file or directory
3shasum: hosts/.mk: No such file or directory
4shasum: hosts/.mk: No such file or directory
5…
It looks like the hostname ends up in the machine tuple somehow :smile:
For some reason the environment variable HOST contains the hostname on this machine. I’m not sure where it comes from, but it seems FreeBSD behavior?
The makefile assumes it to be a host tuple.
With the following patch, it gets past it:
0diff --git a/depends/Makefile b/depends/Makefile
1index 003778b37..36f28f1c7 100644
2--- a/depends/Makefile
3+++ b/depends/Makefile
4@@ -45,7 +45,7 @@ MULTIPROCESS ?=
5 FALLBACK_DOWNLOAD_PATH ?= https://bitcoincore.org/depends-sources
6
7 BUILD = $(shell ./config.guess)
8-HOST ?= $(BUILD)
9+HOST := $(BUILD)
10 PATCHES_PATH = $(BASEDIR)/patches
11 BASEDIR = $(CURDIR)
12 HASH_LENGTH:=11
It removes the ability to override the host system tuple, if we want this i’d suggest using a different env variable name.
Edit: ok, stupid suggestion
Oh, we explicitly document the use of HOST. OK, this is kind of annoying, I don’t really know how to resolve this, we could just add a big FreeBSD warning to always override it (or unset it) because the default will result in absurd behavior.
Edit: seems it’s csh/tcsh that sets HOST, not FreeBSD. I’d assume someone running Linux who uses tcsh would run into the same problem
Edit.2: googling around I find I had a similar issue building clightning once, lol https://github.com/ElementsProject/lightning/issues/1231
Edit.3: From man tcsh:
0 HOST (+)
1 Initialized to the name of the machine on which the shell is
2 running, as determined by the gethostname(2) system call.
