build: Upgrade default msvc platform #24014

1. 
   rojarsmith commented at 7:56 AM on January 9, 2022: contributor

   Support Visual Studio 2022.

   Pass the full compile at Windows 11 and vcpkg 2021.12.01.

2. Upgrade default platform

   Support Visual Studio 2022.
   
   Pass the full compile at Windows 11 and vcpkg 2021.12.01

   c72c48c03e
3. 
   hebasto commented at 3:08 PM on January 9, 2022: member

   What are other VS versions that are compatible with the v143 toolset?

4. 
   rojarsmith commented at 6:22 AM on January 10, 2022: contributor

   What are other VS versions that are compatible with the v143 toolset?

   VS2022 community is also free for non-profit organization, optimized for the latest hardware and similarity product architecture with VS2019. I recommend defalut toolset upgrade to the latest version.

   Based on past experience it can also use the VS2019 IDE with the new v143 toolset with installing "Build Tools for Visual Studio 2022". (Sorry for I haven't tried)

   I using the pre-build Qt5.12.11_x64_static_vs2019_16101 with VS2022 include v143 toolset is no problem.

5. MarcoFalke renamed this:
   Upgrade default platform
   build: Upgrade default msvc platform
   on Jan 10, 2022
6. MarcoFalke requested review from sipsorcery on Jan 10, 2022
7. DrahtBot added the label Build system on Jan 10, 2022
8. 
   sipsorcery commented at 7:18 PM on January 10, 2022: member

   This PR isn't updating the toolset version in the msbuild project files. To update the default toolset version it will have to be set in common.init.vcxproj.

   That also explains why this PR passes the cirrus build job even though it only has msbuild verison 16.11.2.50704 installed (vs 2022 and the corresponding C++ v143 toolset have an msbuild major version of 17).

   Conceptually, updating the toolset to the latest version makes sense to me as long as cirrus supports it?

9. 
   rojarsmith commented at 6:46 AM on January 11, 2022: contributor

   I did not update common.init.vcxproj because of the MSVC building must running the command at least once: py -3 msvc-autogen.py or py -3 msvc-autogen.py -toolset v143

10. 
    sipsorcery commented at 7:34 PM on January 11, 2022: member

    For py -3 msvc-autogen.py this PR doesn't change anyting.

    For py -3 msvc-autogen.py -toolset v143 this PR isn't needed.

    The only thing the msvc-autogen.py script does is write some of the vcxproj files, including the common ones. If the PlatformToolset version in common.init.vcxproj doesn't change, which it doesn't, then this PR has no effect.

11. 
    fanquake commented at 4:03 PM on March 24, 2022: member

    Thanks, however I'm going to close this for now, as it's not clear this is a (standalone) improvement.

12. fanquake closed this on Mar 24, 2022

    ---

13. 
    MarcoFalke commented at 5:22 PM on March 24, 2022: member

    See also https://github.com/cirruslabs/cirrus-ci-docs/issues/985

14. DrahtBot locked this on Mar 24, 2023

Contributors

rojarsmithhebastosipsorceryfanquakeMarcoFalke

Review Requested
sipsorcery