Bugfix: configure: bitcoin-{cli,tx,util} don’t need UPnP, NAT-PMP, or ZMQ #24051

pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:config_utils_drop_extra_deps changing 1 files +1 −1
  1. luke-jr commented at 10:21 pm on January 12, 2022: member
    As with #23345, these other tools likewise don’t use various deps.
  2. Bugfix: configure: bitcoin-{cli,tx,util} don't need UPnP, NAT-PMP, or ZMQ 98868633d1
  3. DrahtBot added the label Build system on Jan 13, 2022
  4. hebasto commented at 7:55 am on January 13, 2022: member

    Concept ACK

    Tested 98868633d1d5cd2591b9613545bd2ce2e81af212 with -without-daemon -without-gui -disable-tests -disable-bench configure options.

    Are UPnP or NAT-PMP required for tests and benchmarks?

  5. DrahtBot commented at 12:19 pm on March 31, 2022: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    No conflicts as of last run.

  6. laanwj commented at 7:47 am on April 14, 2022: member

    Are UPnP or NAT-PMP required for tests and benchmarks?

    I don’t think there’s any tests and benchmarks for UPnP or NATPMP related code right now, but there could potentially be.

  7. achow101 requested review from fanquake on Oct 12, 2022
  8. achow101 commented at 10:38 pm on October 25, 2022: member
    ACK 98868633d1d5cd2591b9613545bd2ce2e81af212
  9. fanquake referenced this in commit 4766cd1981 on Oct 31, 2022
  10. DrahtBot commented at 1:06 pm on October 31, 2022: contributor

    🐙 This pull request conflicts with the target branch and needs rebase.

  11. DrahtBot added the label Needs rebase on Oct 31, 2022
  12. fanquake closed this on Oct 31, 2022

  13. fanquake commented at 1:06 pm on October 31, 2022: member
    This was merged.
  14. sidhujag referenced this in commit ea7e0fab2a on Oct 31, 2022
  15. bitcoin locked this on Oct 31, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-07-03 10:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me