build: specify hosts for qrencode package #24093

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:specify_qrencode_oses changing 2 files +5 −3
  1. fanquake commented at 9:30 am on January 18, 2022: member

    Similar to how we specify the OS’s we build Qt for, specify which OS’s we will build qrencode for (a qt dependency). This commit alone doesn’t change anything, but when we start supporting other OS’s, i.e #23948, where we wont support qt (or at least initially), it’ll skip building the qrencode package, which would be unused.

    I’ll rebase the other *BSD changes on top of this.

  2. build: specify hosts for qrencode package
    Similar to how we specify the OS's we build Qt for, specify which OS's
    we will build qrencode for (a qt dependency). This commit alone doesn't
    change anything, but when we start supporting other OS's, i.e #23948,
    where we wont support qt (or at least initially), it'll skip building
    the qrencode package, which would be unused.
    bf044ef9ec
  3. fanquake added the label Build system on Jan 18, 2022
  4. DrahtBot commented at 6:00 pm on January 18, 2022: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #22708 (build, qt: Add Wayland support for Linux builds with depends by hebasto)
    • #22555 (build: Fix make apk for Android w/ non-default SOURCES_PATH in depends by hebasto)
    • #22552 (build: Improve depends build system robustness by hebasto)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  5. hebasto approved
  6. hebasto commented at 6:22 pm on January 18, 2022: member
    ACK bf044ef9ecc93a69619cbaa9fa2b874d5fc06932, I have reviewed the code and it looks OK, I agree it can be merged.
  7. fanquake merged this on Jan 19, 2022
  8. fanquake closed this on Jan 19, 2022

  9. sidhujag referenced this in commit e07fcae642 on Jan 20, 2022
  10. fanquake deleted the branch on May 31, 2022
  11. PastaPastaPasta referenced this in commit e8cfe601d8 on Jun 19, 2022
  12. PastaPastaPasta referenced this in commit 6a53ddca4d on Jun 19, 2022
  13. PastaPastaPasta referenced this in commit 537d87cbec on Jun 19, 2022
  14. PastaPastaPasta referenced this in commit 4e6b49d6f6 on Jun 27, 2022
  15. DrahtBot locked this on May 31, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-23 09:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me