fs: consistently use fsbridge:: for ifstream / ofstream #24167

1. 
   fanquake commented at 2:09 PM on January 26, 2022: member

   These changes are part of #20744, but are also ok to do now, and reduce the diff in that PR. See commit messages for details. Revived from #23857.

2. fs: consistently use fsbridge for {i,o}fstream

   Part of #20744, but this can be done now, and will simplify the diff.

   21f781ad79
3. fs: add missing <cassert> include

   This is needed to prevent compilation failures once boost is removed,
   however is still correct to include now, and reduces the diff in #20744.
   
   <string> is extracted from the defines because it is used for Windows
   and non-Windows code, i.e get_filesystem_error_message().

   486261dfcb
4. fs: consistently use fsbridge for fopen() 5e8975e269
5. 
   hebasto commented at 2:13 PM on January 26, 2022: member

   Concept ACK.

6. MarcoFalke added the label DrahtBot Guix build requested on Jan 26, 2022
7. MarcoFalke added the label Refactoring on Jan 26, 2022
8. MarcoFalke added this to the milestone 23.0 on Jan 26, 2022
9. in src/bitcoin-tx.cpp:162 in 5e8975e269

    158 | @@ -158,7 +159,7 @@ static void RegisterLoad(const std::string& strInput)
    159 |      std::string key = strInput.substr(0, pos);
    160 |      std::string filename = strInput.substr(pos + 1, std::string::npos);
    161 |  
    162 | -    FILE *f = fopen(filename.c_str(), "r");
    163 | +    FILE *f = fsbridge::fopen(filename.c_str(), "r");
   

   ---

   ---

   

   MarcoFalke commented at 5:50 PM on January 26, 2022:

   unrelated question for follow-up: Why is this safe? Shouldn't this use PathFromString?

10. MarcoFalke approved
11. 
    MarcoFalke commented at 5:51 PM on January 26, 2022: member

    ACK 5e8975e2694c3178ae73deb28986e1fb5466147e 🏕

    <details><summary>Show signature</summary>

    Signature:

    -----BEGIN PGP SIGNED MESSAGE-----
    Hash: SHA512
    
    ACK 5e8975e2694c3178ae73deb28986e1fb5466147e 🏕
    -----BEGIN PGP SIGNATURE-----
    
    iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
    pUg91Av+IL93ayKaf1O3lEaZkky3cz+mduqUCE8hGE6UQo9NSM47OvHEeTRPVK0H
    DHTpZidWXOJbzuBvKhs7YLOm4xgYN5Wx2/UDtFHIMFTQynsxZjPYDILWPNXjUBma
    pwNS59KsWZO1iZNqBaG+gHUA2zGIbVDLCP+wY/HbeTDIOr+Sr27Y3lxha2AUDYKr
    O1J+Hxre7S9nDSp+x5i9XcL6qpw0xs8nzqweRYd1gBUGkEj1FzpcYBgh2QCbuOqD
    idxw9dA8f3m1Y+1P/kpSKw3Kzvc/Ce18gOmCzUMKpXEfwfLsbPOXG468xviJpc5Y
    1EaFsrZHUMOpz6VRFZ+bl/xfH3vCdCMZY9XNyV4HzG8Rnz7JHzJS4qXmx8eILKK0
    V9uc7sseLDJ9ttX1Vy5/hyWDOnSnu8YPpt3f4gPeGA79+sjBMOMG5451hSzazNP4
    4yQs8uUVEWH/j97XQQFdD6ldFQtrD2dU4zb3mxnA7V8xPZmMjaspJE4rCZveytas
    ty+5S2DM
    =nQnW
    -----END PGP SIGNATURE-----
    

    </details>

12. 
    laanwj commented at 6:49 PM on January 26, 2022: member

    It's good to be consistent with this. Code review ACK 5e8975e2694c3178ae73deb28986e1fb5466147e

13. 
    DrahtBot commented at 11:21 PM on January 26, 2022: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #20744 (Use std::filesystem. Remove Boost Filesystem & System by fanquake)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

14. fanquake merged this on Jan 27, 2022
15. fanquake closed this on Jan 27, 2022

    ---

16. fanquake deleted the branch on Jan 27, 2022
17. MarcoFalke removed the label DrahtBot Guix build requested on Jan 27, 2022
18. sidhujag referenced this in commit f9de29fcb9 on Jan 28, 2022
19. Fabcien referenced this in commit dbe7604947 on Sep 20, 2022
20. DrahtBot locked this on Jan 27, 2023

Milestone
23.0