Fixes #23990
After #23799, the --failfast option in the test runner for the functional tests stopped working, because a second outer loop was introduced, which would have needed a break too for the test runner to fail immediately. This also led to the errors reported in #23990.
This provides a straightforward fix for that. There is also #23995 which is a larger refactor, but that hasn't been updated in a while to fix the failfast issue.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
Tested ACK a036358994546e2041d0bf0cc911bab4e4baba3c. I agree adding the all_passed flag to break out of the outer loop when needed makes sense. The "failfast" option works after this change.
thanks!
On Fri, Jan 28, 2022 at 4:01 PM Martin Zumsande @.***> wrote:
Fixes #23990 https://github.com/bitcoin/bitcoin/issues/23990
After #23799 https://github.com/bitcoin/bitcoin/pull/23799, the --failfast option in the test runner for the functional tests stopped working, because a second outer loop was introduced, which would have needed a break too for the test runner to fail immediately. This also led to the errors reported in #23990 https://github.com/bitcoin/bitcoin/issues/23990.
This provides a straightforward fix for that. There is also #23995 https://github.com/bitcoin/bitcoin/pull/23995 which is a larger refactor, but that hasn't been updated in a while to fix the failfast issue.
You can view, comment on, or merge this pull request online at:
#24195 Commit Summary
- a036358 https://github.com/bitcoin/bitcoin/pull/24195/commits/a036358994546e2041d0bf0cc911bab4e4baba3c test: Repair failfast option for test runner
File Changes
(1 file https://github.com/bitcoin/bitcoin/pull/24195/files)
- M test/functional/test_runner.py https://github.com/bitcoin/bitcoin/pull/24195/files#diff-437d7f6e9f2229879b60aae574a8217f14c643bbf3cfa9225d8011d6d52df00c (6)
Patch Links:
— Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/24195, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRS4WYTQYZN5XSZZJNSK3DUYKVTHANCNFSM5NA64R5Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message ID: @.***>