p2p: Split network logging into two categories #24247

1. 
   anshu-khare-design commented at 10:26 am on February 3, 2022: none

   This PR is to resolve issue 20576. It focuses on introducing different levels of net logging. As a starting point, as mentioned in the issue #20576 , it creates separate lower-frequency, important peer-level events (netpeers) from very high-frequency message-level passing (netmessages).
2. laanwj added the label Utils/log/libs on Feb 3, 2022
3. laanwj renamed this:
   Issue 20576
   p2p: Split network logging into two categories
   on Feb 3, 2022
4. laanwj added the label P2P on Feb 3, 2022
5. 
   brunoerg commented at 12:00 pm on February 3, 2022: member

   Hi, @anshu-khare-design. Thanks for this. Some points:

   1. I think you might write a more appropriate commit message (maybe the same as the PR title)
   2. CI is failing because of rpc_miscfunctional test:

   0# Test logging RPC returns the expected number of logging categories.
   1assert_equal(len(node.logging()), 27)
   

   this assertion is failing because with this PR we have one more category, so, in total, 28. You should update this test as well.

6. anshu-khare-design referenced this in commit f9f4d37fa2 on Feb 3, 2022
7. 
   brunoerg commented at 4:59 pm on February 3, 2022: member

   Cool. Now you should squash the commits. See: https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits
8. anshu-khare-design referenced this in commit bbb9a973ab on Feb 4, 2022
9. 
   anshu-khare-design commented at 0:19 am on February 4, 2022: none

   Oops.. I think I did something wrong.. I first wrote

   $ git rebase -i HEAD~3 $ git pull origin issue_20576 (Since it was asking me to take a pull) $ git push origin issue_20576

10. 
    ghost commented at 1:08 am on February 4, 2022: none

    @anshu-khare-design try this

    0git reset --hard 133f73e86bd7c3114263500be2fb5090dd76b4bc
    1
    2git push origin +133f73e86bd7c3114263500be2fb5090dd76b4bc^:issue_20576
    3
    4git push origin 133f73e86bd7c3114263500be2fb5090dd76b4bc:issue_20576
    

    This will close the pull request, it will have 0 commits and you can start fresh in your fork repository

    Make all the changes in the code, do 1 commit and reopen pull request.

11. 
    DrahtBot commented at 3:55 am on February 4, 2022: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #24230 (indexes: Stop using node internal types and locking cs_main, improve sync logic by ryanofsky)
    • #24178 (p2p: Respond to getheaders if we have sufficient chainwork by sdaftuar)
    • #24008 (assumeutxo: net_processing changes by jamesob)
    • #23604 (Use Sock in CNode by vasild)
    • #23443 (p2p: Erlay support signaling by naumenkogs)
    • #22778 (net processing: Reduce resource usage for inbound block-relay-only connections by jnewbery)
    • #22053 (refactor: Release cs_main before MaybeSendFeefilter by MarcoFalke)
    • #21160 (net/net processing: Move tx inventory into net_processing by jnewbery)
    • #20799 (net processing: Only support version 2 compact blocks by jnewbery)
    • #20726 (p2p: Add DISABLETX message for negotiating block-relay-only connections by sdaftuar)
    • #15606 (assumeutxo by jamesob)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

12. DrahtBot added the label Needs rebase on Feb 4, 2022
13. 
    DrahtBot commented at 8:58 am on February 4, 2022: member

    🐙 This pull request conflicts with the target branch and needs rebase.

    Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

14. 
    brunoerg commented at 1:56 pm on February 5, 2022: member

    @prayank23 gave some tips. Feel free to ask for help whenever needed.
15. anshu-khare-design closed this on Feb 5, 2022

    ---

16. anshu-khare-design force-pushed on Feb 5, 2022
17. anshu-khare-design referenced this in commit 0dba6126d5 on Feb 5, 2022
18. 
    fanquake commented at 11:22 pm on February 6, 2022: member

    Please don’t open new PRs for the same change. (#24273).
19. DrahtBot locked this on Feb 6, 2023

Contributors
anshu-khare-design brunoerg ghost DrahtBot fanquake

Labels
P2P Utils/log/libs Needs rebase