build: Fix `make deploy` for Windows when building out of source tree #24277

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:220206-deploy changing 1 files +5 −5

hebasto commented at 12:00 PM on February 6, 2022: member

On master (1e7564eca8a688f39c75540877ec3bdfdde766b1):

$ make distclean
$ mkdir ../build
$ cd ../build
$ CONFIG_SITE=$PWD/../bitcoin/depends/x86_64-w64-mingw32/share/config.site ../bitcoin/configure
$ make
$ make deploy
...
File: "/home/hebasto/GitHub/build/../bitcoin/release/bitcoin-qt.exe" -> no files found.
Usage: File [/nonfatal] [/a] ([/r] [/x filespec [...]] filespec [...] |
   /oname=outfile one_file_only)
Error in script "<stdin>" on line 75 -- aborting creation process
error: could not build bitcoin-22.99.0-win64-setup.exe
built bitcoin-22.99.0-win64-setup.exe

This PR fixes this bug.

build: Fix `make deploy` for Windows when building out of source tree a5f67b4ca8
hebasto added the label Windows on Feb 6, 2022
hebasto added the label Build system on Feb 6, 2022
MarcoFalke added the label DrahtBot Guix build requested on Feb 7, 2022
laanwj commented at 1:48 PM on February 10, 2022: member

Thanks for caring about out-of-tree builds.

Code review ACK a5f67b4ca809666661b9dfc773806523e487ea66
luke-jr approved
luke-jr commented at 1:42 AM on February 12, 2022: member

utACK
fanquake merged this on Feb 12, 2022
fanquake closed this on Feb 12, 2022
hebasto deleted the branch on Feb 12, 2022
sidhujag referenced this in commit 115f2c9b61 on Feb 13, 2022
MarcoFalke removed the label DrahtBot Guix build requested on Feb 14, 2022
PastaPastaPasta referenced this in commit 7060af3a7c on Apr 7, 2022
PastaPastaPasta referenced this in commit 3c041d4137 on Apr 11, 2022
DrahtBot locked this on Feb 14, 2023

Contributors

Labels