Bugfix: gen-manpages: Handle tagged versions correctly #24287

Fixes rc version suffix and hyphen deletion in #22681

Does not address removal of copyright from --version output, since that is a new issue only affecting master/23.x, and #24263 seems like a better approach moving forward. (ie, this is mainly only for backporting purposes)

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--174a7506f384e20aa4161008e828411d-->

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #24263 (doc: Fix gen-manpages, rewrite in Python by laanwj)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

I don't think it's necessary to backport anything. On the 22.x branch, the hypen-deletion issue is already fixed (by removing the sed line). The rc version issue was fixed by changing the order of steps in the release process (as discussed in #22681). I honestly don't understand why you felt the need to open a competing PR for this.

On the 22.x branch, the hypen-deletion issue is already fixed (by removing the sed line).

Won't that fail to delete actual hyphen+commithash in the output?

The rc version issue was fixed by changing the order of steps in the release process (as discussed in #22681).

This isn't really a fix IMO.

I honestly don't understand why you felt the need to open a competing PR for this.

It's not really competing, just a pure fix for backport purposes. If that's undesired, we can just close it.

I agree with @laanwj. I don't really think there's anything we need to backport. Going to close this for now.