ci: use Ubuntu Jammy for Windows cross-compilation CI #24296

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:win_ci_gcc_10_3 changing 2 files +3 −3

fanquake commented at 11:56 AM on February 9, 2022: member

This means we'll compile using GCC 10.3.x and mingw-w64 8.0.0 which better matches our Guix release environment.
fanquake added the label Tests on Feb 9, 2022
MarcoFalke commented at 12:01 PM on February 9, 2022: member

Concept ACK, Approach NACK. Hirsute is EOL, please use Bullseye or Jammy.
MarcoFalke commented at 12:05 PM on February 9, 2022: member

For reference, I suspect mingw was bumped in commit 711ce2e5333bd6717f9b114abe7ec1d1994afbc4
fanquake force-pushed on Feb 9, 2022
fanquake renamed this:
~~ci: use Ubuntu Hirsute for Windows cross-compilation CI~~
ci: use Ubuntu Jammy for Windows cross-compilation CI
on Feb 9, 2022
MarcoFalke commented at 12:11 PM on February 9, 2022: member

Concept ACK 8416818965381cef30301d61df6153f570326f20
prusnak approved
prusnak commented at 12:17 PM on February 9, 2022: contributor

ACK 8416818965381cef30301d61df6153f570326f20

(I dislike the inconsistency of using ubuntu:focal/ubuntu:jammy in .cirrus.yml and ubuntu:20.04/ubuntu:22.04 in ci/test/*.sh, but that's probably for some other PR)
MarcoFalke commented at 12:34 PM on February 9, 2022: member

Fails without error? (#24261)

in ci/test/00_setup_env_win64.sh:10 in 8416818965 outdated

   6 | @@ -7,7 +7,7 @@
   7 |  export LC_ALL=C.UTF-8
   8 |  
   9 |  export CONTAINER_NAME=ci_win64
  10 | -export DOCKER_NAME_TAG=ubuntu:20.04  # Check that Focal can cross-compile to win64
  11 | +export DOCKER_NAME_TAG=ubuntu:22.04  # Check that Jammy can cross-compile to win64

Sjors commented at 1:18 PM on February 9, 2022:

I'm confused, isn't Ubuntu 22.04 planned for April this year?

prusnak commented at 1:30 PM on February 9, 2022:

Yes, it is. And it is going to be a LTS release.

laanwj commented at 1:55 PM on February 9, 2022: member

Concept ACK. Besides the compilers better matching it's good to have a CI run with 22.04.

I'm confused, isn't Ubuntu 22.04 planned for April this year?

It's in beta IIRC. Ubuntu releases tend to be usable already a few months before their official release.
MarcoFalke commented at 2:00 PM on February 9, 2022: member

There are only two major changes planned for Jammy: clang-14 and Gnome, see https://discourse.ubuntu.com/t/jammy-jellyfish-release-schedule/23906 . Neither of which should matter for this pull request.
hebasto commented at 4:53 PM on February 9, 2022: member

Concept ACK.
fanquake commented at 8:49 AM on February 10, 2022: member

For reference, I suspect mingw was bumped in commit https://github.com/bitcoin/bitcoin/commit/711ce2e5333bd6717f9b114abe7ec1d1994afbc4

The version of mingw-w64 used in Guix didn't change with 711ce2e5333bd6717f9b114abe7ec1d1994afbc4. Previously (22.0) we used 8.0.0 from the version-1.3.0 Guix branch, and the version in Guix master at present is still 8.0.0.

ci: use Ubuntu Jammy for Windows CI

This means we'll compile using GCC 10.3.x and mingw-w64 8.0.0 which
better matches our Guix release environment.

a1515cdd96

fanquake force-pushed on Feb 18, 2022
fanquake commented at 3:54 PM on February 18, 2022: member

I've rebased this. It's now passing locally when I run the CI.
MarcoFalke commented at 3:57 PM on February 18, 2022: member

cr ACK a1515cdd9683942d733ff509b785cb3ca73c7a30
hebasto approved
hebasto commented at 8:47 PM on February 20, 2022: member

ACK a1515cdd9683942d733ff509b785cb3ca73c7a30, I have reviewed the code and it looks OK, I agree it can be merged.
MarcoFalke merged this on Feb 21, 2022
MarcoFalke closed this on Feb 21, 2022
fanquake deleted the branch on Feb 21, 2022
sidhujag referenced this in commit 5af14037fb on Feb 22, 2022
DrahtBot locked this on Feb 21, 2023

Contributors

Labels