build: header-only Boost #24301

pull fanquake wants to merge 3 commits into bitcoin:master from fanquake:boost_test_header_only changing 20 files +19 −288
  1. fanquake commented at 6:28 pm on February 9, 2022: member

    This PR converts our Boost usage to header only. We switch from using our last remaining Boost lib (unit test), to using it’s header-only implementation (see https://www.boost.org/doc/libs/1_78_0/libs/test/doc/html/boost_test/adv_scenarios/single_header_customizations/multiple_translation_units.html).

    Also related to #24291.

    Guix build:

  2. fanquake added the label Build system on Feb 9, 2022
  3. MarcoFalke commented at 6:33 pm on February 9, 2022: member

    Didn’t know that boost unit test is also header-only.

    Concept ACK, I guess :rocket:

  4. hebasto commented at 6:37 pm on February 9, 2022: member
    Concept ACK.
  5. MarcoFalke commented at 6:41 pm on February 9, 2022: member
    Does this bump the minimum req. boost version?
  6. laanwj commented at 7:44 pm on February 9, 2022: member
    Concept ACK, this is a nice cleanup to configure.ac.
  7. in depends/packages/boost.mk:9 in 9c0cf03ea7 outdated 
    43-endef
44 
45 define $(package)_stage_cmds
46-  b2 -d0 -j4 --prefix=$($(package)_staging_prefix_dir) $($(package)_config_opts) toolset=$($(package)_toolset_$(host_os)) --no-cmake-config install
47+  mkdir -p $($(package)_staging_prefix_dir)/include && \
48+  cp -r boost $($(package)_staging_prefix_dir)/include
    laanwj commented at 7:46 pm on February 9, 2022:
    Nice.
  8. in configure.ac:1495 in 9c0cf03ea7 outdated 
    1497-      [TESTDEFS="$TESTDEFS -DBOOST_TEST_DYN_LINK"],
1498-      [AC_MSG_RESULT([no])])
1499-    LIBS="$TEMP_LIBS"
1500-    CPPFLAGS="$TEMP_CPPFLAGS"
1501-
1502-  fi
    laanwj commented at 7:52 pm on February 9, 2022:
    build-aux/m4/ax_boost_unit_test_framework.m4 can go after this?
    fanquake commented at 9:27 pm on February 9, 2022:
    Yes; will be dropped in the next push.
  9. fanquake force-pushed on Feb 9, 2022
  10. fanquake commented at 9:30 pm on February 9, 2022: member

    Updated to fix the linter, added a commit to use Boost 1.78.0, and removed the Boost Unit Test macro.

    Does this bump the minimum req. boost version?

    I’ll need to double check this.

    TSAN failure from previous change:

     0==================
 1WARNING: ThreadSanitizer: data race (pid=90566)
 2  Read of size 4 at 0x7fcbd5a62f40 by thread T4 (mutexes: write M1909):
 3    [#0](/bitcoin-bitcoin/0/) std::__1::ios_base::flags() const /usr/lib/llvm-13/bin/../include/c++/v1/ios:461:12 (test_bitcoin+0x2192b8)
 4    [#1](/bitcoin-bitcoin/1/) std::__1::basic_ostream<char, std::__1::char_traits<char> >& std::__1::__put_character_sequence<char, std::__1::char_traits<char> >(std::__1::basic_ostream<char, std::__1::char_traits<char> >&, char const*, unsigned long) /usr/lib/llvm-13/bin/../include/c++/v1/ostream:720:40 (test_bitcoin+0x2192b8)
 5    [#2](/bitcoin-bitcoin/2/) std::__1::basic_ostream<char, std::__1::char_traits<char> >& std::__1::operator<<<char, std::__1::char_traits<char>, std::__1::allocator<char> >(std::__1::basic_ostream<char, std::__1::char_traits<char> >&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) /usr/lib/llvm-13/bin/../include/c++/v1/ostream:1041:12 (test_bitcoin+0x1d94d7)
 6    [#3](/bitcoin-bitcoin/3/) $_0::operator()(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) const src/test/main.cpp:28:15 (test_bitcoin+0x1d94d7)
 7    [#4](/bitcoin-bitcoin/4/) decltype(static_cast<$_0&>(fp)(static_cast<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&>(fp0))) std::__1::__invoke<$_0&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&>($_0&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) /usr/lib/llvm-13/bin/../include/c++/v1/type_traits:3918:1 (test_bitcoin+0x1d94d7)
 8    [#5](/bitcoin-bitcoin/5/) void std::__1::__invoke_void_return_wrapper<void, true>::__call<$_0&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&>($_0&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) /usr/lib/llvm-13/bin/../include/c++/v1/__functional/invoke.h:61:9 (test_bitcoin+0x1d94d7)
 9    [#6](/bitcoin-bitcoin/6/) std::__1::__function::__alloc_func<$_0, std::__1::allocator<$_0>, void (std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)>::operator()(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:171:16 (test_bitcoin+0x1d94d7)
10    [#7](/bitcoin-bitcoin/7/) std::__1::__function::__func<$_0, std::__1::allocator<$_0>, void (std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)>::operator()(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:345:12 (test_bitcoin+0x1d94d7)
11    [#8](/bitcoin-bitcoin/8/) std::__1::__function::__value_func<void (std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)>::operator()(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) const /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:498:16 (test_bitcoin+0xe8104b)
12    [#9](/bitcoin-bitcoin/9/) std::__1::function<void (std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)>::operator()(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) const /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:1175:12 (test_bitcoin+0xe8104b)
13    [#10](/bitcoin-bitcoin/10/) BCLog::Logger::LogPrintStr(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) src/logging.cpp:279:9 (test_bitcoin+0xe8104b)
14    [#11](/bitcoin-bitcoin/11/) void LogPrintf_<char const*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int, char const*, char const* const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) src/./logging.h:184:23 (test_bitcoin+0xd7ec50)
15    [#12](/bitcoin-bitcoin/12/) CMainSignals::TransactionRemovedFromMempool(std::__1::shared_ptr<CTransaction const> const&, MemPoolRemovalReason, unsigned long)::$_7::operator()() const src/validationinterface.cpp:215:5 (test_bitcoin+0xd84022)
16    [#13](/bitcoin-bitcoin/13/) decltype(static_cast<CMainSignals::TransactionRemovedFromMempool(std::__1::shared_ptr<CTransaction const> const&, MemPoolRemovalReason, unsigned long)::$_7&>(fp)()) std::__1::__invoke<CMainSignals::TransactionRemovedFromMempool(std::__1::shared_ptr<CTransaction const> const&, MemPoolRemovalReason, unsigned long)::$_7&>(CMainSignals::TransactionRemovedFromMempool(std::__1::shared_ptr<CTransaction const> const&, MemPoolRemovalReason, unsigned long)::$_7&) /usr/lib/llvm-13/bin/../include/c++/v1/type_traits:3918:1 (test_bitcoin+0xd84022)
17    [#14](/bitcoin-bitcoin/14/) void std::__1::__invoke_void_return_wrapper<void, true>::__call<CMainSignals::TransactionRemovedFromMempool(std::__1::shared_ptr<CTransaction const> const&, MemPoolRemovalReason, unsigned long)::$_7&>(CMainSignals::TransactionRemovedFromMempool(std::__1::shared_ptr<CTransaction const> const&, MemPoolRemovalReason, unsigned long)::$_7&) /usr/lib/llvm-13/bin/../include/c++/v1/__functional/invoke.h:61:9 (test_bitcoin+0xd84022)
18    [#15](/bitcoin-bitcoin/15/) std::__1::__function::__alloc_func<CMainSignals::TransactionRemovedFromMempool(std::__1::shared_ptr<CTransaction const> const&, MemPoolRemovalReason, unsigned long)::$_7, std::__1::allocator<CMainSignals::TransactionRemovedFromMempool(std::__1::shared_ptr<CTransaction const> const&, MemPoolRemovalReason, unsigned long)::$_7>, void ()>::operator()() /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:171:16 (test_bitcoin+0xd84022)
19    [#16](/bitcoin-bitcoin/16/) std::__1::__function::__func<CMainSignals::TransactionRemovedFromMempool(std::__1::shared_ptr<CTransaction const> const&, MemPoolRemovalReason, unsigned long)::$_7, std::__1::allocator<CMainSignals::TransactionRemovedFromMempool(std::__1::shared_ptr<CTransaction const> const&, MemPoolRemovalReason, unsigned long)::$_7>, void ()>::operator()() /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:345:12 (test_bitcoin+0xd84022)
20    [#17](/bitcoin-bitcoin/17/) std::__1::__function::__value_func<void ()>::operator()() const /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:498:16 (test_bitcoin+0xe2a2b1)
21    [#18](/bitcoin-bitcoin/18/) std::__1::function<void ()>::operator()() const /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:1175:12 (test_bitcoin+0xe2a2b1)
22    [#19](/bitcoin-bitcoin/19/) SingleThreadedSchedulerClient::ProcessQueue() src/scheduler.cpp:177:5 (test_bitcoin+0xe2a2b1)
23    [#20](/bitcoin-bitcoin/20/) decltype(*(static_cast<SingleThreadedSchedulerClient*&>(fp0)).*fp()) std::__1::__invoke<void (SingleThreadedSchedulerClient::*&)(), SingleThreadedSchedulerClient*&, void>(void (SingleThreadedSchedulerClient::*&)(), SingleThreadedSchedulerClient*&) /usr/lib/llvm-13/bin/../include/c++/v1/type_traits:3859:1 (test_bitcoin+0xe2c7ea)
24    [#21](/bitcoin-bitcoin/21/) std::__1::__bind_return<void (SingleThreadedSchedulerClient::*)(), std::__1::tuple<SingleThreadedSchedulerClient*>, std::__1::tuple<>, __is_valid_bind_return<void (SingleThreadedSchedulerClient::*)(), std::__1::tuple<SingleThreadedSchedulerClient*>, std::__1::tuple<> >::value>::type std::__1::__apply_functor<void (SingleThreadedSchedulerClient::*)(), std::__1::tuple<SingleThreadedSchedulerClient*>, 0ul, std::__1::tuple<> >(void (SingleThreadedSchedulerClient::*&)(), std::__1::tuple<SingleThreadedSchedulerClient*>&, std::__1::__tuple_indices<0ul>, std::__1::tuple<>&&) /usr/lib/llvm-13/bin/../include/c++/v1/__functional/bind.h:257:12 (test_bitcoin+0xe2c7ea)
25    [#22](/bitcoin-bitcoin/22/) std::__1::__bind_return<void (SingleThreadedSchedulerClient::*)(), std::__1::tuple<SingleThreadedSchedulerClient*>, std::__1::tuple<>, __is_valid_bind_return<void (SingleThreadedSchedulerClient::*)(), std::__1::tuple<SingleThreadedSchedulerClient*>, std::__1::tuple<> >::value>::type std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*>::operator()<>() /usr/lib/llvm-13/bin/../include/c++/v1/__functional/bind.h:292:20 (test_bitcoin+0xe2c7ea)
26    [#23](/bitcoin-bitcoin/23/) decltype(static_cast<std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*>&>(fp)()) std::__1::__invoke<std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*>&>(std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*>&) /usr/lib/llvm-13/bin/../include/c++/v1/type_traits:3918:1 (test_bitcoin+0xe2c7ea)
27    [#24](/bitcoin-bitcoin/24/) void std::__1::__invoke_void_return_wrapper<void, true>::__call<std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*>&>(std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*>&) /usr/lib/llvm-13/bin/../include/c++/v1/__functional/invoke.h:61:9 (test_bitcoin+0xe2c7ea)
28    [#25](/bitcoin-bitcoin/25/) std::__1::__function::__alloc_func<std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*>, std::__1::allocator<std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*> >, void ()>::operator()() /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:171:16 (test_bitcoin+0xe2c7ea)
29    [#26](/bitcoin-bitcoin/26/) std::__1::__function::__func<std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*>, std::__1::allocator<std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*> >, void ()>::operator()() /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:345:12 (test_bitcoin+0xe2c7ea)
30    [#27](/bitcoin-bitcoin/27/) std::__1::__function::__value_func<void ()>::operator()() const /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:498:16 (test_bitcoin+0xe292bc)
31    [#28](/bitcoin-bitcoin/28/) std::__1::function<void ()>::operator()() const /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:1175:12 (test_bitcoin+0xe292bc)
32    [#29](/bitcoin-bitcoin/29/) CScheduler::serviceQueue() src/scheduler.cpp:64:17 (test_bitcoin+0xe292bc)
33    [#30](/bitcoin-bitcoin/30/) ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0::operator()() const src/test/util/setup_common.cpp:156:110 (test_bitcoin+0x9bdaa8)
34    [#31](/bitcoin-bitcoin/31/) decltype(static_cast<ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0&>(fp)()) std::__1::__invoke<ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0&>(ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0&) /usr/lib/llvm-13/bin/../include/c++/v1/type_traits:3918:1 (test_bitcoin+0x9bdaa8)
35    [#32](/bitcoin-bitcoin/32/) void std::__1::__invoke_void_return_wrapper<void, true>::__call<ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0&>(ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0&) /usr/lib/llvm-13/bin/../include/c++/v1/__functional/invoke.h:61:9 (test_bitcoin+0x9bdaa8)
36    [#33](/bitcoin-bitcoin/33/) std::__1::__function::__alloc_func<ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0, std::__1::allocator<ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0>, void ()>::operator()() /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:171:16 (test_bitcoin+0x9bdaa8)
37    [#34](/bitcoin-bitcoin/34/) std::__1::__function::__func<ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0, std::__1::allocator<ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0>, void ()>::operator()() /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:345:12 (test_bitcoin+0x9bdaa8)
38    [#35](/bitcoin-bitcoin/35/) std::__1::__function::__value_func<void ()>::operator()() const /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:498:16 (test_bitcoin+0xebff6f)
39    [#36](/bitcoin-bitcoin/36/) std::__1::function<void ()>::operator()() const /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:1175:12 (test_bitcoin+0xebff6f)
40    [#37](/bitcoin-bitcoin/37/) util::TraceThread(char const*, std::__1::function<void ()>) src/util/thread.cpp:18:9 (test_bitcoin+0xebff6f)
41    [#38](/bitcoin-bitcoin/38/) decltype(static_cast<void (*>(fp)(static_cast<char const*>(fp0), static_cast<ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0>(fp0))) std::__1::__invoke<void (*)(char const*, std::__1::function<void ()>), char const*, ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0>(void (*&&)(char const*, std::__1::function<void ()>), char const*&&, ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0&&) /usr/lib/llvm-13/bin/../include/c++/v1/type_traits:3918:1 (test_bitcoin+0x9bd6a1)
42    [#39](/bitcoin-bitcoin/39/) void std::__1::__thread_execute<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(char const*, std::__1::function<void ()>), char const*, ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0, 2ul, 3ul>(std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(char const*, std::__1::function<void ()>), char const*, ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0>&, std::__1::__tuple_indices<2ul, 3ul>) /usr/lib/llvm-13/bin/../include/c++/v1/thread:280:5 (test_bitcoin+0x9bd6a1)
43    [#40](/bitcoin-bitcoin/40/) void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(char const*, std::__1::function<void ()>), char const*, ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0> >(void*) /usr/lib/llvm-13/bin/../include/c++/v1/thread:291:5 (test_bitcoin+0x9bd6a1)
  11. theuni commented at 10:03 pm on February 9, 2022: member
    Nice! Concept ACK.
  12. MarcoFalke commented at 7:41 am on February 10, 2022: member

    TSAN failure from previous change:

    I haven’t checked in detail, but this looks like a known bug. Maybe adjust the suppressions for now?

  13. fanquake force-pushed on Feb 10, 2022
  14. fanquake commented at 7:58 am on February 10, 2022: member
    Added a suppression, removed a suppression, pruned out BOOST_LIBS.
  15. fanquake force-pushed on Feb 10, 2022
  16. fanquake renamed this:
    [POC] build: header-only Boost
    build: header-only Boost
    on Feb 10, 2022
  17. fanquake marked this as ready for review on Feb 10, 2022
  18. fanquake commented at 10:59 am on February 10, 2022: member
    Removed the Boost bump (no need to do that here, and it may have other issues), and have marked this as ready for review. The failure in the ARM CI looks unrelated. Updated the PR description as well.
  19. Sjors commented at 6:23 pm on February 10, 2022: member

    Nice!

    Tested 52bc718dbc7e6192a73d86619e48dd222a57f8a9 on macOS 12.2 with and without depends… (Boost 1.76.0, glad we don’t need 1.78 since it’s not on Homebrew yet #91224). Still compiles and tests seem happy.

  20. MarcoFalke commented at 7:03 pm on February 10, 2022: member

    The docs were put up in 1.69: https://www.boost.org/doc/libs/1_69_0/libs/test/doc/html/boost_test/adv_scenarios/single_header_customizations/multiple_translation_units.html

    Our minimum is 1.64

    Bionic has 1.65: https://packages.ubuntu.com/bionic/libboost-dev

    Bionic seems to pass with CXX='clang++-8 -stdlib=libc++' CC=clang-8 ./configure --disable-wallet --disable-external-signer && make -j $(nproc) on this pull. So I guess this doesn’t change the minimum required.

  21. DrahtBot commented at 12:13 pm on February 11, 2022: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #24322 ([kernel 1/n] Introduce initial libbitcoinkernel by dongcarl)
    • #23955 (build: add support for NetBSD in depends by fanquake)
    • #23340 (build: upgrade to boost 1.77 to fix c++20 compilation by PastaPastaPasta)
    • #23203 ([POC] build: static musl libc based bitcoind (with LTO) by fanquake)
    • #22380 (build: add and use C_STANDARD and CXX_STANDARD in depends by fanquake)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  22. fanquake commented at 3:08 pm on February 11, 2022: member

    So I guess this doesn’t change the minimum required.

    Thanks for taking a look.

    Guix build added to PR description.

  23. theStack commented at 7:08 pm on February 11, 2022: member
    Concept ACK
  24. sipa commented at 7:09 pm on February 11, 2022: member
    Concept ACK!
  25. fanquake force-pushed on Feb 11, 2022
  26. MarcoFalke added the label DrahtBot Guix build requested on Feb 12, 2022
  27. fanquake force-pushed on Feb 13, 2022
  28. fanquake commented at 11:25 am on February 13, 2022: member
    Rebased, and added some more changes to the first commit. We don’t need to install libboost-test-dev any more, so I’ve removed that from the docs and CI.
  29. fanquake force-pushed on Feb 13, 2022
  30. fanquake force-pushed on Feb 13, 2022
  31. in depends/packages/boost.mk:9 in 571ae1b68b outdated 
    46-endef
47 
48 define $(package)_stage_cmds
49-  b2 -d0 -j4 --prefix=$($(package)_staging_prefix_dir) $($(package)_config_opts) toolset=$($(package)_toolset_$(host_os)) --no-cmake-config install
50+  mkdir -p $($(package)_staging_prefix_dir)/include && \
51+  cp -r boost $($(package)_staging_prefix_dir)/include
    hebasto commented at 12:42 pm on February 13, 2022:

    Maybe drop stuff we are not going to use:

    0  // For reference, see test/lint/lint-includes.sh
1  cp boost/algorithm/string.hpp $($(package)_staging_prefix_dir)/include && \
2  cp -r boost/algorithm/string $($(package)_staging_prefix_dir)/include && \
3  cp -r boost/date_time $($(package)_staging_prefix_dir)/include && \
4  cp -r boost/multi_index $($(package)_staging_prefix_dir)/include && \
5  cp boost/process.hpp $($(package)_staging_prefix_dir)/include && \
6  cp -r boost/process $($(package)_staging_prefix_dir)/include && \
7  cp -r boost/signals2 $($(package)_staging_prefix_dir)/include && \
8  cp -r boost/test $($(package)_staging_prefix_dir)/include

    ?

    fanquake commented at 3:44 pm on February 13, 2022:
    This isn’t going to work as-is, because the headers are not self-contained enough, and will include headers from other parts of Boost. It’s also missing version.hpp, which would be needed for the configure checks, and config.hpp. I think a better way to do this could be to use something like bcp, but that can be done in a follow up.
  32. in src/test/main.cpp:6 in 571ae1b68b outdated 
    2@@ -3,11 +3,13 @@
3 // file COPYING or http://www.opensource.org/licenses/mit-license.php.
4 
5 /**
6- * See https://www.boost.org/doc/libs/1_71_0/libs/test/doc/html/boost_test/utf_reference/link_references/link_boost_test_module_macro.html
7+ * See https://www.boost.org/doc/libs/1_78_0/libs/test/doc/html/boost_test/adv_scenarios/single_header_customizations/multiple_translation_units.html
    hebasto commented at 1:10 pm on February 13, 2022:

    Considering that our minimum required boost version is 1.64.0, maybe point at the earliest available version of the same page:

    0 * See https://www.boost.org/doc/libs/1_69_0/libs/test/doc/html/boost_test/adv_scenarios/single_header_customizations/multiple_translation_units.html

    ?

    fanquake commented at 2:32 pm on February 13, 2022:
    I don’t think this matters.
  33. hebasto commented at 1:10 pm on February 13, 2022: member

    Approach ACK 571ae1b68b9e6bccfea35859ee2959ef65876083.

    From my understanding of https://www.boost.org/doc/libs/1_68_0/libs/test/doc/adv_scenarios/single_header_customizations.qbk, some changes are required for a single translation unit, therefore, they could be reverted back:

     0--- a/src/test/main.cpp
 1+++ b/src/test/main.cpp
 2@@ -6,8 +6,6 @@
 3  * See https://www.boost.org/doc/libs/1_78_0/libs/test/doc/html/boost_test/adv_scenarios/single_header_customizations/multiple_translation_units.html
 4  */
 5 #define BOOST_TEST_MODULE Bitcoin Core Test Suite
 6-#define BOOST_TEST_NO_MAIN
 7-#define BOOST_TEST_ALTERNATIVE_INIT_API
 8 
 9 #include <boost/test/included/unit_test.hpp>
10 
11@@ -41,8 +39,3 @@ const std::function<std::vector<const char*>()> G_TEST_COMMAND_LINE_ARGUMENTS =
12     }
13     return args;
14 };
15-
16-int main(int argc, char* argv[], char* envp[])
17-{
18-  return boost::unit_test::unit_test_main(init_unit_test, argc, argv);
19-}
  34. in test/sanitizer_suppressions/tsan:34 in 571ae1b68b outdated 
    29@@ -30,6 +30,8 @@ race:validation_chainstatemanager_tests
30 deadlock:libdb
31 race:libzmq
32 
33+race:std::__1::ios_base::flags
    hebasto commented at 1:12 pm on February 13, 2022:
    Add a comment that this suppression is related to headers-only version of Boost.Test?
    fanquake commented at 3:44 pm on February 13, 2022:
    Added a comment for the next push.
  35. hebasto commented at 1:45 pm on February 13, 2022: member

    Guix builds:

     0$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 1e66d35475e19f6cfef6ee79c6d5ec2d214b0bed4ece32093fe409f94c10c23eb  guix-build-571ae1b68b9e/output/aarch64-linux-gnu/SHA256SUMS.part
 2341c236e55af9102d443363f282cfef37998472b5cc108008eb6e229b1eaa37d  guix-build-571ae1b68b9e/output/aarch64-linux-gnu/bitcoin-571ae1b68b9e-aarch64-linux-gnu-debug.tar.gz
 39b4c803c897aa442e2817592b4d2aa707a671663abd989bb8e77751b2736bb09  guix-build-571ae1b68b9e/output/aarch64-linux-gnu/bitcoin-571ae1b68b9e-aarch64-linux-gnu.tar.gz
 492e2143236bcb160f3f271b8c892bc853c50bf05e1fa1b396dc708a36be82dac  guix-build-571ae1b68b9e/output/arm-linux-gnueabihf/SHA256SUMS.part
 57535e69488cff3091d6bec05b4644239799638a8692b6b15a2329884b2704e6b  guix-build-571ae1b68b9e/output/arm-linux-gnueabihf/bitcoin-571ae1b68b9e-arm-linux-gnueabihf-debug.tar.gz
 6e30fbde2c459015dda328a1fd8098fac7d7f5759ebeb9a062c4ff77fea3a6ebf  guix-build-571ae1b68b9e/output/arm-linux-gnueabihf/bitcoin-571ae1b68b9e-arm-linux-gnueabihf.tar.gz
 745934667cb52591437b27e21f6ae6fa5995a79aaf47b023439611bfbefe04c61  guix-build-571ae1b68b9e/output/arm64-apple-darwin/SHA256SUMS.part
 83f1886febc5304181e5de792cf3c9606779c3fca7dc5b921db772746c03211bd  guix-build-571ae1b68b9e/output/arm64-apple-darwin/bitcoin-571ae1b68b9e-arm64-apple-darwin.tar.gz
 974c0453f2ff6a605d7c31b58324bb863c2976ab908d5f1f7098370f858a9ce16  guix-build-571ae1b68b9e/output/arm64-apple-darwin/bitcoin-571ae1b68b9e-osx-unsigned.dmg
1081c1ec6a691a333e12268fe8d24e3e7b3fdcc30e9b40cccdf7fa602e2ff2ce1e  guix-build-571ae1b68b9e/output/arm64-apple-darwin/bitcoin-571ae1b68b9e-osx-unsigned.tar.gz
111ff2e5f5e3b04aea3edb3a3a36fffc85bf3d8d4039c277d1412dd5b46461d275  guix-build-571ae1b68b9e/output/dist-archive/bitcoin-571ae1b68b9e.tar.gz
12600fbcb6285964b098a67c7b737a80b5607b39ef8ce5d38b741374b854a02b41  guix-build-571ae1b68b9e/output/powerpc64-linux-gnu/SHA256SUMS.part
13b78e5b09f87f1122d2f448dfa94e6a2a1b8f46c27c77e0d2c3bd95a63706bba9  guix-build-571ae1b68b9e/output/powerpc64-linux-gnu/bitcoin-571ae1b68b9e-powerpc64-linux-gnu-debug.tar.gz
142aca6c47f5a350ab4857b1a3ef80e6be00bcd874588436b6177c75ca25e0f994  guix-build-571ae1b68b9e/output/powerpc64-linux-gnu/bitcoin-571ae1b68b9e-powerpc64-linux-gnu.tar.gz
15f953b5cc55cb0b61496468e090a8cd52118083174ebc02881c0900d8282918cc  guix-build-571ae1b68b9e/output/powerpc64le-linux-gnu/SHA256SUMS.part
168d220214ac7135d05a69f27bc38ef508b39674113fdd89f52cef0840fb04a9dd  guix-build-571ae1b68b9e/output/powerpc64le-linux-gnu/bitcoin-571ae1b68b9e-powerpc64le-linux-gnu-debug.tar.gz
17620c6247866526f1937f5e9761daf4cbbc58f649b523b056e5d01c02c1592bdf  guix-build-571ae1b68b9e/output/powerpc64le-linux-gnu/bitcoin-571ae1b68b9e-powerpc64le-linux-gnu.tar.gz
18aa6fa6f64fffd50ab166753049c961c1bd57a11d66d337bfccc5865df2431858  guix-build-571ae1b68b9e/output/riscv64-linux-gnu/SHA256SUMS.part
193b6533546d5f08ab0b37bdf42fac9a58acf8ec2f14aad31ceda4480eaa0e2408  guix-build-571ae1b68b9e/output/riscv64-linux-gnu/bitcoin-571ae1b68b9e-riscv64-linux-gnu-debug.tar.gz
208f2371f1693fd85f1815295be76f91983f2e734c463dbad567982b907207221d  guix-build-571ae1b68b9e/output/riscv64-linux-gnu/bitcoin-571ae1b68b9e-riscv64-linux-gnu.tar.gz
2103107719387f739208c3a16d915a09367b68d9d845a1f2dc1497f586ee8edc7d  guix-build-571ae1b68b9e/output/x86_64-apple-darwin/SHA256SUMS.part
22904b2dc8119839713560279312473f15b5af0b4e0ef30f550ec959942854ae25  guix-build-571ae1b68b9e/output/x86_64-apple-darwin/bitcoin-571ae1b68b9e-osx-unsigned.dmg
23eff39df332d85ef73cd50cec1f6b2b9dfa3fb1ae7110e533deb9de8ec519e58f  guix-build-571ae1b68b9e/output/x86_64-apple-darwin/bitcoin-571ae1b68b9e-osx-unsigned.tar.gz
24768d687ac5d92132e629c990585b97a03b135215346f5457728456f4f3f67894  guix-build-571ae1b68b9e/output/x86_64-apple-darwin/bitcoin-571ae1b68b9e-osx64.tar.gz
2555fdb506bfa073da64dfbfc5fe61bd359afce11adf304cae2461a8d37bd91d7f  guix-build-571ae1b68b9e/output/x86_64-linux-gnu/SHA256SUMS.part
26d97635485b3e5644d9731cf4d4ed146161410ed590faf160dcae08ae1d84a08d  guix-build-571ae1b68b9e/output/x86_64-linux-gnu/bitcoin-571ae1b68b9e-x86_64-linux-gnu-debug.tar.gz
273caf5d1c6e39a77be52c0a384094c335b8a8a6a99d9e0615ea6aeb08c0c41646  guix-build-571ae1b68b9e/output/x86_64-linux-gnu/bitcoin-571ae1b68b9e-x86_64-linux-gnu.tar.gz
  36. fanquake force-pushed on Feb 13, 2022
  37. hebasto approved
  38. hebasto commented at 5:07 pm on February 13, 2022: member
    ACK 46b905163530e86ea86a89b0950a88ad4aa03761
  39. hebasto commented at 7:39 pm on February 13, 2022: member

    Guix builds:

     0$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 1696f9eeedc8436dfaa6bf4376a00950ae870c4a1df150430e3cabbcbe270761a  guix-build-46b905163530/output/aarch64-linux-gnu/SHA256SUMS.part
 2942903711be8139face084758ed597f0658a54f0976a6de2387e4a0b3e48c321  guix-build-46b905163530/output/aarch64-linux-gnu/bitcoin-46b905163530-aarch64-linux-gnu-debug.tar.gz
 31d33af2b9eb8b90a0ed133acdb2a862d4d5fc972b09e624f10b8363c4de7b679  guix-build-46b905163530/output/aarch64-linux-gnu/bitcoin-46b905163530-aarch64-linux-gnu.tar.gz
 4fe1dcae66447348c647e3777fd1324fffc2c7276684b2a12e86a8a33bec5525e  guix-build-46b905163530/output/arm-linux-gnueabihf/SHA256SUMS.part
 5344ec0ea8b94dab1e12786c60bff75069ba0eedce6b292c8b1f55ac54571b819  guix-build-46b905163530/output/arm-linux-gnueabihf/bitcoin-46b905163530-arm-linux-gnueabihf-debug.tar.gz
 62c9d0238e1a31155a6cefe07c7ae92fcf4897d6dc952169024d56a192a2d8e7e  guix-build-46b905163530/output/arm-linux-gnueabihf/bitcoin-46b905163530-arm-linux-gnueabihf.tar.gz
 70e2ab4836244c63295ac390b718e8163d0323c48e6a59fbf0160b136c15cca3c  guix-build-46b905163530/output/arm64-apple-darwin/SHA256SUMS.part
 8da224a7c6acfe387a970d43835aca8e108d3ae131f2b5e78d6635eafdf3ba64d  guix-build-46b905163530/output/arm64-apple-darwin/bitcoin-46b905163530-arm64-apple-darwin.tar.gz
 9e774bf43d02567d30b8a91c4e5b267428601f86c10c84b14a78ecc4060fe277c  guix-build-46b905163530/output/arm64-apple-darwin/bitcoin-46b905163530-osx-unsigned.dmg
100633977d7c9655af3ff96ce1afec49deae80669358a60b4edbc6c121a68d34c1  guix-build-46b905163530/output/arm64-apple-darwin/bitcoin-46b905163530-osx-unsigned.tar.gz
11870c3c6a12622611ce4c556eb82d192f6f8ff91017053f3ded3e6def1d364ddb  guix-build-46b905163530/output/dist-archive/bitcoin-46b905163530.tar.gz
1296f7c916883f95a331107081aa76e293bf5f74b868ca548dcd7dbbeadb37fff2  guix-build-46b905163530/output/powerpc64-linux-gnu/SHA256SUMS.part
13d9f93fb9d01335446a838cb4154989404b5da43b5e2b30ede38282e09cf1c4bf  guix-build-46b905163530/output/powerpc64-linux-gnu/bitcoin-46b905163530-powerpc64-linux-gnu-debug.tar.gz
1477b345e81fdada5b0a38b609bcee9713caf52e217630a52417c04842fec5f76f  guix-build-46b905163530/output/powerpc64-linux-gnu/bitcoin-46b905163530-powerpc64-linux-gnu.tar.gz
1556db166ee61b414615eb44206d4c2345f5b80205f51928157d15e529ac5d6817  guix-build-46b905163530/output/powerpc64le-linux-gnu/SHA256SUMS.part
163dd0b6487a93ff14c682cdcd34a712f7cca5320887222f16a251e046f3ec0342  guix-build-46b905163530/output/powerpc64le-linux-gnu/bitcoin-46b905163530-powerpc64le-linux-gnu-debug.tar.gz
179e77d10a71ec9651f75979e1e86a4941ff65ac919e488ab97f0df6b9d8659e38  guix-build-46b905163530/output/powerpc64le-linux-gnu/bitcoin-46b905163530-powerpc64le-linux-gnu.tar.gz
18222774b0f9c27f809f2a119060b6cdd5599d21ab2d155571b96ab268ab2e204f  guix-build-46b905163530/output/riscv64-linux-gnu/SHA256SUMS.part
19974b2b931e1f1fb11280ade86f07a6ca9bf342a045888cfbe7c0bbc4f3f7a9ca  guix-build-46b905163530/output/riscv64-linux-gnu/bitcoin-46b905163530-riscv64-linux-gnu-debug.tar.gz
20dcf447792f21adf7e7a89575431435f8ead62af7711eb4ef58ccde462afc4a81  guix-build-46b905163530/output/riscv64-linux-gnu/bitcoin-46b905163530-riscv64-linux-gnu.tar.gz
2192b9bf892c21b78888f63e57a861bbe1da46d1d7acb818b59e0b428fbba3889c  guix-build-46b905163530/output/x86_64-apple-darwin/SHA256SUMS.part
22cbdd177a07b36594275599b9c007eac647ad0c867deaca3730bc92b5b1feb3d7  guix-build-46b905163530/output/x86_64-apple-darwin/bitcoin-46b905163530-osx-unsigned.dmg
23f065ff5a113e891d94744dfd8ee4f40889121d827730b85fd3725bee899f69a6  guix-build-46b905163530/output/x86_64-apple-darwin/bitcoin-46b905163530-osx-unsigned.tar.gz
2410683266ada9544a9e59255dea32d476f655c9135bcc51d612af1eedc19c1b1e  guix-build-46b905163530/output/x86_64-apple-darwin/bitcoin-46b905163530-osx64.tar.gz
25b9c1f758f15f68f18751cfa456f18e17d8cde5104137bb0a7ed9f7b048916b3a  guix-build-46b905163530/output/x86_64-linux-gnu/SHA256SUMS.part
2602a341392452f0fe46fecfef09bfab9d8a99c4579568bca15480e3ae3676e6e3  guix-build-46b905163530/output/x86_64-linux-gnu/bitcoin-46b905163530-x86_64-linux-gnu-debug.tar.gz
276d9d6cb535694cd16285746a8fbafe2bd4752f4958ab47a36d2e1f6c958a3d23  guix-build-46b905163530/output/x86_64-linux-gnu/bitcoin-46b905163530-x86_64-linux-gnu.tar.gz
  40. build: use header-only Boost unit test 39e66e938f
  41. build: header-only Boost 2037a3b6c1
  42. build: remove native B2 package 5d399f9f3d
  43. fanquake force-pushed on Feb 13, 2022
  44. fanquake commented at 9:02 pm on February 13, 2022: member
    I’ve removed a leftover instance of BOOST_LIBS and BOOST_UNIT_TEST_FRAMEWORK_LIB. Should be easy to re-ACK.
  45. hebasto approved
  46. hebasto commented at 11:40 pm on February 13, 2022: member

    re-ACK 5d399f9f3df513a0400049238f5ef0ef2352d57e

    I’ve additionally verified building of test_bitcoin.exe with MSVC on Windows 10.

  47. hebasto commented at 7:47 am on February 14, 2022: member

    Guix builds:

     0$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 1342270b55666026b8bb15ab628bdf13474358dbab3413360944c1dd63544ddd8  guix-build-5d399f9f3df5/output/aarch64-linux-gnu/SHA256SUMS.part
 28d17415e272608b59e4f05b6632c66988f3ace386e2672ee6bbd6c208111f919  guix-build-5d399f9f3df5/output/aarch64-linux-gnu/bitcoin-5d399f9f3df5-aarch64-linux-gnu-debug.tar.gz
 38f2e2049e18be8106024bed335be07afa2f1502097ae9dc8cb0d12e638add212  guix-build-5d399f9f3df5/output/aarch64-linux-gnu/bitcoin-5d399f9f3df5-aarch64-linux-gnu.tar.gz
 4c2df391b62efc9f43c7a81555636a1d6badbcf51e562e8dfa5c3a8b001892127  guix-build-5d399f9f3df5/output/arm-linux-gnueabihf/SHA256SUMS.part
 5013515a3e6ead9284eadbdb6b6d8167928cc4ca852f66a4f7e828f9b4f6b1997  guix-build-5d399f9f3df5/output/arm-linux-gnueabihf/bitcoin-5d399f9f3df5-arm-linux-gnueabihf-debug.tar.gz
 65b036d03399b84dd6e57ea51cfa7007bdeaef6c89282ac99c2920dd2ca609091  guix-build-5d399f9f3df5/output/arm-linux-gnueabihf/bitcoin-5d399f9f3df5-arm-linux-gnueabihf.tar.gz
 717cb8e6c004e92ca387c20c29798f698281257993a20aba43ddd7533ec52b35c  guix-build-5d399f9f3df5/output/arm64-apple-darwin/SHA256SUMS.part
 8151911e4488721c70068905c248256a16ff87ae4cb419c810ddb62a8b27f5d2d  guix-build-5d399f9f3df5/output/arm64-apple-darwin/bitcoin-5d399f9f3df5-arm64-apple-darwin.tar.gz
 9aae5f0448cf51ed340d7d13c59345c77cebea70d03ed43fb063a9cdb9f48944d  guix-build-5d399f9f3df5/output/arm64-apple-darwin/bitcoin-5d399f9f3df5-osx-unsigned.dmg
100db04585726aba2a1bcfe1ba0150a606d1f62c74da7ad792ff8bdf06d8a35dcd  guix-build-5d399f9f3df5/output/arm64-apple-darwin/bitcoin-5d399f9f3df5-osx-unsigned.tar.gz
11eabb3b51338cafff4c3ae59bde6bb5990dc51c4a18e64affc0d51f3ba5dbde31  guix-build-5d399f9f3df5/output/dist-archive/bitcoin-5d399f9f3df5.tar.gz
12d333668cfeae8f12640125b3e59282006cd448732b557eb16c6215289bdd2254  guix-build-5d399f9f3df5/output/powerpc64-linux-gnu/SHA256SUMS.part
131d4e7f94d2ba86296d08cf013800c70380a607bd4c036fe6aec7c2a9e086e419  guix-build-5d399f9f3df5/output/powerpc64-linux-gnu/bitcoin-5d399f9f3df5-powerpc64-linux-gnu-debug.tar.gz
143c311d7be2e99bc0525458a3d1e62981a0931e74fbc1b7fbc57bb6605c0467c3  guix-build-5d399f9f3df5/output/powerpc64-linux-gnu/bitcoin-5d399f9f3df5-powerpc64-linux-gnu.tar.gz
1554236dd3475e8ec25bb4846deeb1559bd59e066ae5ca281ec1303c542c29b998  guix-build-5d399f9f3df5/output/powerpc64le-linux-gnu/SHA256SUMS.part
1684d54e433ac333fc4375248222b505deddff27b2dc674e7d98025a23e85dd04a  guix-build-5d399f9f3df5/output/powerpc64le-linux-gnu/bitcoin-5d399f9f3df5-powerpc64le-linux-gnu-debug.tar.gz
17015328a4dbf8dc4de81b481849adfbf3aa10c507822ef8a08c7b62bd31c95c57  guix-build-5d399f9f3df5/output/powerpc64le-linux-gnu/bitcoin-5d399f9f3df5-powerpc64le-linux-gnu.tar.gz
18547692ca0c98f75dba521030c2dfba51264502ffd8469d382000baf2f1bc711d  guix-build-5d399f9f3df5/output/riscv64-linux-gnu/SHA256SUMS.part
19c3ad252075a822a2141806cf6635a140d8790df02c5b7a045f824609b94c82c2  guix-build-5d399f9f3df5/output/riscv64-linux-gnu/bitcoin-5d399f9f3df5-riscv64-linux-gnu-debug.tar.gz
20ae65d7c75d5881f01622a978c4c490b835a79ce0cbb224da6d56633432eaf635  guix-build-5d399f9f3df5/output/riscv64-linux-gnu/bitcoin-5d399f9f3df5-riscv64-linux-gnu.tar.gz
219ad380cf4e2e5aec5ede5dd4d0a27bc8de79d2f16a97e7a6bde441a164a7e9d8  guix-build-5d399f9f3df5/output/x86_64-apple-darwin/SHA256SUMS.part
229fb60025359b785e3c7577c2f6820e40dfb895eb6491fea2795748ec93004f1c  guix-build-5d399f9f3df5/output/x86_64-apple-darwin/bitcoin-5d399f9f3df5-osx-unsigned.dmg
23dd2ef7250879cea902038e2967478a761080b66de4bb1cc87a1521696c0fd26f  guix-build-5d399f9f3df5/output/x86_64-apple-darwin/bitcoin-5d399f9f3df5-osx-unsigned.tar.gz
24145c8cc6e739b6891d4611bcdcb5c58cffcebf9bc1689529a6b1f3878bcee7ec  guix-build-5d399f9f3df5/output/x86_64-apple-darwin/bitcoin-5d399f9f3df5-osx64.tar.gz
251a81f1365dc552b57815ee48150f76acff648505af73fcc7961b24dd370c1065  guix-build-5d399f9f3df5/output/x86_64-linux-gnu/SHA256SUMS.part
26c462ab2acfd2485d526f8c08774d9384c746d6d6446d38783b93a46aafe3f17d  guix-build-5d399f9f3df5/output/x86_64-linux-gnu/bitcoin-5d399f9f3df5-x86_64-linux-gnu-debug.tar.gz
271c1b24233ad189157259258f263bf5c0baedb03b9de28f9f647c28eeb1425c51  guix-build-5d399f9f3df5/output/x86_64-linux-gnu/bitcoin-5d399f9f3df5-x86_64-linux-gnu.tar.gz
  48. MarcoFalke approved
  49. MarcoFalke commented at 8:39 am on February 14, 2022: member

    Did not test on OpenBSD.

    approach ACK 5d399f9f3df513a0400049238f5ef0ef2352d57e 📞

    Signature:

     0-----BEGIN PGP SIGNED MESSAGE-----
 1Hash: SHA512
 2
 3approach ACK 5d399f9f3df513a0400049238f5ef0ef2352d57e 📞
 4-----BEGIN PGP SIGNATURE-----
 5
 6iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
 7pUh1LgwAhNYbcUG8JabIlrScCLDnnJu9Fo+h6UoF/7uxjLDj5f0Iat87cLjeBgrP
 8ZEEXTmscefGzfA0sNblni7B7XIbMtJcLLE+RojMUKeKYVvE+9bwEyUMPwNGHCKnU
 9Z7yK0d2BbLAiZgkJdDab1f2Xjg0ZmrQSRl+GTRd2xkCrRRBACS9C7IV1eveGOBre
10pfqHlbAo113U3V1at6nU/Q0YiG23teI/g8wLv9caeb5vNph6atwFkmLkHRwXOvO4
11R94LccJ7Kh0xV0fqgas79ffy1Bpz9SEXuO1LX3y3cUOZqY5TVKLtaqrov/mjZsYE
12w26/Z86s02WyOYWjGi/RUa3xigOwia7rGapWWvIH+U4LlB+ovlZq3PTwM4kucrtN
13Ha5uNFK6CVMb4XTad8nyCkkDBPvY/9bS6Dqo975z1lPoCHnPKe4bKBSxIA94XMdH
143TAwkeUZmH7xzYuXiIkdimNygf1kl+oQtZJtf2xevfjQAySUzywxh89DTP7DxiEF
15+Ruxzptk
16=yjNN
17-----END PGP SIGNATURE-----
  50. MarcoFalke commented at 9:22 am on February 14, 2022: member
    Tested make check on Bionic with system boost. Needs #24314 + #24254 or signer disabled.
  51. fanquake merged this on Feb 14, 2022
  52. fanquake closed this on Feb 14, 2022
  53. fanquake deleted the branch on Feb 14, 2022
  54. laanwj commented at 10:11 am on February 14, 2022: member
    I was still testing this on OpenBSD and FreeBSD. I guess it’ll be ok.
  55. MarcoFalke removed the label DrahtBot Guix build requested on Feb 14, 2022
  56. sidhujag referenced this in commit 60b7e35979 on Feb 14, 2022
  57. DrahtBot commented at 11:50 pm on February 14, 2022: member

    Guix builds

    File commit 3bb93940703e9d0f4bffda98f4fe22fb1487db34(master) commit 6f139e8d8a316596880391db24840060d2afcf6f(master and this pull)
    SHA256SUMS.part dd60a2a6ddc05117... 5d63c0588e4cb671...
    *-aarch64-linux-gnu-debug.tar.gz 8bc5bcfefab76715... 89235068998ce218...
    *-aarch64-linux-gnu.tar.gz 710321dcf5f0a4e9... ec81c52ebfef485b...
    *-arm-linux-gnueabihf-debug.tar.gz d0b5b74e80a06c13... d43323624557d6b9...
    *-arm-linux-gnueabihf.tar.gz 7540ec432bbe611b... 91ede60024ef4709...
    *-arm64-apple-darwin.tar.gz 20bd3de56c122dab... 938edea49fce366e...
    *-osx-unsigned.dmg 238a67aa27f7ed54... 751cd97a41353018...
    *-osx-unsigned.tar.gz ab189b2d1873f62f... bbd619857ba8a583...
    *-osx64.tar.gz c25bd3526668fd5b... 9f06e684ee080ab9...
    *-powerpc64-linux-gnu-debug.tar.gz d8f9c7a39538f196... 9aa6e507b2221b3f...
    *-powerpc64-linux-gnu.tar.gz 751c0e3f4371b425... a5bc9af9b0f8c6e0...
    *-powerpc64le-linux-gnu-debug.tar.gz 0b3a07e161da8e65... 28c76a0ff379f9ab...
    *-powerpc64le-linux-gnu.tar.gz df8899cbe9059ccd... 4b24c612ae2196b5...
    *-riscv64-linux-gnu-debug.tar.gz 0cb9b3fe2626bac2... 592fe119543ed040...
    *-riscv64-linux-gnu.tar.gz 08296f18f18113e9... 19baad50127e0be2...
    *-x86_64-linux-gnu-debug.tar.gz 41ecc738e3c92499... 89fb53af6fdc404f...
    *-x86_64-linux-gnu.tar.gz 9e1179bfc7d06e08... 6e8e729f76b3150c...
    *.tar.gz b7698539ff204a66... 13b5e26840ddcb00...
    guix_build.log a288ed44440d4dfb... 1c894ac83f87338e...
    guix_build.log.diff 274d21f561679853...
  58. fanquake referenced this in commit 54d817c5b9 on Feb 18, 2022
  59. fanquake referenced this in commit 8ac1858129 on Feb 18, 2022
  60. fanquake referenced this in commit 97507e51b1 on Feb 18, 2022
  61. MarcoFalke referenced this in commit 5d254a234d on Feb 18, 2022
  62. DavidKorczynski referenced this in commit 5e907e843b on Feb 18, 2022
  63. fanquake referenced this in commit 98b9d607a8 on Feb 19, 2022
  64. hmel referenced this in commit f0d2b2f9bd on Feb 20, 2022
  65. fanquake referenced this in commit af9d4757f6 on Apr 2, 2022
  66. fanquake referenced this in commit 2246d79ca0 on Apr 5, 2022
  67. fanquake referenced this in commit 0255ef5c95 on Apr 8, 2022
  68. fanquake referenced this in commit b59af8b417 on Apr 8, 2022
  69. fanquake referenced this in commit 0d7e3ccd59 on Apr 8, 2022
  70. fanquake referenced this in commit 2116d57259 on Apr 8, 2022
  71. fanquake referenced this in commit e4c20dbafb on Apr 8, 2022
  72. fanquake referenced this in commit 44e3a471d8 on Apr 8, 2022
  73. fanquake referenced this in commit d76a392efd on Apr 8, 2022
  74. fanquake referenced this in commit f121d92ae2 on Apr 8, 2022
  75. fanquake referenced this in commit 245a455908 on Apr 8, 2022
  76. fanquake referenced this in commit 8b06e018a7 on Apr 8, 2022
  77. fanquake referenced this in commit b58baa4fc1 on Apr 9, 2022
  78. fanquake referenced this in commit a6125d1a44 on Apr 26, 2022
  79. fanquake referenced this in commit 6078c1cb8c on May 19, 2022
  80. fanquake referenced this in commit cc311906e6 on Jun 1, 2022
  81. fanquake referenced this in commit 40e2cd3c0a on Jun 10, 2022
  82. fanquake referenced this in commit 987e3e7aed on Jul 5, 2022
  83. fanquake referenced this in commit 8a5cfc05c7 on Jul 17, 2022
  84. fanquake referenced this in commit 9e41207fc6 on Aug 1, 2022
  85. fanquake referenced this in commit 749fea212a on Aug 13, 2022
  86. MartinPetkov referenced this in commit 3b3127dc50 on Aug 15, 2022
  87. fanquake referenced this in commit 9e02f9627b on Aug 16, 2022
  88. fanquake referenced this in commit ac8a2c9e90 on Aug 23, 2022
  89. fanquake referenced this in commit 456c0168b5 on Sep 21, 2022
  90. fanquake referenced this in commit 23b379e382 on Sep 21, 2022
  91. fanquake referenced this in commit cf80289f2b on Nov 30, 2022
  92. fanquake referenced this in commit 0d02524540 on Dec 8, 2022
  93. fanquake referenced this in commit 800a4e98e8 on Jan 13, 2023
  94. fanquake referenced this in commit c08c0a7524 on Feb 2, 2023
  95. DrahtBot locked this on Feb 14, 2023


fanquake MarcoFalke hebasto laanwj theuni Sjors DrahtBot theStack sipa

Labels
Build system

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 15:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me