refactor: base58.cpp - preemptively remove deprecated += #24379

pull RandyMcMillan wants to merge 1 commits into bitcoin:master from RandyMcMillan:1645177905-scripted-diff-base58 changing 1 files +3 −3

RandyMcMillan commented at 10:43 AM on February 18, 2022: contributor

REF: PR #24372 REF: https://eel.is/c++draft/depr.volatile.type#example-2 carry += str += are flagged as deprecated.
DrahtBot added the label Refactoring on Feb 18, 2022
fanquake commented at 11:45 AM on February 18, 2022: member

You need to write a PR description. There's also really no need for this to be a scripted diff or two separate commits.

refactor: base58.cpp - preemptively remove deprecated +=

REF: PR #24372
REF: https://eel.is/c++draft/depr.volatile.type#example-2
carry +=
str +=
are flagged as deprecated.

786a5e6ba4

RandyMcMillan force-pushed on Feb 18, 2022
RandyMcMillan renamed this:
~~scripted-diff: base58.cpp - preemptively remove deprecated +=~~
refactor: base58.cpp - preemptively remove deprecated +=
on Feb 18, 2022
RandyMcMillan commented at 8:45 PM on February 18, 2022: contributor

commit 786a5e6ba4104475cb5409a4df446ea7f7c2733f removed scripted-diffs squashed @fanquake - thanks for you're patience and guidance.
mzumsande commented at 9:00 PM on February 18, 2022: member

Neither str nor carry are volatile, it's not like += is deprecated globally.
RandyMcMillan closed this on Feb 18, 2022
fanquake locked this on Feb 23, 2022

Contributors

Labels