Bitcoin-Qt: fix copy via context-menu broken #2441

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:Qt_fix_copy_context_menu changing 1 files +5 −4

Diapolo commented at 9:22 AM on April 2, 2013: none
- as QClipboard::Selection isn't available on Windows ensure that the correct mode is called, but sill allow selection for e.g. X11
- start conversion from QCoreApplication::instance() to qApp in guiutil.cpp (I intend to harmonize this all over the source with my Qt5 compatibility pull)
Fixes #2438

Bitcoin-Qt: fix copy via context-menu broken

- as QClipboard::Selection isn't available on Windows ensure that the
  correct mode is called, but sill allow selection for e.g. X11
- start conversion from QCoreApplication::instance() to qApp in
  guiutil.cpp (I intend to harmonize this all over the source with my Qt5
  compatibility pull)

39ee86257c

in src/qt/guiutil.cpp:None in ee83281925 outdated

 159 | @@ -160,8 +160,12 @@ void copyEntryData(QAbstractItemView *view, int column, int role)
 160 |  
 161 |      if(!selection.isEmpty())
 162 |      {
 163 | -        // Copy first item
 164 | -        QApplication::clipboard()->setText(selection.at(0).data(role).toString(),QClipboard::Selection);
 165 | +        // Copy first item (global clipboard)
 166 | +        qApp->clipboard()->setText(selection.at(0).data(role).toString(), QClipboard::Clipboard);
 167 | +#ifndef Q_OS_WIN

laanwj commented at 12:26 PM on April 2, 2013:

I don't think this ifdef is needed. Setting the Selection clipboard on windows is a NOP

Diapolo commented at 1:17 PM on April 2, 2013:

I'm fine with removing that. I introduced the second line of code, because QClipboard::Clipboard | QClipboard::Selection didn't work ;).

Diapolo commented at 1:22 PM on April 2, 2013: none

Removed the #ifdef and added info in the comment that QClipboard::Selection is a NOP on Windows.
laanwj referenced this in commit bcce45e9b0 on Apr 2, 2013
laanwj merged this on Apr 2, 2013
laanwj closed this on Apr 2, 2013
laudney referenced this in commit e6cd20e842 on Mar 19, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

laanwj

Linked (view graph)

#2438 Bitcoin-Qt: copy via context-menu broken