doc: Update bips.md for 23.x

laanwj commented at 3:55 pm on February 22, 2022: member

As far as I know, there have been no new bips implemented in this major release. Update bips.md accordingly. (if there are, please post below)

doc: Update bips.md for 23.x e97e3ded69

laanwj added the label Docs on Feb 22, 2022

laanwj added this to the milestone 23.0 on Feb 22, 2022

MarcoFalke commented at 4:03 pm on February 22, 2022: member

cr ACK e97e3ded69ba1341154bbbea0c75bfe6c09c02e0

jonatack commented at 4:07 pm on February 22, 2022: member

ACK e97e3ded69ba1341154bbbea0c75bfe6c09c02e0 if no BIPs were newly implemented in v23

fanquake commented at 4:09 pm on February 22, 2022: member

sipa on IRC:

Heh, bips.md does not list BIP157 which we support since 0.21.0.

laanwj commented at 4:23 pm on February 22, 2022: member

Added a separate commit for BIP 157/158 (as it’s unrelated to the 23.x update).

in doc/bips.md:46 in 8472b77e6b outdated

41@@ -42,7 +42,8 @@ BIPs that are implemented by Bitcoin Core (up-to-date up to **v22.0**):
42 * [`BIP 147`](https://github.com/bitcoin/bips/blob/master/bip-0147.mediawiki): NULLDUMMY softfork as of **v0.13.1** ([PR 8636](https://github.com/bitcoin/bitcoin/pull/8636) and [PR 8937](https://github.com/bitcoin/bitcoin/pull/8937)), *buried* since **v0.19.0** ([PR #16060](https://github.com/bitcoin/bitcoin/pull/16060)).
43 * [`BIP 152`](https://github.com/bitcoin/bips/blob/master/bip-0152.mediawiki): Compact block transfer and related optimizations are used as of **v0.13.0** ([PR 8068](https://github.com/bitcoin/bitcoin/pull/8068)).
44 * [`BIP 155`](https://github.com/bitcoin/bips/blob/master/bip-0155.mediawiki): The 'addrv2' and 'sendaddrv2' messages which enable relay of Tor V3 addresses (and other networks) are supported as of **v0.21.0** ([PR 19954](https://github.com/bitcoin/bitcoin/pull/19954)).
45-* [`BIP 158`](https://github.com/bitcoin/bips/blob/master/bip-0158.mediawiki): Compact Block Filters for Light Clients can be indexed as of **v0.19.0** ([PR #14121](https://github.com/bitcoin/bitcoin/pull/14121)).
46+* [`BIP 157`](https://github.com/bitcoin/bips/blob/master/bip-0157.mediawiki)
47+  [`158`](https://github.com/bitcoin/bips/blob/master/bip-0158.mediawiki): Compact Block Filters for Light Clients can be indexed as of **v0.19.0** ([PR #14121](https://github.com/bitcoin/bitcoin/pull/14121)), and served to peers on the P2P network as of **v0.21.0** ([PR #16442](https://github.com/bitcoin/bitcoin/pull/16442)).

jonatack commented at 5:07 pm on February 22, 2022:

I wondered if #16442 should be #18876 but that pull was then split into sub-pulls IIRC, so this seems right (or maybe show both).

jonatack commented at 5:10 pm on February 22, 2022:

comma-nit if retouch (the second part of the sentence is missing a subject and so there shouldn’t be a comma)

0  [`158`](https://github.com/bitcoin/bips/blob/master/bip-0158.mediawiki): Compact Block Filters for Light Clients can be indexed as of **v0.19.0** ([PR [#14121](/bitcoin-bitcoin/14121/)](https://github.com/bitcoin/bitcoin/pull/14121)) and served to peers on the P2P network as of **v0.21.0** ([PR [#16442](/bitcoin-bitcoin/16442/)](https://github.com/bitcoin/bitcoin/pull/16442)).

laanwj commented at 5:17 pm on February 22, 2022:

Updated

jonatack commented at 5:11 pm on February 22, 2022: member

ACK 8472b77e6b7bf822b4baf7a19adf95203d178231

doc: Mention missing BIP157 in bips.md

Mention BIP 157, also mention that BIP 158 is active on the P2P network
since v0.21.

03bc08e163

laanwj force-pushed on Feb 22, 2022

jonatack commented at 10:07 pm on February 22, 2022: member

ACK 03bc08e16325f43905f6e6f8d5e0ce69aa8a30a4

unknown approved

unknown commented at 4:23 am on February 23, 2022: none

ACK https://github.com/bitcoin/bitcoin/pull/24420/commits/03bc08e16325f43905f6e6f8d5e0ce69aa8a30a4

fanquake merged this on Feb 23, 2022

fanquake closed this on Feb 23, 2022

sidhujag referenced this in commit fff1299403 on Feb 23, 2022

in doc/bips.md:46 in 03bc08e163

41@@ -42,7 +42,8 @@ BIPs that are implemented by Bitcoin Core (up-to-date up to **v22.0**):
42 * [`BIP 147`](https://github.com/bitcoin/bips/blob/master/bip-0147.mediawiki): NULLDUMMY softfork as of **v0.13.1** ([PR 8636](https://github.com/bitcoin/bitcoin/pull/8636) and [PR 8937](https://github.com/bitcoin/bitcoin/pull/8937)), *buried* since **v0.19.0** ([PR #16060](https://github.com/bitcoin/bitcoin/pull/16060)).
43 * [`BIP 152`](https://github.com/bitcoin/bips/blob/master/bip-0152.mediawiki): Compact block transfer and related optimizations are used as of **v0.13.0** ([PR 8068](https://github.com/bitcoin/bitcoin/pull/8068)).
44 * [`BIP 155`](https://github.com/bitcoin/bips/blob/master/bip-0155.mediawiki): The 'addrv2' and 'sendaddrv2' messages which enable relay of Tor V3 addresses (and other networks) are supported as of **v0.21.0** ([PR 19954](https://github.com/bitcoin/bitcoin/pull/19954)).
45-* [`BIP 158`](https://github.com/bitcoin/bips/blob/master/bip-0158.mediawiki): Compact Block Filters for Light Clients can be indexed as of **v0.19.0** ([PR #14121](https://github.com/bitcoin/bitcoin/pull/14121)).
46+* [`BIP 157`](https://github.com/bitcoin/bips/blob/master/bip-0157.mediawiki)
47+  [`158`](https://github.com/bitcoin/bips/blob/master/bip-0158.mediawiki): Compact Block Filters for Light Clients can be indexed as of **v0.19.0** ([PR #14121](https://github.com/bitcoin/bitcoin/pull/14121)) and served to peers on the P2P network as of **v0.21.0** ([PR #16442](https://github.com/bitcoin/bitcoin/pull/16442)).

gruve-p commented at 3:04 pm on February 25, 2022:

158 > BIP 158

unknown commented at 3:15 pm on February 25, 2022:

BIP 157 158

It’s same as BIP 340 341 342

michaelfolkson commented at 3:17 pm on February 25, 2022:

Right, the doc doesn’t repeat “BIP” when there are multiple BIP numbers on the same line.

DrahtBot locked this on Feb 25, 2023

doc: Update bips.md for 23.x #24420