[brainstorm] Improving `makeseeds.py` #24422

issue ghost opened this issue on February 22, 2022
  1. ghost commented at 7:30 PM on February 22, 2022: none

    A. Filtering hosts with multiple ports can be removed IMO:

    https://github.com/bitcoin/bitcoin/blob/c44e734dca64a15fae92255a5d848c04adaad2fa/contrib/seeds/makeseeds.py#L215

    B. Tor v3 can also be included in the results.

    C. Recent observation which can be confirmed with:

    wget https://gitlab.com/api/v4/projects/33695681/packages/generic/nrich/0.1.1/nrich_0.1.1_amd64.deb
    sudo dpkg -i nrich_0.1.1_amd64.deb
    host -t a seed.bitcoin.sipa.be | sed -e 's/seed.bitcoin.sipa.be has address //g' | nrich -
    

    Possible reasons for vulnerable machines used for bitcoin nodes:

    1. False positives
    2. Users not aware or don't care
    3. Attackers prefer using these for better results
    4. Honeypots
    5. Other reasons

    Leaving 1 which won't be true for all the results, filtering such nodes in makeseeds.py should make sense. Below is an example for one IP copied from suspicious_hosts.txt

    ip = '88.198.17.7'
    
    url = 'https://internetdb.shodan.io/' + ip
    response = requests.get(url)
    
    if response.text.find('CVE') != -1:
        print('vulnerable')
    
  2. unknown added the label Feature on Feb 22, 2022
  3. MarcoFalke commented at 7:54 AM on February 23, 2022: member
  4. fanquake commented at 10:55 AM on February 23, 2022: member

    Discussion can continue in #17020. No need for a new issue.

  5. fanquake closed this on Feb 23, 2022

  6. DrahtBot locked this on Feb 23, 2023
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 15:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me