qt: English (source) translations update #24438

1. 
   laanwj commented at 11:41 am on February 24, 2022: member

   Last-minute update for bitcoin/bitcoin#24434 and bitcoin/bitcoin#24401.
2. qt: English (source) translations update

   Last-minute update for bitcoin/bitcoin#24434 and bitcoin/bitcoin#24401.

   38020c4f2e
3. laanwj added the label GUI on Feb 24, 2022
4. laanwj added this to the milestone 23.0 on Feb 24, 2022
5. 
   jonatack commented at 12:28 pm on February 24, 2022: member

   Light review ACK 38020c4f2eb6aae05a4745695f718034fb769c1b

   at least, as far as I can tell. Unrelated, saw the following with make translate (clang 15 and gcc 11)

    0make translate
    1  GEN      qt/bitcoinstrings.cpp
    2protocol.h:379: warning: unterminated character constant
    3util/strencodings.h:44: warning: unterminated character constant
    4  GEN      translate
    5/home/jon/projects/bitcoin/bitcoin/src/util/strencodings.h:44: Unterminated C++ character
    6/home/jon/projects/bitcoin/bitcoin/src/protocol.h:379: Unterminated C++ character
    7/home/jon/projects/bitcoin/bitcoin/src/protocol.h:359: Unbalanced opening brace in C++ code (or abuse of the C++ preprocessor)
    8/home/jon/projects/bitcoin/bitcoin/src/qt/guiutil.cpp:800: Unterminated C++ character
    9/home/jon/projects/bitcoin/bitcoin/src/qt/guiutil.cpp:803: Unterminated C++ character
   10/home/jon/projects/bitcoin/bitcoin/src/qt/guiutil.cpp:804: Unterminated C++ character
   11/home/jon/projects/bitcoin/bitcoin/src/qt/guiutil.cpp:807: Unterminated C++ character
   12/home/jon/projects/bitcoin/bitcoin/src/qt/guiutil.cpp:800: Unbalanced opening parenthesis in C++ code (or abuse of the C++ preprocessor)
   13Updating 'qt/locale/bitcoin_en.ts'...
   14    Found 1100 source text(s) (0 new and 1100 already existing)
   15  GEN      translate
   

6. 
   laanwj commented at 12:55 pm on February 24, 2022: member

   I think the warnings are harmless. They’re thrown by qtranslate when encountering constructions like 1'000. I guess it hasn’t been updated yet for new C++ syntax. As long as they don’t happen on the same line as tr() (making it possible to miss a message?) I think it doesn’t matter.
7. fanquake approved
8. 
   fanquake commented at 2:32 pm on February 24, 2022: member

   ACK 38020c4f2eb6aae05a4745695f718034fb769c1b
9. fanquake merged this on Feb 24, 2022
10. fanquake closed this on Feb 24, 2022

    ---

11. sidhujag referenced this in commit 2338943f75 on Feb 24, 2022
12. fanquake deleted a comment on Feb 24, 2022
13. DrahtBot locked this on Feb 24, 2023

Contributors
laanwj jonatack fanquake

Labels
GUI

Milestone
23.0