I observed that while updating translations, that these 2 are sharing quite a big amount of code and translations. Seems the cleanup or refactoring is not done + there is at least one open issue related to this (#2436). @laanwj Can you comment or do you know if that is intended?
Bitcoin-Qt: duplicate code in bitcoingui.cpp and walletview.cpp #2447
issue Diapolo opened this issue on April 2, 2013-
Diapolo commented at 1:59 PM on April 2, 2013: none
-
laanwj commented at 4:35 AM on April 3, 2013: member
There is a lot of redirection happening (methods forwarding to other objects) that may somehow be solved more elegantly by using signals/slot routing. But I don't see the duplicate code or messages in a first glance. Can you show a link to the line numbers?
-
Diapolo commented at 7:12 AM on April 3, 2013: none
Take a look at
WalletView::createActions()for example, it's nearly identical to the stuff in bitcoingui.cpp (and now even behind after #2428, try a diff and you'll see) and seems to be not used at all, because I have the new tab namings + that export stuff not working anymore. -
Diapolo commented at 10:04 AM on April 3, 2013: none
Also there are at least ~10 strings that now showed up on Transifex requiring a re-translation e.g.
&Change Passphrase...orChange the passphrase used for wallet encryption, which means they are also duplicated. -
Diapolo commented at 1:53 PM on April 3, 2013: none
@laanwj IMHO the duplicate QAction and connect() stuff in
::createActions()is causing some trouble currently and this needs cleanup badly. That is for sure a blocker for any new release and I'm not sure how to fix that. Can you perhaps have an in-depth look? - Diapolo closed this on Apr 3, 2013
- laudney referenced this in commit 4672dbbd70 on Mar 19, 2014
- MarcoFalke locked this on Sep 8, 2021
