Bitcoin-Qt: fix GUI after initial multi-wallet patch #2452

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:Qt_fix_GUI changing 4 files +42 −142

Diapolo commented at 3:37 PM on April 3, 2013: none
- adds 6 methods in BitcoinGUI to access some actions needed by the new WalletView class
- updates WalletView class to use these instead of trying to duplicate these
- cleanup walletview.h and remove all unneeded stuff
- this fixes problems with tabs toolbar (#2451) and export broken (#2436)
- more details in #2447

Bitcoin-Qt: fix GUI after initial multi-wallet patch

- adds 6 methods in BitcoinGUI to access some actions needed by the new
  WalletView class
- updates WalletView class to use these instead of trying to duplicate
  these
- cleanup walletview.{cpp/h} and remove all unneeded stuff
- this fixes problems with tabs toolbar (#2451) and export broken (#2436)
- more details in #2447

8726de26ee

BitcoinPullTester commented at 4:14 PM on April 3, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/8726de26ee0010eaf64d44d69cc9b8e09e580a37 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 4:15 PM on April 3, 2013: member

Thanks for the fixes! @codeshark Next time you should fix your own bugs :p

in src/qt/bitcoingui.h:None in 8726de26ee

  56 | @@ -56,9 +57,17 @@ class BitcoinGUI : public QMainWindow
  57 |  
  58 |      bool addWallet(const QString& name, WalletModel *walletModel);
  59 |      bool setCurrentWallet(const QString& name);
  60 | -    
  61 | +
  62 |      void removeAllWallets();
  63 |  
  64 | +    /** Used by WalletView to allow access to needed QActions */

laanwj commented at 4:24 PM on April 3, 2013:

I'm sure this can be done more elegantly with signals. Then again, due to the nature of the bug fixes I'm going to merge this immediately.

Diapolo commented at 8:24 PM on April 3, 2013:

I'll add a ToDo in my local build :).

laanwj referenced this in commit 7129c6ece1 on Apr 3, 2013
laanwj merged this on Apr 3, 2013
laanwj closed this on Apr 3, 2013
laudney referenced this in commit b5a4d30ea7 on Mar 19, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

BitcoinPullTester

laanwj

Linked (view graph)

#2436 Bitcoin-Qt: export broken after #2220 #2447 Bitcoin-Qt: duplicate code in bitcoingui.cpp and walletview.cpp #2451 Bitcoin-Qt: problems with tabs toolbar