We don't use the deprecated headers now, and never should do in the future, so there is no need for them to exist in depends.
The headers themselves are just full of includes for the newer headers.
build: don't install deprecated libevent headers #24526
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:dont_install_deprecated_libevent_headers changing 1 files +2 −1-
fanquake commented at 4:06 PM on March 10, 2022: member
-
339b4a51f6
build: don't install deprecated libevent headers
We don't use the deprecated headers now, and never should do in the future, so there is no need for them to exist in depends. The headers themselves are just full of includes for the newer headers.
- fanquake added the label Build system on Mar 10, 2022
- fanquake added the label DrahtBot Guix build requested on Mar 10, 2022
-
laanwj commented at 4:13 PM on March 10, 2022: member
Concept ACK, I don't think there's a reason in itself to remove unused headers from depends, but together with CI this would work as a sort of lint to prevent themfrom being included in the future.
-
hebasto commented at 4:52 PM on March 10, 2022: member
Concept ACK.
We don't use the deprecated headers now
I've verified that.
- hebasto approved
-
hebasto commented at 5:56 AM on March 11, 2022: member
ACK 339b4a51f6d3558c3489b14efe0c8c195295cf86
Guix builds on
x86_64:$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum 5239c50da86be9755ffdd0b83f2703f69e76ccfe7d046734ab788aed834a9f9b guix-build-339b4a51f6d3/output/aarch64-linux-gnu/SHA256SUMS.part 1f7965a2f8b61e9b1ee0b7bc514f95510d46d4634e3ad7efdb53c1e33c781757 guix-build-339b4a51f6d3/output/aarch64-linux-gnu/bitcoin-339b4a51f6d3-aarch64-linux-gnu-debug.tar.gz 18cb79b460f2ac34fad2e6306333fefb29a932d0c5d043e7963a960fb47ca8b4 guix-build-339b4a51f6d3/output/aarch64-linux-gnu/bitcoin-339b4a51f6d3-aarch64-linux-gnu.tar.gz 029615d044ba0b2ff56f147aa0e17b91cb49a72f8cf65824ef57c58d7f1cd16f guix-build-339b4a51f6d3/output/arm-linux-gnueabihf/SHA256SUMS.part 65fb786e3e04d512c5a57e4cc5dfe2c5fe83565678a5da76f0015dcab5f82c62 guix-build-339b4a51f6d3/output/arm-linux-gnueabihf/bitcoin-339b4a51f6d3-arm-linux-gnueabihf-debug.tar.gz bc3dd517175118ad79f16b3df0899463b8bb6b651e34d91a6b9d1bb6d9fd4c95 guix-build-339b4a51f6d3/output/arm-linux-gnueabihf/bitcoin-339b4a51f6d3-arm-linux-gnueabihf.tar.gz 5bdc59189f60db33744089f67cee8b0d04a923805fd18a8116ae38e0aa823df0 guix-build-339b4a51f6d3/output/arm64-apple-darwin/SHA256SUMS.part fbdfc4be58e07d3e79f4db01eaa7cbd8918a0d0ce4c4a45ac18faa400c427dad guix-build-339b4a51f6d3/output/arm64-apple-darwin/bitcoin-339b4a51f6d3-arm64-apple-darwin.tar.gz 70834ad1016a82ad262e1c623fb903f3ad5f37b36a2bb5c9add1156ea4992801 guix-build-339b4a51f6d3/output/arm64-apple-darwin/bitcoin-339b4a51f6d3-osx-unsigned.dmg ff90ced5d5639802b93d071fff400ccbfbd6f2aa3b3d8185734e033f1305ba09 guix-build-339b4a51f6d3/output/arm64-apple-darwin/bitcoin-339b4a51f6d3-osx-unsigned.tar.gz 961a42f5f44da48b5aca33cf79cd669469577ffd3bdb9e37a9c6da3076a3adbb guix-build-339b4a51f6d3/output/dist-archive/bitcoin-339b4a51f6d3.tar.gz c8b0736eab4be28ef434320a4a3396464e073e97e72e58dbada0e7fa5653fb31 guix-build-339b4a51f6d3/output/powerpc64-linux-gnu/SHA256SUMS.part 6a24dede89640fdc47ddb4914bea83d8096892fa37d3d38ce6ec8b2c0889f1ad guix-build-339b4a51f6d3/output/powerpc64-linux-gnu/bitcoin-339b4a51f6d3-powerpc64-linux-gnu-debug.tar.gz cf0b31eed04a3dfadae1c6a87ca9ea3bf26a4df584a2d414a16ed8adb1892d18 guix-build-339b4a51f6d3/output/powerpc64-linux-gnu/bitcoin-339b4a51f6d3-powerpc64-linux-gnu.tar.gz ac168c38123d254841b0cae26a8ab57c8e2211e1320b5fabf3643f631eb275fb guix-build-339b4a51f6d3/output/powerpc64le-linux-gnu/SHA256SUMS.part 465d5a1fae7d61a7691f31bb11129f97f180dd2f9cabb3cf6bbc5a4d9f599a06 guix-build-339b4a51f6d3/output/powerpc64le-linux-gnu/bitcoin-339b4a51f6d3-powerpc64le-linux-gnu-debug.tar.gz 0f95b42c50f48aaefd7a1a729fb78d6dd3c36184b8da348bcfbbc42df9c3f770 guix-build-339b4a51f6d3/output/powerpc64le-linux-gnu/bitcoin-339b4a51f6d3-powerpc64le-linux-gnu.tar.gz c16d69577d47c939a39f2246d753c675c25019634c827d277b0d44cc63d48228 guix-build-339b4a51f6d3/output/riscv64-linux-gnu/SHA256SUMS.part 8e84525cbf61a1c5bc6bb7f9e3d11af0a91edee3312f912bf9bd18ec715c5152 guix-build-339b4a51f6d3/output/riscv64-linux-gnu/bitcoin-339b4a51f6d3-riscv64-linux-gnu-debug.tar.gz 8eaa53a56a93b1b5e79a0753cc6af8529068dbc19974ae4c72251222532bbcab guix-build-339b4a51f6d3/output/riscv64-linux-gnu/bitcoin-339b4a51f6d3-riscv64-linux-gnu.tar.gz 9719a025650a2a92a92f4f7f8ef2bd5b3aadfbb454e4a35d6fe1ead4ff43d6bd guix-build-339b4a51f6d3/output/x86_64-apple-darwin/SHA256SUMS.part e07f577fb9d361d6396794413f27ec9a18200fa1654dd22b10971cbb1422cabc guix-build-339b4a51f6d3/output/x86_64-apple-darwin/bitcoin-339b4a51f6d3-osx-unsigned.dmg d057b2c7dcc0076760471350e1e27d933e096d935cd9123131f4baa0c1258a8d guix-build-339b4a51f6d3/output/x86_64-apple-darwin/bitcoin-339b4a51f6d3-osx-unsigned.tar.gz 644de0d0208c71baed03f5a4a5989d33888fa6f712fefe11efa5b5a9ac2b6ee9 guix-build-339b4a51f6d3/output/x86_64-apple-darwin/bitcoin-339b4a51f6d3-osx64.tar.gz cb5397e691931c72a955e944bf1fc0a76cef8f01a267036072fc93019f1ea646 guix-build-339b4a51f6d3/output/x86_64-linux-gnu/SHA256SUMS.part 4c90b73a42bd144ed3b00f05ae6ba9f21e21eae5dd84e44d2c5cc7e3da0dc212 guix-build-339b4a51f6d3/output/x86_64-linux-gnu/bitcoin-339b4a51f6d3-x86_64-linux-gnu-debug.tar.gz b499ac87ed63c4c04cdfa940ca81577f38406daccc1bfeee3cec3e6fb231be74 guix-build-339b4a51f6d3/output/x86_64-linux-gnu/bitcoin-339b4a51f6d3-x86_64-linux-gnu.tar.gz 4b39efa7593232050130cbdd52c2920ed9bff5c902eb3c4ddc27aa8f1d62af5a guix-build-339b4a51f6d3/output/x86_64-w64-mingw32/SHA256SUMS.part 737f85e2cbcb508d1cf913c6fd39434667f5fec8bea8c300aa62beae7585a5c6 guix-build-339b4a51f6d3/output/x86_64-w64-mingw32/bitcoin-339b4a51f6d3-win-unsigned.tar.gz 78a61e1844aa70015ef802c5311bfb4975a0fb011e6d5b6bbbd0a6ff42b61f6c guix-build-339b4a51f6d3/output/x86_64-w64-mingw32/bitcoin-339b4a51f6d3-win64-debug.zip 5fdd72f089ee7a0fc689971fb9e16a1bf26c63bd90333ab753b4dbf0593ee393 guix-build-339b4a51f6d3/output/x86_64-w64-mingw32/bitcoin-339b4a51f6d3-win64-setup-unsigned.exe 6cbc124adaed8b0165694853ca2995400ef161bfdf2bcbfda082572f5b50de40 guix-build-339b4a51f6d3/output/x86_64-w64-mingw32/bitcoin-339b4a51f6d3-win64.zip -
fanquake commented at 6:50 AM on March 11, 2022: member
Guix Build:
bash-5.1# find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum 5239c50da86be9755ffdd0b83f2703f69e76ccfe7d046734ab788aed834a9f9b guix-build-339b4a51f6d3/output/aarch64-linux-gnu/SHA256SUMS.part 1f7965a2f8b61e9b1ee0b7bc514f95510d46d4634e3ad7efdb53c1e33c781757 guix-build-339b4a51f6d3/output/aarch64-linux-gnu/bitcoin-339b4a51f6d3-aarch64-linux-gnu-debug.tar.gz 18cb79b460f2ac34fad2e6306333fefb29a932d0c5d043e7963a960fb47ca8b4 guix-build-339b4a51f6d3/output/aarch64-linux-gnu/bitcoin-339b4a51f6d3-aarch64-linux-gnu.tar.gz 029615d044ba0b2ff56f147aa0e17b91cb49a72f8cf65824ef57c58d7f1cd16f guix-build-339b4a51f6d3/output/arm-linux-gnueabihf/SHA256SUMS.part 65fb786e3e04d512c5a57e4cc5dfe2c5fe83565678a5da76f0015dcab5f82c62 guix-build-339b4a51f6d3/output/arm-linux-gnueabihf/bitcoin-339b4a51f6d3-arm-linux-gnueabihf-debug.tar.gz bc3dd517175118ad79f16b3df0899463b8bb6b651e34d91a6b9d1bb6d9fd4c95 guix-build-339b4a51f6d3/output/arm-linux-gnueabihf/bitcoin-339b4a51f6d3-arm-linux-gnueabihf.tar.gz 5bdc59189f60db33744089f67cee8b0d04a923805fd18a8116ae38e0aa823df0 guix-build-339b4a51f6d3/output/arm64-apple-darwin/SHA256SUMS.part fbdfc4be58e07d3e79f4db01eaa7cbd8918a0d0ce4c4a45ac18faa400c427dad guix-build-339b4a51f6d3/output/arm64-apple-darwin/bitcoin-339b4a51f6d3-arm64-apple-darwin.tar.gz 70834ad1016a82ad262e1c623fb903f3ad5f37b36a2bb5c9add1156ea4992801 guix-build-339b4a51f6d3/output/arm64-apple-darwin/bitcoin-339b4a51f6d3-osx-unsigned.dmg ff90ced5d5639802b93d071fff400ccbfbd6f2aa3b3d8185734e033f1305ba09 guix-build-339b4a51f6d3/output/arm64-apple-darwin/bitcoin-339b4a51f6d3-osx-unsigned.tar.gz 961a42f5f44da48b5aca33cf79cd669469577ffd3bdb9e37a9c6da3076a3adbb guix-build-339b4a51f6d3/output/dist-archive/bitcoin-339b4a51f6d3.tar.gz c8b0736eab4be28ef434320a4a3396464e073e97e72e58dbada0e7fa5653fb31 guix-build-339b4a51f6d3/output/powerpc64-linux-gnu/SHA256SUMS.part 6a24dede89640fdc47ddb4914bea83d8096892fa37d3d38ce6ec8b2c0889f1ad guix-build-339b4a51f6d3/output/powerpc64-linux-gnu/bitcoin-339b4a51f6d3-powerpc64-linux-gnu-debug.tar.gz cf0b31eed04a3dfadae1c6a87ca9ea3bf26a4df584a2d414a16ed8adb1892d18 guix-build-339b4a51f6d3/output/powerpc64-linux-gnu/bitcoin-339b4a51f6d3-powerpc64-linux-gnu.tar.gz ac168c38123d254841b0cae26a8ab57c8e2211e1320b5fabf3643f631eb275fb guix-build-339b4a51f6d3/output/powerpc64le-linux-gnu/SHA256SUMS.part 465d5a1fae7d61a7691f31bb11129f97f180dd2f9cabb3cf6bbc5a4d9f599a06 guix-build-339b4a51f6d3/output/powerpc64le-linux-gnu/bitcoin-339b4a51f6d3-powerpc64le-linux-gnu-debug.tar.gz 0f95b42c50f48aaefd7a1a729fb78d6dd3c36184b8da348bcfbbc42df9c3f770 guix-build-339b4a51f6d3/output/powerpc64le-linux-gnu/bitcoin-339b4a51f6d3-powerpc64le-linux-gnu.tar.gz c16d69577d47c939a39f2246d753c675c25019634c827d277b0d44cc63d48228 guix-build-339b4a51f6d3/output/riscv64-linux-gnu/SHA256SUMS.part 8e84525cbf61a1c5bc6bb7f9e3d11af0a91edee3312f912bf9bd18ec715c5152 guix-build-339b4a51f6d3/output/riscv64-linux-gnu/bitcoin-339b4a51f6d3-riscv64-linux-gnu-debug.tar.gz 8eaa53a56a93b1b5e79a0753cc6af8529068dbc19974ae4c72251222532bbcab guix-build-339b4a51f6d3/output/riscv64-linux-gnu/bitcoin-339b4a51f6d3-riscv64-linux-gnu.tar.gz 9719a025650a2a92a92f4f7f8ef2bd5b3aadfbb454e4a35d6fe1ead4ff43d6bd guix-build-339b4a51f6d3/output/x86_64-apple-darwin/SHA256SUMS.part e07f577fb9d361d6396794413f27ec9a18200fa1654dd22b10971cbb1422cabc guix-build-339b4a51f6d3/output/x86_64-apple-darwin/bitcoin-339b4a51f6d3-osx-unsigned.dmg d057b2c7dcc0076760471350e1e27d933e096d935cd9123131f4baa0c1258a8d guix-build-339b4a51f6d3/output/x86_64-apple-darwin/bitcoin-339b4a51f6d3-osx-unsigned.tar.gz 644de0d0208c71baed03f5a4a5989d33888fa6f712fefe11efa5b5a9ac2b6ee9 guix-build-339b4a51f6d3/output/x86_64-apple-darwin/bitcoin-339b4a51f6d3-osx64.tar.gz cb5397e691931c72a955e944bf1fc0a76cef8f01a267036072fc93019f1ea646 guix-build-339b4a51f6d3/output/x86_64-linux-gnu/SHA256SUMS.part 4c90b73a42bd144ed3b00f05ae6ba9f21e21eae5dd84e44d2c5cc7e3da0dc212 guix-build-339b4a51f6d3/output/x86_64-linux-gnu/bitcoin-339b4a51f6d3-x86_64-linux-gnu-debug.tar.gz b499ac87ed63c4c04cdfa940ca81577f38406daccc1bfeee3cec3e6fb231be74 guix-build-339b4a51f6d3/output/x86_64-linux-gnu/bitcoin-339b4a51f6d3-x86_64-linux-gnu.tar.gz 4b39efa7593232050130cbdd52c2920ed9bff5c902eb3c4ddc27aa8f1d62af5a guix-build-339b4a51f6d3/output/x86_64-w64-mingw32/SHA256SUMS.part 737f85e2cbcb508d1cf913c6fd39434667f5fec8bea8c300aa62beae7585a5c6 guix-build-339b4a51f6d3/output/x86_64-w64-mingw32/bitcoin-339b4a51f6d3-win-unsigned.tar.gz 78a61e1844aa70015ef802c5311bfb4975a0fb011e6d5b6bbbd0a6ff42b61f6c guix-build-339b4a51f6d3/output/x86_64-w64-mingw32/bitcoin-339b4a51f6d3-win64-debug.zip 5fdd72f089ee7a0fc689971fb9e16a1bf26c63bd90333ab753b4dbf0593ee393 guix-build-339b4a51f6d3/output/x86_64-w64-mingw32/bitcoin-339b4a51f6d3-win64-setup-unsigned.exe 6cbc124adaed8b0165694853ca2995400ef161bfdf2bcbfda082572f5b50de40 guix-build-339b4a51f6d3/output/x86_64-w64-mingw32/bitcoin-339b4a51f6d3-win64.zip -
fanquake commented at 10:47 AM on March 11, 2022: member
I don't think there's a reason in itself to remove unused headers from depends,
I think keeping our depends pruned to only contain things we actually need to build Bitcoin Core is a worthwhile endeavor; especially now that the amount of (bare minimum) dependency code has been decreasing further. I agree that even as a lint to prevent re-inclusion this is also worthwhile.
- fanquake merged this on Mar 12, 2022
- fanquake closed this on Mar 12, 2022
- fanquake deleted the branch on Mar 12, 2022
-
DrahtBot commented at 11:15 AM on March 13, 2022: member
<!--9cd9c72976c961c55c7acef8f6ba82cd-->
Guix builds
- DrahtBot removed the label DrahtBot Guix build requested on Mar 13, 2022
- DrahtBot locked this on Mar 13, 2023
Labels