[POC] build: Use "build ID" instead of "debug link" to specify debug info #24556

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:220314-build-id changing 2 files +2 −1

hebasto commented at 10:28 AM on March 14, 2022: member

This PR makes GUIX built executables, except for the GUI (TBD), architecture agnostic.

Close bitcoin/bitcoin#21194 ?

build: Use "build ID" instead of "debug link" to specify debug info

This change makes GUIX built executables, except for the GUI,
architecture agnostic.

25756bc094

fanquake added the label Build system on Mar 14, 2022
in configure.ac:973 in 25756bc094
```
 969 | @@ -970,6 +970,8 @@ if test "$TARGET_OS" = "darwin"; then
 970 |    AX_CHECK_LINK_FLAG([-Wl,-bind_at_load], [HARDENED_LDFLAGS="$HARDENED_LDFLAGS -Wl,-bind_at_load"], [], [$LDFLAG_WERROR])
 971 |  fi
 972 |  
 973 | +AX_CHECK_LINK_FLAG([-Wl,--build-id=0xfedcba9876543210], [LDFLAGS="$LDFLAGS -Wl,--build-id=0xfedcba9876543210"], [AC_MSG_ERROR([linker did not accept --build-id flag])], [$LDFLAG_WERROR])
```
hebasto commented at 10:34 AM on March 14, 2022:

Of course, it should use git commit hash or some another tag, but not be hardcoded :)

fanquake commented at 10:42 AM on March 14, 2022:

Why is this an error if it's not accepted? We can't use it that way, because not all of our linkers support this option.

hebasto commented at 10:48 AM on March 14, 2022:

Why is this an error if it's not accepted?

Mostly, to ensure GUIX builds are successful for all hosts.

We can't use it that way, because not all of our linkers support this option.

Agree. Will be happy if a more suitable approach will be suggested.

dongcarl commented at 7:55 PM on March 14, 2022:

Not opposed to specifying this, but perhaps we'd do it at the contrib/guix/libexec/build.sh level as a HOST_LDFLAGS
hebasto commented at 10:25 AM on March 16, 2022: member

This PR makes GUIX built executables, except for the GUI (TBD), architecture agnostic.

Closing this in favor of #24569, as the latter achieves cross-arch reproducibility for Qt binaries as well.
hebasto closed this on Mar 16, 2022
hebasto deleted the branch on Mar 24, 2022
DrahtBot locked this on Mar 24, 2023

Contributors

Labels