Remove unused feebumper code #24562

1. 
   MarcoFalke commented at 3:06 pm on March 14, 2022: member

   This was accidentally added in commit 0ea47ba7b38cc4b2b9175347cb5cd48fcd08da48. Presumably due to a copy-paste error, as CreateTransaction already takes care of the rbf-signal.
2. Remove unused feebumper code fae5d06eed
3. MarcoFalke added the label Refactoring on Mar 14, 2022
4. MarcoFalke added the label Wallet on Mar 14, 2022
5. 
   MarcoFalke commented at 3:30 pm on March 14, 2022: member

   Can be tested in the GUI Console with:

   0bumpfee $txid '{"replaceable": $bool_val}'
   

6. promag approved
7. 
   promag commented at 6:32 pm on March 15, 2022: member

   Code review ACK fae5d06eed7f766926b1dc6d2320a68c8e4375bc

   Indeed, input sequence is set in CreateTransactionInternal:

   https://github.com/bitcoin/bitcoin/blob/7b83c7d609ba61c5726650208b53111eb11a4b0e/src/wallet/spend.cpp#L805-L813

8. 
   DrahtBot commented at 9:45 pm on March 22, 2022: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #20640 (wallet, refactor: return out-params of CreateTransaction() as optional struct by theStack)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

9. 
   achow101 commented at 5:37 pm on March 23, 2022: member

   ACK fae5d06eed7f766926b1dc6d2320a68c8e4375bc
10. 
    fanquake commented at 8:12 pm on March 23, 2022: member

    cc @instagibbs
11. fanquake merged this on Mar 23, 2022
12. fanquake closed this on Mar 23, 2022

    ---

13. sidhujag referenced this in commit ddbd96a75d on Mar 24, 2022
14. sidhujag referenced this in commit 8c83ce18d2 on Mar 24, 2022
15. MarcoFalke deleted the branch on Mar 24, 2022
16. DrahtBot locked this on Mar 24, 2023

Contributors
MarcoFalke promag DrahtBot achow101 fanquake

Labels
Refactoring Wallet