doc: update release-process.md #24594

pull gruve-p wants to merge 1 commits into bitcoin:master from gruve-p:patch-1 changing 1 files +24 −25
  1. gruve-p commented at 9:27 PM on March 16, 2022: contributor

    No description provided.

  2. fanquake added the label Docs on Mar 16, 2022
  3. jonatack commented at 10:15 PM on March 16, 2022: member

    Changes seem correct from referencing contrib/guix/README.md but I don't have deep context here.

    ACK ba7d150cf49dcdfac7080c6adbf419e7b4b9b016

  4. in doc/release-process.md:186 in ba7d150cf4 outdated 
     182 | @@ -183,9 +183,9 @@ Non-codesigners: wait for Windows/macOS detached signatures:
 183 |  - Once the Windows/macOS builds each have 3 matching signatures, they will be signed with their respective release keys.
 184 |  - Detached signatures will then be committed to the [bitcoin-detached-sigs](https://github.com/bitcoin-core/bitcoin-detached-sigs) repository, which can be combined with the unsigned apps to create signed binaries.
 185 |  
 186 | -Create (and optionally verify) the codesigned outputs:
 187 | +Create (and optionally verify) the codesigned build outputs:
    hebasto commented at 8:05 AM on March 17, 2022:

    As "optionally verify" is mentioned here, I would suggest to add the https://github.com/bitcoin/bitcoin/blob/ba7d150cf49dcdfac7080c6adbf419e7b4b9b016/contrib/guix/README.md#verifying-build-output-attestations link, or do not mention "optionally verify" at all.

    gruve-p commented at 1:24 PM on March 17, 2022:

    Done

  5. gruve-p force-pushed on Mar 17, 2022
  6. its0x08 approved
  7. gruve-p requested review from hebasto on Mar 20, 2022
  8. gruve-p requested review from jonatack on Mar 20, 2022
  9. in doc/release-process.md:190 in 0f12f9ddb5 outdated 
     187 | +Create the codesigned build outputs:
 188 |  
 189 | -- [Codesigning](/contrib/guix/README.md#codesigning)
 190 | +- [Codesigning build outputs](/contrib/guix/README.md#codesigning-build-outputs)
 191 | +
 192 | +Verify other builders' signatures to your own (Optional):
    hebasto commented at 1:29 PM on March 20, 2022:

    Is there any particular reason to capitalize "Optional"?

    gruve-p commented at 6:17 PM on March 20, 2022:

    fixed

  10. in doc/release-process.md:192 in 0f12f9ddb5 outdated 
     189 | -- [Codesigning](/contrib/guix/README.md#codesigning)
 190 | +- [Codesigning build outputs](/contrib/guix/README.md#codesigning-build-outputs)
 191 | +
 192 | +Verify other builders' signatures to your own (Optional):
 193 | +
 194 | +- Add other builders keys to your gpg keyring, and/or refresh keys: See `../bitcoin/contrib/builder-keys/README.md`.
    hebasto commented at 1:30 PM on March 20, 2022:

    Could ../bitcoin/contrib/builder-keys/README.md be a link?

    gruve-p commented at 6:17 PM on March 20, 2022:

    done

  11. hebasto commented at 1:30 PM on March 20, 2022: member

    Approach ACK 0f12f9ddb552488f6911d9c58a4e8ee3ec436ebc.

  12. gruve-p renamed this:
    doc: update release-process.md with correct codesigning url
    doc: update release-process.md
    on Mar 20, 2022
  13. gruve-p force-pushed on Mar 20, 2022
  14. gruve-p marked this as a draft on Mar 20, 2022
  15. gruve-p force-pushed on Mar 20, 2022
  16. gruve-p marked this as ready for review on Mar 20, 2022
  17. gruve-p requested review from hebasto on Mar 20, 2022
  18. gruve-p commented at 6:35 PM on March 20, 2022: contributor

    Also requesting review from @fanquake and @achow101 as codesigners. I think I went over my head with this PR (from changing 1 small URL to overhauling the whole doc). Happy to revert things if needed.

  19. in doc/release-process.md:142 in f1ba48ae36 outdated 
     141 | -- Only one person handles codesigning. Everyone else should skip to the next step.
 142 | -- Only once the Windows/macOS builds each have 3 matching signatures may they be signed with their respective release keys.
 143 | +## Codesigning
 144 |  
 145 | -Codesigner only: Sign the macOS binary:
 146 | +### macOS codesigner only (currently [fanquake](https://github.com/fanquake)): Create detached macOS signatures
    fanquake commented at 12:02 PM on March 21, 2022:

    Not sure you need to add links to me or @achow101 here. If anyone wants to know who the codesigners are, they can look at the detached-sigs repository.

    gruve-p commented at 4:33 PM on March 21, 2022:

    Not all users that look at this repository know the existence of the detached-sigs repository. I think it should be transparant who the current codesigners are without looking at other repositories. It would be even better if the codesigners are rotated after every release (candidate).

    fanquake commented at 4:40 PM on March 21, 2022:

    Not all users that look at this repository know the existence of the detached-sigs repository.

    Then you could link to it from this document.

    It would be even better if the codesigners are rotated after every release (candidate).

    We aren't going to change code signers for every release candidate.

    gruve-p commented at 4:43 PM on March 21, 2022:

    removed links

  20. in doc/release-process.md:145 in f1ba48ae36 outdated 
     144 |  
 145 | -Codesigner only: Sign the macOS binary:
 146 | +### macOS codesigner only (currently [fanquake](https://github.com/fanquake)): Create detached macOS signatures
 147 |  
 148 | +    cd signapple && git pull (if new macOS codesigner has been appointed then: git clone https://github.com/achow101/signapple && cd applesign)
 149 | +    python3 setup.py install (or `pip install -e .` or `poetry install`)
    fanquake commented at 12:41 PM on March 21, 2022:

    You don't need to list the 3 different ways you could install signapple. Anyone who needs to install it can look at the README for the most up to date instructions. Could probably even just replace these two lines with something like: Assuming [signapple](https://github.com/achow101/signapple/) is installed.

    gruve-p commented at 4:30 PM on March 21, 2022:

    Done

  21. in doc/release-process.md:145 in f1ba48ae36 outdated 
     145 | -Codesigner only: Sign the macOS binary:
 146 | +### macOS codesigner only (currently [fanquake](https://github.com/fanquake)): Create detached macOS signatures
 147 |  
 148 | +    cd signapple && git pull (if new macOS codesigner has been appointed then: git clone https://github.com/achow101/signapple && cd applesign)
 149 | +    python3 setup.py install (or `pip install -e .` or `poetry install`)
 150 | +    (If new macOS codesigner has been appointed then: To use the code signing certificate with signapple, the Developer ID Application Certificate must be exported. The Developer ID Application Certificate should be accessible through the Keychain Access app.
    fanquake commented at 1:51 PM on March 21, 2022:

    Not sure about these sentences in the (). The signing doesn't have to happen on macOS, and I don't think we need to maintain instructions about how to export certs out of macOS utilities. If someone needs to do that, they can lookup the instructions at the time.

    gruve-p commented at 4:28 PM on March 21, 2022:

    Are you sure it does not have to happen on macOS? If so, why does it say transfer bitcoin-osx-unsigned.tar.gz to macOS for signing? It can just be kept on the guix host? If so, transfer bitcoin-osx-unsigned.tar.gz to macOS for signing should be removed.

    fanquake commented at 4:42 PM on March 21, 2022:

    Performing signing requires signapple and the signing key. It doesn't require macOS. Even if it did I still wouldn't think we need instructions on how to export certificates out of macOS applications in this readme.

    gruve-p commented at 4:45 PM on March 21, 2022:

    fixed

  22. gruve-p force-pushed on Mar 21, 2022
  23. gruve-p force-pushed on Mar 21, 2022
  24. gruve-p requested review from fanquake on Mar 21, 2022
  25. in doc/release-process.md:144 in 17b13201cf outdated 
     144 |  
 145 | -Codesigner only: Sign the macOS binary:
 146 | +### macOS codesigner only: Create detached macOS signatures
 147 |  
 148 | -    transfer bitcoin-osx-unsigned.tar.gz to macOS for signing
 149 | +    Assuming [signapple](https://github.com/achow101/signapple/) is installed and up to date with master branch.
    fanquake commented at 7:53 AM on March 25, 2022:

    This line needs to be moved out of the bash block. Otherwise the link doesn't render: link

    gruve-p commented at 3:39 PM on March 25, 2022:

    done

  26. fanquake commented at 7:54 AM on March 25, 2022: member

    Looks fine now (except for the last comment that needs). @achow101 want to sanity-check as well?

  27. doc: update release-process.md ac45a43d89
  28. gruve-p force-pushed on Mar 25, 2022
  29. gruve-p requested review from fanquake on Mar 25, 2022
  30. achow101 commented at 9:42 PM on April 1, 2022: member

    ACK ac45a43d894a50ada785c658c261446d6b881224

  31. fanquake merged this on Apr 2, 2022
  32. fanquake closed this on Apr 2, 2022
  33. gruve-p deleted the branch on Apr 2, 2022
  34. Pragmatic2021 commented at 12:46 PM on April 2, 2022: none

    Nothing to add or change. Does this go to the Bitcoin Core Wallet ?

  35. fanquake deleted a comment on Apr 2, 2022
  36. sidhujag referenced this in commit 792984d223 on Apr 3, 2022
  37. DrahtBot locked this on Apr 2, 2023
Contributors
gruve-pjonatackhebastoits0x08fanquakeachow101Pragmatic2021


fanquakejonatackhebasto

Labels
Docs
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 18:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me