Bitcoin's cleanner #246

Hi guys, first let's say that I really appreciate the job you're doing. So thanks to all of you. And kindly consider the little updates that I am requesting. It's just a whitespace cleaning and some indentations added in the code. Regards,

Hm, not sure why we need to change our indentation format. It is one of the most common types of indentation/code format (though possibly some different bracket positioning is more common).

Though some of the removal of random spaces at the end of lines and cleaning up number of spaces at various points could be done.

I thought that no standard has been used regarding the indentation of code, so you're right we don't have to take this commit in account even if I like a bit more this style in my Emacs ;)

Removing spaces and cleaning up is fine, but the project has well-defined code style rules, which I don't think should be changed without discussion.

you are absolutely right.

the indentation and code style was declared and we are all already adapting to it, why change it?

i'm also disagreeing with the "whitespace cleanup": while that is an easy trick using the emacs extension, it does provoke unnecessary conflicts when merging master into branches.

ultimately i don't see any good reason why to pull this req.

jaromil, are there any rules regarding the indentation and code style defined by the community of developer around the project ? If yes can any one give me some directives to respect these rules in the future ?

Thanks.

There should be in docs/coding.txt

Thanks.

i see one good thing in this operation, but then it should split from all the rest and be proposed as a standalone pull request: in addition to the changes you mentioned, you have also added #ifndef / #define to headers, a common practice to avoid multiple inclusion and redeclarations. as that would be a good step towards getting rid of the headers.h insanity, it'd be good to have it IMHO. but then again, as a separate pull request plz.

I will separate the change you mentioned from the rest of the pull. If there is anything else to keep, go ahead ;)

we have a metric ton of pending patches, and unfortunately this pull request is very low priority compared to other changes which change a lot of bitcoin code. whitespace diffs tend to require merging and rebasing downstream for very little value.

So this pull request is, and will continue to become, out of date. Other changes should definitely go into separate pull requests.