macdeploy: remove unused detached-sig-apply.sh #24603

1. 
   fanquake commented at 12:41 pm on March 17, 2022: member

   Signature application is now done with signapple.

   https://github.com/bitcoin/bitcoin/blob/8435d7f11a89bb3f93306646f62cc2179693e072/contrib/guix/libexec/codesign.sh#L84-L85

2. macdeploy: remove unused detached-sig-apply

   Signature application is now done with signapple.

   979271a5d9
3. fanquake added the label macOS on Mar 17, 2022
4. fanquake added the label Build system on Mar 17, 2022
5. 
   laanwj commented at 1:17 pm on March 17, 2022: member

   ACK 979271a5d9ff887cb2efb199feaf9602c9b2086d Checked that the script is unreferenced.
6. 
   gruve-p commented at 1:27 pm on March 17, 2022: contributor

   ACK https://github.com/bitcoin/bitcoin/pull/24603/commits/979271a5d9ff887cb2efb199feaf9602c9b2086d
7. 
   achow101 commented at 3:49 pm on March 17, 2022: member

   ACK 979271a5d9ff887cb2efb199feaf9602c9b2086d
8. 
   DrahtBot commented at 5:46 pm on March 17, 2022: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #24031 (build: don’t compress macOS DMG by fanquake)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

9. hebasto approved
10. 
    hebasto commented at 6:01 pm on March 17, 2022: member

    ACK 979271a5d9ff887cb2efb199feaf9602c9b2086d, I have reviewed the code and it looks OK, I agree it can be merged.

    Call sites of detached-sig-apply.sh were removed in ab9c34237ab7b056394e0bd1f7cb131ffd95754c (bitcoin/bitcoin#22418).

11. fanquake merged this on Mar 18, 2022
12. fanquake closed this on Mar 18, 2022

    ---

13. fanquake deleted the branch on Mar 18, 2022
14. sidhujag referenced this in commit ad44eb64a0 on Mar 18, 2022
15. DrahtBot locked this on Mar 18, 2023

Contributors
fanquake laanwj gruve-p achow101 DrahtBot hebasto

Labels
macOS Build system