Introduced in #23998.
build: fix copypasta in OpenBSD C{XX} flags #24604
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:openbsd_copy_pasta changing 1 files +5 −5-
fanquake commented at 1:13 PM on March 17, 2022: member
-
build: fix copypasta in OpenBSD C{XX} flags 28f17c1a6d
- fanquake added the label Build system on Mar 17, 2022
-
laanwj commented at 1:15 PM on March 17, 2022: member
Concept ACK. It's kind of curious that it worked fine without this, so I'm not sure how to test.
- hebasto approved
-
hebasto commented at 8:16 AM on March 25, 2022: member
ACK 28f17c1a6de7b50482d8f55fe03698126862e8eb, I have reviewed the code and it looks OK, not tested on OpenBSD though.
It's kind of curious that it worked fine without this, so I'm not sure how to test.
I think changes in
CFLAGSandCXXFLAGSare not so critical at all. -
fanquake commented at 8:28 AM on March 25, 2022: member
Concept ACK. It's kind of curious that it worked fine without this, so I'm not sure how to test.
The missing
-pipeisn't a big issue as it may only provide some speedup:-pipe Use pipes rather than temporary files for communication between the various stages of compilation. This fails to work on some systems where the assembler is unable to read from a pipe; but the GNU assembler has no trouble.
The missing
-O2was likely compensated for by autotools automatically using-O2when building just about all packages. - fanquake merged this on Mar 25, 2022
- fanquake closed this on Mar 25, 2022
- fanquake deleted the branch on Mar 25, 2022
- sidhujag referenced this in commit 7449f8cabb on Apr 2, 2022
- DrahtBot locked this on Mar 25, 2023
Labels