Bugfix: RPC/blockchain: Correct description of getblockchaininfo’s pruneheight result #24640

pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:fix_rpcdoc_gbci_pruneheight_desc changing 1 files +1 −1

luke-jr commented at 1:42 pm on March 22, 2022: member

It is possible that lower blocks are complete due to being stored in the same file as blocks not yet eligible for pruning.

Not really satisfied with this new description, so suggestions for better phasing welcome :)

(Split out of #24629)

Bugfix: RPC/blockchain: Correct description of getblockchaininfo's pruneheight result

It is possible that lower blocks are complete due to being stored in the same file as blocks not yet eligible for pruning.

06822f8654

DrahtBot added the label RPC/REST/ZMQ on Mar 22, 2022
ryanofsky approved
ryanofsky commented at 8:21 pm on April 20, 2022: member

Code review ACK ~~5375051abccc551cdf389edc74c223e4e7f93e7e~~ 06822f86545a0e946fdc266c57955f98d163a8bc. New description seems clearer and more correct than current description. (Current description is generally correct but could be misleading in case of manual pruning).

Not really satisfied with this new description, so suggestions for better phasing welcome :)

I think your description is good, but my suggestion might be “Height of the first unpruned block after the last pruned block”
theStack approved
theStack commented at 8:13 pm on May 13, 2022: member

Code-review ACK 06822f86545a0e946fdc266c57955f98d163a8bc

// EDIT: @ryanofsky: Seems like you ACKed a commit that is not part of this PR?
MarcoFalke commented at 9:00 am on May 16, 2022: member

// EDIT: @ryanofsky: Seems like you ACKed a commit that is not part of this PR?

:rotating_light: :rotating_light: :rotating_light: :rotating_light:
MarcoFalke merged this on May 16, 2022
MarcoFalke closed this on May 16, 2022
ryanofsky commented at 3:35 pm on May 16, 2022: member

rotating_light

Sorry, fixed now. Sometimes I review different PRs in different terminals and paste a hash from the wrong terminal into the github comment. The actual text of my comment was about this PR
sidhujag referenced this in commit 9498eabc5e on May 28, 2022
DrahtBot locked this on Jun 26, 2023

Contributors
luke-jr ryanofsky theStack MarcoFalke

Labels
RPC/REST/ZMQ