refactor: Use clang-tidy syntax for C++ named arguments #24661

1. 
   fanquake commented at 5:06 pm on March 24, 2022: member

   Incorrect named args are source of bugs, like #22979.

   To allow them being checked by clang-tidy, use a format it can understand.

   Picks up #23545, with some additional changes and some feedback addressed.

   With these changes invoking ./autogen.sh && ./configure CC=clang-12 CXX=clang++-12 && make clean && bear make -j9 && ( cd ./src/ && run-clang-tidy-12 -j9 ) no-longer results in named argument errors out of clang-tidy.

   Ultimately I think we should just add clang-tidy-* jobs to the CI and automate things away.

2. fanquake added the label Refactoring on Mar 24, 2022
3. DrahtBot added the label Needs rebase on Mar 24, 2022
4. fanquake referenced this in commit 2f0f056e08 on Mar 25, 2022
5. fanquake force-pushed on Mar 25, 2022
6. DrahtBot removed the label Needs rebase on Mar 25, 2022
7. 
   DrahtBot commented at 5:26 pm on March 27, 2022: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #24595 (deploymentstatus: move g_versionbitscache global to ChainstateManager by ajtowns)
   • #24584 (wallet: avoid mixing different OutputTypes during coin selection by josibake)
   • #22910 (net: Encapsulate asmap in NetGroupManager by jnewbery)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

8. DrahtBot added the label Needs rebase on Mar 28, 2022
9. MarcoFalke referenced this in commit 9d00406dc9 on Mar 28, 2022
10. fanquake force-pushed on Mar 28, 2022
11. fanquake marked this as ready for review on Mar 28, 2022
12. DrahtBot removed the label Needs rebase on Mar 28, 2022
13. fanquake force-pushed on Mar 31, 2022
14. MarcoFalke referenced this in commit 7ab9fc32d6 on Apr 1, 2022
15. DrahtBot added the label Needs rebase on Apr 1, 2022
16. fanquake force-pushed on Apr 1, 2022
17. 
    fanquake commented at 8:51 am on April 1, 2022: member

    Rebased past #24724.
18. 
    MarcoFalke commented at 10:01 am on April 1, 2022: member

    Maybe this can be split up as a non-scripted diff? It should be easier to review the 61 lines changed than to review the scripted diff.
19. DrahtBot removed the label Needs rebase on Apr 1, 2022
20. fanquake force-pushed on Apr 2, 2022
21. 
    fanquake commented at 3:07 pm on April 2, 2022: member

    Maybe this can be split up as a non-scripted diff? It should be easier to review the 61 lines changed than to review the scripted diff.

    Ok. Have split this up and dropped the scripted-diff.

22. sidhujag referenced this in commit 24a5e0f92b on Apr 2, 2022
23. refactor: fix clang-tidy named args usage 37a16ffd70
24. fanquake force-pushed on Apr 4, 2022
25. 
    MarcoFalke commented at 8:06 am on April 4, 2022: member

    cr ACK 37a16ffd7011828a8b6fa175bfc1f03be41bb261
26. MarcoFalke merged this on Apr 4, 2022
27. MarcoFalke closed this on Apr 4, 2022

    ---

28. fanquake deleted the branch on Apr 4, 2022
29. sidhujag referenced this in commit 45aeaf1de9 on Apr 4, 2022
30. DrahtBot locked this on Apr 4, 2023

Contributors
fanquake DrahtBot MarcoFalke

Labels
Refactoring