fanquake
commented at 5:06 pm on March 24, 2022:
member
Incorrect named args are source of bugs, like #22979.
To allow them being checked by clang-tidy, use a format it can understand.
Picks up #23545, with some additional changes and some feedback addressed.
With these changes invoking ./autogen.sh && ./configure CC=clang-12 CXX=clang++-12 && make clean && bear make -j9 && ( cd ./src/ && run-clang-tidy-12 -j9 ) no-longer results in named argument errors out of clang-tidy.
Ultimately I think we should just add clang-tidy-* jobs to the CI and automate things away.
fanquake added the label
Refactoring
on Mar 24, 2022
DrahtBot added the label
Needs rebase
on Mar 24, 2022
fanquake referenced this in commit
2f0f056e08
on Mar 25, 2022
fanquake force-pushed
on Mar 25, 2022
DrahtBot removed the label
Needs rebase
on Mar 25, 2022
DrahtBot
commented at 5:26 pm on March 27, 2022:
member
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Conflicts
Reviewers, this pull request conflicts with the following ones:
#24595 (deploymentstatus: move g_versionbitscache global to ChainstateManager by ajtowns)
#24584 (wallet: avoid mixing different OutputTypes during coin selection by josibake)
#22910 (net: Encapsulate asmap in NetGroupManager by jnewbery)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
DrahtBot added the label
Needs rebase
on Mar 28, 2022
MarcoFalke referenced this in commit
9d00406dc9
on Mar 28, 2022
fanquake force-pushed
on Mar 28, 2022
fanquake marked this as ready for review
on Mar 28, 2022
DrahtBot removed the label
Needs rebase
on Mar 28, 2022
fanquake force-pushed
on Mar 31, 2022
MarcoFalke referenced this in commit
7ab9fc32d6
on Apr 1, 2022
DrahtBot added the label
Needs rebase
on Apr 1, 2022
fanquake force-pushed
on Apr 1, 2022
fanquake
commented at 8:51 am on April 1, 2022:
member
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2024-11-24 06:12 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me