refactor: Use clang-tidy syntax for C++ named arguments #24661

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:rebase_23545 changing 32 files +61 −61
  1. fanquake commented at 5:06 PM on March 24, 2022: member

    Incorrect named args are source of bugs, like #22979.

    To allow them being checked by clang-tidy, use a format it can understand.

    Picks up #23545, with some additional changes and some feedback addressed.

    With these changes invoking ./autogen.sh && ./configure CC=clang-12 CXX=clang++-12 && make clean && bear make -j9 && ( cd ./src/ && run-clang-tidy-12 -j9 ) no-longer results in named argument errors out of clang-tidy.

    Ultimately I think we should just add clang-tidy-* jobs to the CI and automate things away.

  2. fanquake added the label Refactoring on Mar 24, 2022
  3. fanquake cross-referenced this on Mar 24, 2022 from issue scripted-diff: Use clang-tidy syntax for C++ named arguments by MarcoFalke
  4. DrahtBot added the label Needs rebase on Mar 24, 2022
  5. fanquake cross-referenced this on Mar 25, 2022 from issue doc: document clang tidy named args by fanquake
  6. fanquake referenced this in commit 2f0f056e08 on Mar 25, 2022
  7. fanquake force-pushed on Mar 25, 2022
  8. DrahtBot removed the label Needs rebase on Mar 25, 2022
  9. fanquake cross-referenced this on Mar 25, 2022 from issue refactor: fix wallet and related named args by fanquake
  10. DrahtBot cross-referenced this on Mar 27, 2022 from issue refactor: followup of remove -deprecatedrpc=addresses flag by fanquake
  11. DrahtBot commented at 5:26 PM on March 27, 2022: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #24595 (deploymentstatus: move g_versionbitscache global to ChainstateManager by ajtowns)
    • #24584 (wallet: avoid mixing different OutputTypes during coin selection by josibake)
    • #22910 (net: Encapsulate asmap in NetGroupManager by jnewbery)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  12. DrahtBot cross-referenced this on Mar 27, 2022 from issue refactor: Move mempool RPCs to rpc/mempool by MarcoFalke
  13. DrahtBot cross-referenced this on Mar 27, 2022 from issue deploymentstatus: move g_versionbitscache global to ChainstateManager by ajtowns
  14. DrahtBot cross-referenced this on Mar 28, 2022 from issue policy / validation: CPFP fee bumping within packages by glozow
  15. DrahtBot added the label Needs rebase on Mar 28, 2022
  16. MarcoFalke referenced this in commit 9d00406dc9 on Mar 28, 2022
  17. fanquake force-pushed on Mar 28, 2022
  18. fanquake marked this as ready for review on Mar 28, 2022
  19. DrahtBot removed the label Needs rebase on Mar 28, 2022
  20. DrahtBot cross-referenced this on Mar 28, 2022 from issue net: Encapsulate asmap in NetGroupManager by jnewbery
  21. DrahtBot cross-referenced this on Mar 29, 2022 from issue wallet: avoid mixing different `OutputTypes` during coin selection by josibake
  22. DrahtBot cross-referenced this on Mar 31, 2022 from issue rpc: getblock/getrawtransaction/decode*/gettxout fixups by jonatack
  23. fanquake force-pushed on Mar 31, 2022
  24. fanquake cross-referenced this on Mar 31, 2022 from issue test: fix incorrect named args in txpackage tests by fanquake
  25. MarcoFalke referenced this in commit 7ab9fc32d6 on Apr 1, 2022
  26. DrahtBot added the label Needs rebase on Apr 1, 2022
  27. fanquake force-pushed on Apr 1, 2022
  28. fanquake commented at 8:51 AM on April 1, 2022: member

    Rebased past #24724.

  29. MarcoFalke commented at 10:01 AM on April 1, 2022: member

    Maybe this can be split up as a non-scripted diff? It should be easier to review the 61 lines changed than to review the scripted diff.

  30. DrahtBot removed the label Needs rebase on Apr 1, 2022
  31. fanquake force-pushed on Apr 2, 2022
  32. fanquake commented at 3:07 PM on April 2, 2022: member

    Maybe this can be split up as a non-scripted diff? It should be easier to review the 61 lines changed than to review the scripted diff.

    Ok. Have split this up and dropped the scripted-diff.

  33. sidhujag referenced this in commit 24a5e0f92b on Apr 2, 2022
  34. fanquake cross-referenced this on Apr 3, 2022 from issue ci: add lint job to run clang-tidy check for named args by fanquake
  35. refactor: fix clang-tidy named args usage 37a16ffd70
  36. fanquake force-pushed on Apr 4, 2022
  37. MarcoFalke commented at 8:06 AM on April 4, 2022: member

    cr ACK 37a16ffd7011828a8b6fa175bfc1f03be41bb261

  38. MarcoFalke merged this on Apr 4, 2022
  39. MarcoFalke closed this on Apr 4, 2022
  40. fanquake deleted the branch on Apr 4, 2022
  41. sidhujag referenced this in commit 45aeaf1de9 on Apr 4, 2022
  42. bitcoin locked this on Apr 4, 2023
Contributors
fanquakeDrahtBotMarcoFalke
Labels
Refactoring
Linked (view graph)
#22979 doc: Fix walletdisplayaddress RPC doc#23545 scripted-diff: Use clang-tidy syntax for C++ named arguments#24665 doc: document clang tidy named args#24677 refactor: fix wallet and related named args#24724 test: fix incorrect named args in txpackage tests#24747 ci: add lint job to run clang-tidy check for named args
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 05:53 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me