compat: remove strnlen back-compat code #24704

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:remove_strlen_back_compat changing 5 files +0 −28
  1. fanquake commented at 9:24 AM on March 29, 2022: member

    This was needed for mingw (not mingw-w64), and some older versions of macOS, which we no-longer support.

  2. compat: remove strnlen back-compat code
    This was needed for mingw (not mingw-w64), and some older versions of
macOS, which we no-longer support.
    d4ba2b2cbc
  3. fanquake added the label Refactoring on Mar 29, 2022
  4. hebasto commented at 11:59 AM on March 29, 2022: member

    Been introduced in #5340.

  5. hebasto commented at 12:02 PM on March 29, 2022: member

    Concept ACK.

  6. hebasto commented at 3:03 PM on March 29, 2022: member

    Guix builds on arm64:

    # find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
0a920ce1712dbeb9fd3cb150a6a8d5be9661a216d7fdab1c428498f4c634b9e6  guix-build-d4ba2b2cbc3d/output/arm-linux-gnueabihf/SHA256SUMS.part
c2c4ac7e080f4c541605dbaa477b418fba8fc217090f44b99e1987142ed84c1b  guix-build-d4ba2b2cbc3d/output/arm-linux-gnueabihf/bitcoin-d4ba2b2cbc3d-arm-linux-gnueabihf-debug.tar.gz
aac27044f54f34acf6931fda22b4be4f010c1991046668a90945eebf5dec51bd  guix-build-d4ba2b2cbc3d/output/arm-linux-gnueabihf/bitcoin-d4ba2b2cbc3d-arm-linux-gnueabihf.tar.gz
9038bfe2bfeadf80e9047c2cd1b8384d60ad260a92f5075e9f8cc1bddf48a00c  guix-build-d4ba2b2cbc3d/output/arm64-apple-darwin/SHA256SUMS.part
c4872b6bc93227301a8317ce8c119f05aaa5ae8dad0b5f83973cdaf493ea1e95  guix-build-d4ba2b2cbc3d/output/arm64-apple-darwin/bitcoin-d4ba2b2cbc3d-arm64-apple-darwin-unsigned.dmg
e3e25aa8db06bb5c41eaf6a4d8346be220b9dfb0686c1ba09e5605618023c4f5  guix-build-d4ba2b2cbc3d/output/arm64-apple-darwin/bitcoin-d4ba2b2cbc3d-arm64-apple-darwin-unsigned.tar.gz
d3adac4f52fdfff43933cda976b7b98cb3257a8489330c7f698420a852567441  guix-build-d4ba2b2cbc3d/output/arm64-apple-darwin/bitcoin-d4ba2b2cbc3d-arm64-apple-darwin.tar.gz
f5a241816263f72888a4f79953c296dd8e812811eb3731272a394847db6ac761  guix-build-d4ba2b2cbc3d/output/dist-archive/bitcoin-d4ba2b2cbc3d.tar.gz
1b5e437d610f92f5e89a5ad85eb26367e0457116424deaa5d2a78ef4aae56271  guix-build-d4ba2b2cbc3d/output/powerpc64-linux-gnu/SHA256SUMS.part
b3ac7c866a5fe2d96ff64837ac08e115cae75b2651f2b09ea90118b3cb977053  guix-build-d4ba2b2cbc3d/output/powerpc64-linux-gnu/bitcoin-d4ba2b2cbc3d-powerpc64-linux-gnu-debug.tar.gz
8fc1ccab369f9d26fefce7c36da2facf70e77715348c266f5825a05d280620ab  guix-build-d4ba2b2cbc3d/output/powerpc64-linux-gnu/bitcoin-d4ba2b2cbc3d-powerpc64-linux-gnu.tar.gz
2fe1b69ebe92c9106c970482edf28d0e04055519e6da693f6fb3685ceb4aa600  guix-build-d4ba2b2cbc3d/output/powerpc64le-linux-gnu/SHA256SUMS.part
5bbd50aafa77205a5bd876a02cdd91fa7c8ebaaab3220d098e8b3f24d18040e1  guix-build-d4ba2b2cbc3d/output/powerpc64le-linux-gnu/bitcoin-d4ba2b2cbc3d-powerpc64le-linux-gnu-debug.tar.gz
72598fa0c1e9924c45a77e68625832412adca6f2557b8e56cc37aeaa14b0e7a9  guix-build-d4ba2b2cbc3d/output/powerpc64le-linux-gnu/bitcoin-d4ba2b2cbc3d-powerpc64le-linux-gnu.tar.gz
45f7fcfb922f7e4611511a7cb82041c74b22feb61c6f4bf33c3584420df5812d  guix-build-d4ba2b2cbc3d/output/riscv64-linux-gnu/SHA256SUMS.part
eee8bbb3f0f8b08dea5712b8b82b32613b99bca2d86b6ae8a840e89a1556fc66  guix-build-d4ba2b2cbc3d/output/riscv64-linux-gnu/bitcoin-d4ba2b2cbc3d-riscv64-linux-gnu-debug.tar.gz
676cc3b89f16e8418cb2e20cce63589df6698351a962c829c77d5bb854faf8eb  guix-build-d4ba2b2cbc3d/output/riscv64-linux-gnu/bitcoin-d4ba2b2cbc3d-riscv64-linux-gnu.tar.gz
1b8532de0306132d74d30c17d061fa8d1b52bf612c9b5c9034f3e138d93899f9  guix-build-d4ba2b2cbc3d/output/x86_64-apple-darwin/SHA256SUMS.part
d72aaea26c459e9c1d9f23f47163ca829d0579541c6efc0aa9fedcd9636e50ed  guix-build-d4ba2b2cbc3d/output/x86_64-apple-darwin/bitcoin-d4ba2b2cbc3d-x86_64-apple-darwin-unsigned.dmg
711d05bfbae937a3f3b27fa820c86017f6118c21f4edae16d8845721ad464e5f  guix-build-d4ba2b2cbc3d/output/x86_64-apple-darwin/bitcoin-d4ba2b2cbc3d-x86_64-apple-darwin-unsigned.tar.gz
8167c1d512f7e99542bbc6e5889820a165d94f2aa8b6411b01b4f9eda6679537  guix-build-d4ba2b2cbc3d/output/x86_64-apple-darwin/bitcoin-d4ba2b2cbc3d-x86_64-apple-darwin.tar.gz
35cbe8ee9a632f4551cd86dc241a0d2a6bd687ce741fc32344fb9ad945218c1e  guix-build-d4ba2b2cbc3d/output/x86_64-linux-gnu/SHA256SUMS.part
bb0f00187fb21c3441286ed4b474db14723680f0c3b6e47ff89ec8c992a7b31d  guix-build-d4ba2b2cbc3d/output/x86_64-linux-gnu/bitcoin-d4ba2b2cbc3d-x86_64-linux-gnu-debug.tar.gz
d029790e509c45e715d3871724625869f5ae529a64eb337041eb655d1957af8a  guix-build-d4ba2b2cbc3d/output/x86_64-linux-gnu/bitcoin-d4ba2b2cbc3d-x86_64-linux-gnu.tar.gz
ef201039167c0ee057b20710cf0e4d7b723e0c86846a81d06b9886456d3eb3b6  guix-build-d4ba2b2cbc3d/output/x86_64-w64-mingw32/SHA256SUMS.part
9346c3e7e0b15c7c971954fdaa26eabee583fe62b4f818c871fe58be528c3f6c  guix-build-d4ba2b2cbc3d/output/x86_64-w64-mingw32/bitcoin-d4ba2b2cbc3d-win64-debug.zip
36588fbfa9714c24e3672b4439c46cd0735ed4f8140d3c11fd468f5a0e5db4b3  guix-build-d4ba2b2cbc3d/output/x86_64-w64-mingw32/bitcoin-d4ba2b2cbc3d-win64-setup-unsigned.exe
b33f6c98e3715fce44c719946a9de789b07537e72d5168a03e652a41546e7347  guix-build-d4ba2b2cbc3d/output/x86_64-w64-mingw32/bitcoin-d4ba2b2cbc3d-win64-unsigned.tar.gz
8ea085dabb1e6d7f2e7712331e046788ae2ff0487885fc04564453d7637df169  guix-build-d4ba2b2cbc3d/output/x86_64-w64-mingw32/bitcoin-d4ba2b2cbc3d-win64.zip
  7. hebasto commented at 5:56 PM on March 29, 2022: member

    Guix builds on x86_64:

    $ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
f00169c73bd082d51a3505c2bc8d750a34a39003a1fe1c11f1226799b3c8e847  guix-build-d4ba2b2cbc3d/output/aarch64-linux-gnu/SHA256SUMS.part
30d18c251d52147b9fcf9d18118adc07fa54176ba70ce34141572c387aa19c82  guix-build-d4ba2b2cbc3d/output/aarch64-linux-gnu/bitcoin-d4ba2b2cbc3d-aarch64-linux-gnu-debug.tar.gz
9f223dcd7df488291b982276d3a96e7cb331a159fc1e71a3abb4d180795e4301  guix-build-d4ba2b2cbc3d/output/aarch64-linux-gnu/bitcoin-d4ba2b2cbc3d-aarch64-linux-gnu.tar.gz
4bd9dd5bca5a1433360c72bf2acd130843b80f09221c2e3fbc8d43cdc1e94b4e  guix-build-d4ba2b2cbc3d/output/arm-linux-gnueabihf/SHA256SUMS.part
e6e8a9f56e9b736bf6cd6a4fbd7973879e425119686bfba25e63fe7ea449473a  guix-build-d4ba2b2cbc3d/output/arm-linux-gnueabihf/bitcoin-d4ba2b2cbc3d-arm-linux-gnueabihf-debug.tar.gz
78fbe55c4f063d5dd5e4fade1ef6a4860c825d1c048614c76020e08b50f308f8  guix-build-d4ba2b2cbc3d/output/arm-linux-gnueabihf/bitcoin-d4ba2b2cbc3d-arm-linux-gnueabihf.tar.gz
700f893796bdefb26e2a1ff961c944c716df830b32bbc83d7d843e29ac8fd805  guix-build-d4ba2b2cbc3d/output/arm64-apple-darwin/SHA256SUMS.part
a23b862bebef5d0cb935f610ae56b7fc281077397ba7837be99cc1d49624f818  guix-build-d4ba2b2cbc3d/output/arm64-apple-darwin/bitcoin-d4ba2b2cbc3d-arm64-apple-darwin-unsigned.dmg
c6ae239e5c09e27c8ffe9703fe545b0af2c047b4f0911ca6e22f9a19a69a790c  guix-build-d4ba2b2cbc3d/output/arm64-apple-darwin/bitcoin-d4ba2b2cbc3d-arm64-apple-darwin-unsigned.tar.gz
67582741739c50f7caa24d22f70ff67f5269e515413ca52c33b3e727c7502114  guix-build-d4ba2b2cbc3d/output/arm64-apple-darwin/bitcoin-d4ba2b2cbc3d-arm64-apple-darwin.tar.gz
f5a241816263f72888a4f79953c296dd8e812811eb3731272a394847db6ac761  guix-build-d4ba2b2cbc3d/output/dist-archive/bitcoin-d4ba2b2cbc3d.tar.gz
56acaf379726b6c8c41223dd5bd73e9ca2069a631a02e1f68f52d798ec324598  guix-build-d4ba2b2cbc3d/output/powerpc64-linux-gnu/SHA256SUMS.part
6b0e1255d42f2d51cf35b2d0e81867dfbd4688d567c3be3dc4a4802bc6a33048  guix-build-d4ba2b2cbc3d/output/powerpc64-linux-gnu/bitcoin-d4ba2b2cbc3d-powerpc64-linux-gnu-debug.tar.gz
1c0a5754b19349ce75a50d197b63e61cc69d436acfb6f4ac5bd91c56430ad118  guix-build-d4ba2b2cbc3d/output/powerpc64-linux-gnu/bitcoin-d4ba2b2cbc3d-powerpc64-linux-gnu.tar.gz
b3b2c3dd7542e60f7273a86680d9c5a6887548a9e7c7f084b0d0e8fc903a950f  guix-build-d4ba2b2cbc3d/output/powerpc64le-linux-gnu/SHA256SUMS.part
221acf8e0243d8ec02360f4e6b55f4f960f968cc3180f7c0e9abb9a27b80aaae  guix-build-d4ba2b2cbc3d/output/powerpc64le-linux-gnu/bitcoin-d4ba2b2cbc3d-powerpc64le-linux-gnu-debug.tar.gz
be26b07a30bf24db2676eefa481028fc17e2743dcfaa5d902343609596775437  guix-build-d4ba2b2cbc3d/output/powerpc64le-linux-gnu/bitcoin-d4ba2b2cbc3d-powerpc64le-linux-gnu.tar.gz
f431550bec480521eb2a6f13a40987f8bb840eeb3b7dd8efad0ea864a4fb4a03  guix-build-d4ba2b2cbc3d/output/riscv64-linux-gnu/SHA256SUMS.part
1736722324cc545734dca9242cf68d9d137ada4c009404b77af8bf8a4fad39b0  guix-build-d4ba2b2cbc3d/output/riscv64-linux-gnu/bitcoin-d4ba2b2cbc3d-riscv64-linux-gnu-debug.tar.gz
6ab15fd9a1674dbf1ffb8a0f3ec741beddfd4d7e27c28f30339e203850dce061  guix-build-d4ba2b2cbc3d/output/riscv64-linux-gnu/bitcoin-d4ba2b2cbc3d-riscv64-linux-gnu.tar.gz
4d68bc4276a03426ccf942c8ab3b6bba1d05b6e824632d2fc139b877d3a19687  guix-build-d4ba2b2cbc3d/output/x86_64-apple-darwin/SHA256SUMS.part
d72aaea26c459e9c1d9f23f47163ca829d0579541c6efc0aa9fedcd9636e50ed  guix-build-d4ba2b2cbc3d/output/x86_64-apple-darwin/bitcoin-d4ba2b2cbc3d-x86_64-apple-darwin-unsigned.dmg
a87ffb05da670564fe601f37a7e4276334b50fd91ae57da02b86b9ee43bdf747  guix-build-d4ba2b2cbc3d/output/x86_64-apple-darwin/bitcoin-d4ba2b2cbc3d-x86_64-apple-darwin-unsigned.tar.gz
8167c1d512f7e99542bbc6e5889820a165d94f2aa8b6411b01b4f9eda6679537  guix-build-d4ba2b2cbc3d/output/x86_64-apple-darwin/bitcoin-d4ba2b2cbc3d-x86_64-apple-darwin.tar.gz
076e188c5518e1ad5fbc1fd51697fc657b9e130e3c65079daaaf9b6ee7c26eeb  guix-build-d4ba2b2cbc3d/output/x86_64-linux-gnu/SHA256SUMS.part
f7487cc48d4c804e5e780ccae5f677e15359941e1e9eddce6e79009a39ab0a20  guix-build-d4ba2b2cbc3d/output/x86_64-linux-gnu/bitcoin-d4ba2b2cbc3d-x86_64-linux-gnu-debug.tar.gz
46c15196a8633e3b56658a9303bd6cd19af3e3efdb7b2de57b24051ed44a518c  guix-build-d4ba2b2cbc3d/output/x86_64-linux-gnu/bitcoin-d4ba2b2cbc3d-x86_64-linux-gnu.tar.gz
224995e13b06f1f45b4e0aae8c94931c89978c210c186856f3b29feca32597b9  guix-build-d4ba2b2cbc3d/output/x86_64-w64-mingw32/SHA256SUMS.part
4a51c9cf080b0bfad2d5465caf4d29d755af6ab59fd63e595a22e7c3d37788b6  guix-build-d4ba2b2cbc3d/output/x86_64-w64-mingw32/bitcoin-d4ba2b2cbc3d-win64-debug.zip
36588fbfa9714c24e3672b4439c46cd0735ed4f8140d3c11fd468f5a0e5db4b3  guix-build-d4ba2b2cbc3d/output/x86_64-w64-mingw32/bitcoin-d4ba2b2cbc3d-win64-setup-unsigned.exe
b33f6c98e3715fce44c719946a9de789b07537e72d5168a03e652a41546e7347  guix-build-d4ba2b2cbc3d/output/x86_64-w64-mingw32/bitcoin-d4ba2b2cbc3d-win64-unsigned.tar.gz
837e83e0463749663cc500fc691cf761cce56668ba8295879982d73b1cf161d0  guix-build-d4ba2b2cbc3d/output/x86_64-w64-mingw32/bitcoin-d4ba2b2cbc3d-win64.zip
  8. MarcoFalke added the label Build system on Mar 29, 2022
  9. hebasto approved
  10. hebasto commented at 6:10 PM on March 29, 2022: member

    ACK d4ba2b2cbc3d1ef381fbdbae88cb5b18ca53f678

  11. MarcoFalke merged this on Mar 30, 2022
  12. MarcoFalke closed this on Mar 30, 2022
  13. fanquake deleted the branch on Mar 30, 2022
  14. sidhujag referenced this in commit 768f0e48a6 on Apr 3, 2022
  15. DrahtBot locked this on Mar 30, 2023
Contributors
fanquakehebasto
Labels
RefactoringBuild system
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 06:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me