ci: note why bdb is disabled in msan jobs #24705

pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:note_why_bdb_disabled_msan changing 2 files +3 −1

fanquake commented at 10:01 AM on March 29, 2022: member

Closes #24703.

ci: remove explicit --enable-wallet from msan job

This isn't required to enable sqlite wallets, as support is
automatically detected when sqlite is available.

d6c71b0ccf

ci: note why BDB is disabled for MSAN jobs 527eeaf580
fanquake added the label Tests on Mar 29, 2022
fanquake requested review from MarcoFalke on Mar 29, 2022
MarcoFalke commented at 11:27 AM on March 29, 2022: member

https://cirrus-ci.com/task/4579274043686912?logs=ci#L2586
MarcoFalke approved
MarcoFalke merged this on Mar 29, 2022
MarcoFalke closed this on Mar 29, 2022

in ci/test/00_setup_env_native_msan.sh:20 in 527eeaf580

  13 | @@ -14,9 +14,10 @@ export MSAN_AND_LIBCXX_FLAGS="${MSAN_FLAGS} ${LIBCXX_FLAGS}"
  14 |  
  15 |  export CONTAINER_NAME="ci_native_msan"
  16 |  export PACKAGES="clang-9 llvm-9 cmake"
  17 | +# BDB generates false-positives and will be removed in future
  18 |  export DEP_OPTS="NO_BDB=1 NO_QT=1 CC='clang' CXX='clang++' CFLAGS='${MSAN_FLAGS}' CXXFLAGS='${MSAN_AND_LIBCXX_FLAGS}' libevent_cflags='${MSAN_FLAGS}' sqlite_cflags='${MSAN_FLAGS}' zeromq_cxxflags='-std=c++17 ${MSAN_AND_LIBCXX_FLAGS}'"
  19 |  export GOAL="install"
  20 | -export BITCOIN_CONFIG="--enable-wallet --with-sanitizers=memory --with-asm=no --prefix=${DEPENDS_DIR}/x86_64-pc-linux-gnu/ CC=clang CXX=clang++ CFLAGS='${MSAN_FLAGS}' CXXFLAGS='${MSAN_AND_LIBCXX_FLAGS}'"
  21 | +export BITCOIN_CONFIG="--with-sanitizers=memory --with-asm=no --prefix=${DEPENDS_DIR}/x86_64-pc-linux-gnu/ CC=clang CXX=clang++ CFLAGS='${MSAN_FLAGS}' CXXFLAGS='${MSAN_AND_LIBCXX_FLAGS}'"

hebasto commented at 11:33 AM on March 29, 2022:

Sorry for being late...

This isn't required to enable sqlite wallets, as support is automatically detected when sqlite is available.

I think about it as the --enable-wallet actually checks the automatic wallet detection.

fanquake deleted the branch on Mar 29, 2022
sidhujag referenced this in commit cd8e598314 on Apr 3, 2022
DrahtBot locked this on Mar 29, 2023

Contributors

Labels

Linked (view graph)

#24703 fuzz: enable BDB in the MSAN CI jobs