clang-14 defaults to using DWARF-5, which breaks vlagrinds (3.18) ability to parse debug info. Valgrind claims to support DWARF-5 from version 3.18 onwards, but maybe that only works when compiling with GCC.
Explicitly use DWARF-4 for now. Note that from 11.0 GCC also defaults to using DWARF-5.
Also remove a Boost related suppression.
No objection, but it would be good for either clang or valgrind to fix this, so that we can revert the workaround and that devs are able to use clang-14 out of the box.
Looks like there is at least discussion on the Valgrind mailing list [Valgrind-users] does Valgrind-3.19.0.GIT support Clang14 dwarf 5?. I haven't found anything on the LLVM side yet.
I don't know how big of a change it is, but if it's anything like going from DWARF 2 to 3 it's not going to be a trivial change in valgrind. I suspect it's going to take a while to support it.
Could add a comment to mention why this override is needed and what would be the condition to remove it.
Otherwise code review ACK 5691a8f0ec8d0bfc470990dfaed9d230346a116e
14 | @@ -15,5 +15,5 @@ export RUN_FUNCTIONAL_TESTS=false 15 | export RUN_FUZZ_TESTS=true 16 | export FUZZ_TESTS_CONFIG="--valgrind" 17 | export GOAL="install" 18 | -export BITCOIN_CONFIG="--enable-fuzz --with-sanitizers=fuzzer CC=clang CXX=clang++" 19 | +export BITCOIN_CONFIG="--enable-fuzz --with-sanitizers=fuzzer CC=clang CXX=clang++ CXXFLAGS='-fdebug-default-version=4'"
Could leave CXXFLAGS untouched to minimize the effective changes?
# Temporarily pin dwarf 4, until valgrind can understand clang's dwarf 5
export BITCOIN_CONFIG="--enable-fuzz --with-sanitizers=fuzzer CC=clang CXX='clang++ -fdebug-default-version=4'"
Could add a comment to mention why this override is needed and what would be the condition to remove it.
Added.
Could leave CXXFLAGS untouched to minimize the effective changes?
Done. Used -gdwarf-4 to minimize even further.
This actually only seems to work when using CXXFLAGS and the full -fdebug-default-version=4, so I've reverted back to the original change + the comment.
clang-14 defaults to using DWARF-5, which breaks vlagrinds (3.18) ability
to parse debug info. Valgrind claims to support DWARF-5 from version
3.18 onwards, but maybe that only works when building with GCC.
Explicitly use DWARF-4 for now. Note that from 11.0 GCC also defaults to
using DWARF-5.
https://releases.llvm.org/14.0.0/tools/clang/docs/ReleaseNotes.html#dwarf-support-in-clang
https://www.gnu.org/software/gcc/gcc-11/changes.html
https://valgrind.org/docs/manual/dist.news.html
12 | @@ -13,4 +13,5 @@ export USE_VALGRIND=1 13 | export NO_DEPENDS=1 14 | export TEST_RUNNER_EXTRA="--nosandbox --exclude feature_init,rpc_bind,feature_bind_extra" # Excluded for now, see https://github.com/bitcoin/bitcoin/issues/17765#issuecomment-602068547 15 | export GOAL="install" 16 | -export BITCOIN_CONFIG="--enable-zmq --with-incompatible-bdb --with-gui=no CC=clang CXX=clang++" # TODO enable GUI 17 | +# Temporarily pin dwarf 4, until valgrind can understand clang's dwarf 5 18 | +export BITCOIN_CONFIG="--enable-zmq --with-incompatible-bdb --with-gui=no CC=clang CXX=clang++ CXXFLAGS='-fdebug-default-version=4" # TODO enable GUI
export BITCOIN_CONFIG="--enable-zmq --with-incompatible-bdb --with-gui=no CC=clang CXX=clang++ CXXFLAGS='-fdebug-default-version=4'" # TODO enable GUI
😰
review ACK