build: remove faketime unsetting and comments from configure #24738

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:remove_faketime changing 1 files +0 −5
  1. fanquake commented at 1:21 PM on April 1, 2022: member

    We no-longer use faketime (it used to be required in gitian), so as far as I'm aware, there is no need for us to unset FAKETIME or mention it in our build docs.

  2. build: remove faketime unsetting and comments from configure.ac 3d70c05868
  3. fanquake added the label Build system on Apr 1, 2022
  4. fanquake added the label DrahtBot Guix build requested on Apr 1, 2022
  5. laanwj commented at 1:59 PM on April 1, 2022: member

    Code review ACK 3d70c058684727cd036314014ec0a9208d3e9168 Seems kind of a layer violation to interfere with faketime settings in a build script like this. I'm sure it was needed at some point but no more.

  6. prusnak approved
  7. prusnak commented at 6:11 PM on April 1, 2022: contributor

    Approach ACK 3d70c05

    (confirmed rg -i faketime returns only lines removed by this PR)

  8. fanquake commented at 10:00 AM on April 2, 2022: member

    Guix Build (on x86_64):

    1c14747c068bde0264d2e07b5a747f25c93a9db8699963543ce94c253f2a84ba  guix-build-3d70c0586847/output/aarch64-linux-gnu/SHA256SUMS.part
c760bd41c9fc6cd9ac6b7c63c1e95ebbccf7d537f6acb4a0d4261ea3a65f2984  guix-build-3d70c0586847/output/aarch64-linux-gnu/bitcoin-3d70c0586847-aarch64-linux-gnu-debug.tar.gz
ae3b7dd16a7ae991718600e0814aca74ab7a1c88af2cfd77a3492157ad7e403f  guix-build-3d70c0586847/output/aarch64-linux-gnu/bitcoin-3d70c0586847-aarch64-linux-gnu.tar.gz
15815347787ee43c7c0e33eee29d509ef6ccc43946fe78740006c9d6eeb63dee  guix-build-3d70c0586847/output/arm-linux-gnueabihf/SHA256SUMS.part
85983417d76772802168444f5b5176b5ab18fbe570a1dd2a94d332ce1c389fe4  guix-build-3d70c0586847/output/arm-linux-gnueabihf/bitcoin-3d70c0586847-arm-linux-gnueabihf-debug.tar.gz
74c4b82d02cff51c7b3e0127b74414ffdc81e4e9332c2d6546d8b86343eccd82  guix-build-3d70c0586847/output/arm-linux-gnueabihf/bitcoin-3d70c0586847-arm-linux-gnueabihf.tar.gz
76dcdf609abba1369b3bcf9c30847f51baaa99875e8d668623f34456a8c8442b  guix-build-3d70c0586847/output/arm64-apple-darwin/SHA256SUMS.part
1773793302db2c067d6279580223ce19e94f51cbf64c1df60c8ae971ce30ff16  guix-build-3d70c0586847/output/arm64-apple-darwin/bitcoin-3d70c0586847-arm64-apple-darwin-unsigned.dmg
e1d32c27726ab1199e3f0e2b2b3e1274b125e586646bd5a3b7077dd04bafd658  guix-build-3d70c0586847/output/arm64-apple-darwin/bitcoin-3d70c0586847-arm64-apple-darwin-unsigned.tar.gz
c53efed48c7923d01df9ed7fda9713615171b3b8d0916e911737c55ec0052455  guix-build-3d70c0586847/output/arm64-apple-darwin/bitcoin-3d70c0586847-arm64-apple-darwin.tar.gz
d63d4c30a0fdec93d9540dc4d543107a04f48190dc4ea6920dd47067d27d7a98  guix-build-3d70c0586847/output/dist-archive/bitcoin-3d70c0586847.tar.gz
002555fcdc982485c9e1f91e4debf807f46d178f8a4feedc8a2ec892195ce461  guix-build-3d70c0586847/output/powerpc64-linux-gnu/SHA256SUMS.part
d4a8d27e9c57e501d50a42dba3e28f5a500916a63390830833f610380f2fc663  guix-build-3d70c0586847/output/powerpc64-linux-gnu/bitcoin-3d70c0586847-powerpc64-linux-gnu-debug.tar.gz
687135a1f2df5acc09e25a6058f060205481f078bea75117feac4993c23cdce4  guix-build-3d70c0586847/output/powerpc64-linux-gnu/bitcoin-3d70c0586847-powerpc64-linux-gnu.tar.gz
e5c7d12ed4421f0a245d1137707c12615134a2429e11b87e7bb0ebf12a2bda09  guix-build-3d70c0586847/output/powerpc64le-linux-gnu/SHA256SUMS.part
be7eb24a8e003eb9374eeef277e8a8371fca3bbf8bb80af1d78b91d9cd33be44  guix-build-3d70c0586847/output/powerpc64le-linux-gnu/bitcoin-3d70c0586847-powerpc64le-linux-gnu-debug.tar.gz
cf30a0c8764dbc82e9a8bc4222457b276f7deb025f508cc92f02a96b31d7c91f  guix-build-3d70c0586847/output/powerpc64le-linux-gnu/bitcoin-3d70c0586847-powerpc64le-linux-gnu.tar.gz
b26f4b6e6076a00063fa5d40cb38ee3ac80ce119354025839bf8265b1e66008e  guix-build-3d70c0586847/output/riscv64-linux-gnu/SHA256SUMS.part
d0b6564c8bcc600e2998e8ca178eda2115524eb4fe476631107d40084ee4a735  guix-build-3d70c0586847/output/riscv64-linux-gnu/bitcoin-3d70c0586847-riscv64-linux-gnu-debug.tar.gz
34cdf7c9572eb1284624e90c37e18adf15454a3eb909ee41720d0886b55b9f12  guix-build-3d70c0586847/output/riscv64-linux-gnu/bitcoin-3d70c0586847-riscv64-linux-gnu.tar.gz
e40b4c19eccc249832614fff8d0de8bfb5b310395cf0572599803477aa5d2b3b  guix-build-3d70c0586847/output/x86_64-apple-darwin/SHA256SUMS.part
347a08df3a7dd52c45201f8ca833b5be71eff53c22349a2ac1963fc0808c1a1b  guix-build-3d70c0586847/output/x86_64-apple-darwin/bitcoin-3d70c0586847-x86_64-apple-darwin-unsigned.dmg
5797c45128ea02fc50ac409e69653b699587584174d898ffff03303836f09780  guix-build-3d70c0586847/output/x86_64-apple-darwin/bitcoin-3d70c0586847-x86_64-apple-darwin-unsigned.tar.gz
36020d61af2971f68e5b3f9c85ad5dc6a3e65f26dfdd87aafbf7b71de73ba267  guix-build-3d70c0586847/output/x86_64-apple-darwin/bitcoin-3d70c0586847-x86_64-apple-darwin.tar.gz
7e200f1d66ba20f5d79084aa886a918d7d797c41d311eeed3972e64e0d2d0b9b  guix-build-3d70c0586847/output/x86_64-linux-gnu/SHA256SUMS.part
48a7b2d3b7c6b5aa2ffb44687708b88c92e023a2941536a877e5da1dfdb99495  guix-build-3d70c0586847/output/x86_64-linux-gnu/bitcoin-3d70c0586847-x86_64-linux-gnu-debug.tar.gz
4e568c00d8df31ef9c2dab293fa462379bdadc37589e0fb953e36987ce1665cb  guix-build-3d70c0586847/output/x86_64-linux-gnu/bitcoin-3d70c0586847-x86_64-linux-gnu.tar.gz
9734757666cafdd83a7d86cb5ef7b8ce21060620cf544f2fd6b72c73b738683d  guix-build-3d70c0586847/output/x86_64-w64-mingw32/SHA256SUMS.part
13b5d2506a7f9fa8efa861bce71d9fdefa7bd241a808b9a074a46c03fa5e7a5a  guix-build-3d70c0586847/output/x86_64-w64-mingw32/bitcoin-3d70c0586847-win64-debug.zip
b0a36d732983c4ee9302be8d795f7217ba64d95cc53b9cb987602a1189b0cd7b  guix-build-3d70c0586847/output/x86_64-w64-mingw32/bitcoin-3d70c0586847-win64-setup-unsigned.exe
6b3f713c8799f7bc26ede39808f98876d512d0218b49d343a353629d4bb7ef39  guix-build-3d70c0586847/output/x86_64-w64-mingw32/bitcoin-3d70c0586847-win64-unsigned.tar.gz
b1059a8571fd68a3003295609dfcc6bc4b6d7cf2f1a39d646c92a0187c14752c  guix-build-3d70c0586847/output/x86_64-w64-mingw32/bitcoin-3d70c0586847-win64.zip
  9. hebasto commented at 3:30 PM on April 2, 2022: member

    Guix builds on x86_64:

    $ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
1c14747c068bde0264d2e07b5a747f25c93a9db8699963543ce94c253f2a84ba  guix-build-3d70c0586847/output/aarch64-linux-gnu/SHA256SUMS.part
c760bd41c9fc6cd9ac6b7c63c1e95ebbccf7d537f6acb4a0d4261ea3a65f2984  guix-build-3d70c0586847/output/aarch64-linux-gnu/bitcoin-3d70c0586847-aarch64-linux-gnu-debug.tar.gz
ae3b7dd16a7ae991718600e0814aca74ab7a1c88af2cfd77a3492157ad7e403f  guix-build-3d70c0586847/output/aarch64-linux-gnu/bitcoin-3d70c0586847-aarch64-linux-gnu.tar.gz
15815347787ee43c7c0e33eee29d509ef6ccc43946fe78740006c9d6eeb63dee  guix-build-3d70c0586847/output/arm-linux-gnueabihf/SHA256SUMS.part
85983417d76772802168444f5b5176b5ab18fbe570a1dd2a94d332ce1c389fe4  guix-build-3d70c0586847/output/arm-linux-gnueabihf/bitcoin-3d70c0586847-arm-linux-gnueabihf-debug.tar.gz
74c4b82d02cff51c7b3e0127b74414ffdc81e4e9332c2d6546d8b86343eccd82  guix-build-3d70c0586847/output/arm-linux-gnueabihf/bitcoin-3d70c0586847-arm-linux-gnueabihf.tar.gz
76dcdf609abba1369b3bcf9c30847f51baaa99875e8d668623f34456a8c8442b  guix-build-3d70c0586847/output/arm64-apple-darwin/SHA256SUMS.part
1773793302db2c067d6279580223ce19e94f51cbf64c1df60c8ae971ce30ff16  guix-build-3d70c0586847/output/arm64-apple-darwin/bitcoin-3d70c0586847-arm64-apple-darwin-unsigned.dmg
e1d32c27726ab1199e3f0e2b2b3e1274b125e586646bd5a3b7077dd04bafd658  guix-build-3d70c0586847/output/arm64-apple-darwin/bitcoin-3d70c0586847-arm64-apple-darwin-unsigned.tar.gz
c53efed48c7923d01df9ed7fda9713615171b3b8d0916e911737c55ec0052455  guix-build-3d70c0586847/output/arm64-apple-darwin/bitcoin-3d70c0586847-arm64-apple-darwin.tar.gz
d63d4c30a0fdec93d9540dc4d543107a04f48190dc4ea6920dd47067d27d7a98  guix-build-3d70c0586847/output/dist-archive/bitcoin-3d70c0586847.tar.gz
002555fcdc982485c9e1f91e4debf807f46d178f8a4feedc8a2ec892195ce461  guix-build-3d70c0586847/output/powerpc64-linux-gnu/SHA256SUMS.part
d4a8d27e9c57e501d50a42dba3e28f5a500916a63390830833f610380f2fc663  guix-build-3d70c0586847/output/powerpc64-linux-gnu/bitcoin-3d70c0586847-powerpc64-linux-gnu-debug.tar.gz
687135a1f2df5acc09e25a6058f060205481f078bea75117feac4993c23cdce4  guix-build-3d70c0586847/output/powerpc64-linux-gnu/bitcoin-3d70c0586847-powerpc64-linux-gnu.tar.gz
e5c7d12ed4421f0a245d1137707c12615134a2429e11b87e7bb0ebf12a2bda09  guix-build-3d70c0586847/output/powerpc64le-linux-gnu/SHA256SUMS.part
be7eb24a8e003eb9374eeef277e8a8371fca3bbf8bb80af1d78b91d9cd33be44  guix-build-3d70c0586847/output/powerpc64le-linux-gnu/bitcoin-3d70c0586847-powerpc64le-linux-gnu-debug.tar.gz
cf30a0c8764dbc82e9a8bc4222457b276f7deb025f508cc92f02a96b31d7c91f  guix-build-3d70c0586847/output/powerpc64le-linux-gnu/bitcoin-3d70c0586847-powerpc64le-linux-gnu.tar.gz
b26f4b6e6076a00063fa5d40cb38ee3ac80ce119354025839bf8265b1e66008e  guix-build-3d70c0586847/output/riscv64-linux-gnu/SHA256SUMS.part
d0b6564c8bcc600e2998e8ca178eda2115524eb4fe476631107d40084ee4a735  guix-build-3d70c0586847/output/riscv64-linux-gnu/bitcoin-3d70c0586847-riscv64-linux-gnu-debug.tar.gz
34cdf7c9572eb1284624e90c37e18adf15454a3eb909ee41720d0886b55b9f12  guix-build-3d70c0586847/output/riscv64-linux-gnu/bitcoin-3d70c0586847-riscv64-linux-gnu.tar.gz
e40b4c19eccc249832614fff8d0de8bfb5b310395cf0572599803477aa5d2b3b  guix-build-3d70c0586847/output/x86_64-apple-darwin/SHA256SUMS.part
347a08df3a7dd52c45201f8ca833b5be71eff53c22349a2ac1963fc0808c1a1b  guix-build-3d70c0586847/output/x86_64-apple-darwin/bitcoin-3d70c0586847-x86_64-apple-darwin-unsigned.dmg
5797c45128ea02fc50ac409e69653b699587584174d898ffff03303836f09780  guix-build-3d70c0586847/output/x86_64-apple-darwin/bitcoin-3d70c0586847-x86_64-apple-darwin-unsigned.tar.gz
36020d61af2971f68e5b3f9c85ad5dc6a3e65f26dfdd87aafbf7b71de73ba267  guix-build-3d70c0586847/output/x86_64-apple-darwin/bitcoin-3d70c0586847-x86_64-apple-darwin.tar.gz
7e200f1d66ba20f5d79084aa886a918d7d797c41d311eeed3972e64e0d2d0b9b  guix-build-3d70c0586847/output/x86_64-linux-gnu/SHA256SUMS.part
48a7b2d3b7c6b5aa2ffb44687708b88c92e023a2941536a877e5da1dfdb99495  guix-build-3d70c0586847/output/x86_64-linux-gnu/bitcoin-3d70c0586847-x86_64-linux-gnu-debug.tar.gz
4e568c00d8df31ef9c2dab293fa462379bdadc37589e0fb953e36987ce1665cb  guix-build-3d70c0586847/output/x86_64-linux-gnu/bitcoin-3d70c0586847-x86_64-linux-gnu.tar.gz
9734757666cafdd83a7d86cb5ef7b8ce21060620cf544f2fd6b72c73b738683d  guix-build-3d70c0586847/output/x86_64-w64-mingw32/SHA256SUMS.part
13b5d2506a7f9fa8efa861bce71d9fdefa7bd241a808b9a074a46c03fa5e7a5a  guix-build-3d70c0586847/output/x86_64-w64-mingw32/bitcoin-3d70c0586847-win64-debug.zip
b0a36d732983c4ee9302be8d795f7217ba64d95cc53b9cb987602a1189b0cd7b  guix-build-3d70c0586847/output/x86_64-w64-mingw32/bitcoin-3d70c0586847-win64-setup-unsigned.exe
6b3f713c8799f7bc26ede39808f98876d512d0218b49d343a353629d4bb7ef39  guix-build-3d70c0586847/output/x86_64-w64-mingw32/bitcoin-3d70c0586847-win64-unsigned.tar.gz
b1059a8571fd68a3003295609dfcc6bc4b6d7cf2f1a39d646c92a0187c14752c  guix-build-3d70c0586847/output/x86_64-w64-mingw32/bitcoin-3d70c0586847-win64.zip
  10. hebasto approved
  11. hebasto commented at 4:36 PM on April 2, 2022: member

    ACK 3d70c058684727cd036314014ec0a9208d3e9168, I have reviewed the code and it looks OK, I agree it can be merged.

  12. fanquake merged this on Apr 2, 2022
  13. fanquake closed this on Apr 2, 2022
  14. fanquake deleted the branch on Apr 2, 2022
  15. sidhujag referenced this in commit 514766f71a on Apr 3, 2022
  16. MarcoFalke removed the label DrahtBot Guix build requested on Apr 5, 2022
  17. DrahtBot locked this on Apr 5, 2023
Contributors
fanquakelaanwjprusnakhebasto
Labels
Build system
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-26 06:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me