refactor: remove macOS MAP_ANONYMOUS work around #24746

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:macOS_has_MAP_ANONYMOUS changing 1 files +0 −6
  1. fanquake commented at 12:06 pm on April 3, 2022: member

    This was added to support compilation on macOS 10.10, our minimum required macOS is now 10.15. macOS has also supported it since 10.11.

    See #9063.

    macOS 12.3 manpage for mmap:

    0     MAP_ANONYMOUS     Synonym for MAP_ANON.
    1
    2     MAP_ANON          Map anonymous memory not associated with any specific file. 
    
  2. refactor: remove macOS MAP_ANONYMOUS work around
    This was added to support compilation on macOS 10.10, our minimum
    required macOS is now 10.15. macOS has also supported it since 10.11.
    
    See https://github.com/bitcoin/bitcoin/pull/9063.
    112a7ab9a8
  3. fanquake added the label macOS on Apr 3, 2022
  4. jarolrod commented at 8:28 am on April 4, 2022: member

    ACK 112a7ab9a8e4c96f5750ac3b929b433d8507354c

    Confirmed no problems with compilation on M1 with macOS 12.3 and x86 on 10.15 and 12.3. I’ve also confirmed that the manpages for osx 10.11.6 contains a declaration on MAP_ANONYMOUS. So this change should be fine.

    0MAP_ANONYMOUS     Synonym for MAP_ANON.
    
  5. laanwj commented at 10:52 am on April 4, 2022: member
    Code review ACK 112a7ab9a8e4c96f5750ac3b929b433d8507354c
  6. laanwj merged this on Apr 4, 2022
  7. laanwj closed this on Apr 4, 2022

  8. fanquake deleted the branch on Apr 4, 2022
  9. sidhujag referenced this in commit 09e14b3a28 on Apr 4, 2022
  10. DrahtBot locked this on Apr 4, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-29 01:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me