Fixes #24747
ci: Add clang-tidy task #24753
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2204-ci-tidy-💻 changing 6 files +45 −1-
MarcoFalke commented at 8:50 AM on April 4, 2022: member
- MarcoFalke added the label Tests on Apr 4, 2022
-
fanquake commented at 8:52 AM on April 4, 2022: member
Concept ACK
- MarcoFalke force-pushed on Apr 4, 2022
-
ci: Add clang-tidy task fab24f8c35
- MarcoFalke force-pushed on Apr 4, 2022
-
vincenzopalazzo commented at 2:26 PM on April 4, 2022: none
Concept ACK
-
laanwj commented at 11:46 AM on April 5, 2022: member
Concept ACK (given that this doesn't cause false positives or spurious failures)
-
MarcoFalke commented at 11:52 AM on April 5, 2022: member
If this task fails because clang-tidy doesn't work, we'll need to revert 67f654ef612c8dbefb969e6e67c286ea2c2e82d6 as well.
If there are silent merge conflicts, I think we can handle them as they arise. Worst case is we ignore the red status of the task for a few days.
-
MarcoFalke commented at 11:54 AM on April 5, 2022: member
(And before merging this pull, make sure to re-run the tidy task to be sure about silent mere conflicts)
- fanquake approved
-
fanquake commented at 8:52 AM on April 6, 2022: member
ACK fab24f8c3540b6f1a128cb9d6812df6678472b8d
(And before merging this pull, make sure to re-run the tidy task to be sure about silent mere conflicts)
Rebooted in https://cirrus-ci.com/task/5864889825624064.
- vincenzopalazzo approved
-
vincenzopalazzo commented at 8:54 AM on April 6, 2022: none
-
jonatack commented at 8:56 AM on April 6, 2022: member
Concept ACK
-
fanquake commented at 9:10 AM on April 6, 2022: member
Rebooted in https://cirrus-ci.com/task/5864889825624064.
🟢
- fanquake merged this on Apr 6, 2022
- fanquake closed this on Apr 6, 2022
- MarcoFalke deleted the branch on Apr 6, 2022
- sidhujag referenced this in commit 9050655ae8 on Apr 6, 2022
- DrahtBot locked this on Apr 6, 2023
