This PR allows for buildings the depends packages on WSL
Tested on Windows 11 WSL 2.x
Updated funcs.mk to work with Windows Subsystem for Linux #24761
pull mxaddict wants to merge 1 commits into bitcoin:master from mxaddict:temp-master changing 1 files +3 −3-
mxaddict commented at 2:37 PM on April 4, 2022: contributor
-
hebasto commented at 2:51 PM on April 4, 2022: member
This PR allows for buildings the depends packages on WSL
Tested on Windows 11 WSL 2.x
What is the current issue exactly?
- DrahtBot added the label Build system on Apr 4, 2022
-
mxaddict commented at 12:55 AM on April 5, 2022: contributor
Current issue is that Windows Subsystem for Linux adds some PATH values that have () and spaces, which cause these 3 lines of code to get a syntax error, simply adding the quotes fixes the issue.
-
mxaddict commented at 12:56 AM on April 5, 2022: contributor
Actually to be clear the issue also happens on any linux distro that has PATH values with those characters.
-
-
mxaddict commented at 10:37 AM on April 5, 2022: contributor
I think this change fixes those issue mentioned, I'm able to build depends correctly with path values with spaces with this fix.
-
mxaddict commented at 10:40 AM on April 5, 2022: contributor
With fix:
Without:
-
mxaddict commented at 10:41 AM on April 5, 2022: contributor
$PATHvalue:
-
laanwj commented at 2:03 PM on April 5, 2022: member
Concept and code review ACK 663cda823a3a4348a57f9edb6c77aa8d35209d09
I'm kind of happy to see building in paths with spaces is almost supported. It's almost like it's 2022 not 1984. Once that works it'd make sense to do it in one of the CI runs.
-
mxaddict commented at 2:29 PM on April 5, 2022: contributor
Concept and code review ACK 663cda8
I'm kind of happy to see building in paths with spaces is almost supported. It's almost like it's 2022 not 1984. Once that works it'd make sense to do it in one of the CI runs.
I usually avoid path values with spaces, but sometimes it just can't be helped 😄
-
laanwj commented at 1:43 PM on April 7, 2022: member
I usually avoid path values with spaces, but sometimes it just can't be helped smile
Sure, if that's your preference. But there should be no technical reason to :smile: Space has been a valid character in paths since, i dunno, moving away from FAT16? To be sure, some of the UNIX tooling is just very clumsy in that regard, it's not specific to this project. But things are improving slowly.
-
mxaddict commented at 1:49 PM on April 7, 2022: contributor
I usually avoid path values with spaces, but sometimes it just can't be helped smile
Sure, if that's your preference. But there should be no technical reason to 😄 Space has been a valid character in paths since, i dunno, moving away from FAT16? To be sure, some of the UNIX tooling is just very clumsy in that regard, it's not specific to this project. But things are improving slowly.
For sure!
-
fanquake commented at 2:41 PM on April 7, 2022: member
@mxaddict can you confirm that everything works with this change. Not just building depends, but also building bitcoind, running
make install, even performing a cross-compile etc.You'll also need to get rid of the merge commit out of the PR, and, while you're at it, can you update the commit message for the change to be more descriptive than
Updated funcs.mk to work... -
mxaddict commented at 2:49 PM on April 7, 2022: contributor
I can confirm that I can cross compile for mingw and osx as well, have not tried any other builds though
I assume it also does not break any builds as the CI runs have passed.
Sure, I can update the commit message and remove the merge commit
- mxaddict force-pushed on Apr 7, 2022
-
Updated PATH references in depends/funcs.mk to work with $PATH values with spaces and parenthesis 9bf0e445d5
- mxaddict force-pushed on Apr 7, 2022
-
-
mxaddict commented at 12:44 AM on August 1, 2022: contributor
Closing, no one seems to be interested in this PR
- mxaddict closed this on Aug 1, 2022
- bitcoin locked this on Aug 1, 2023
Labels