According to pull 2444 (https://github.com/bitcoin/bitcoin/pull/2444):
The windows icon contains multiple resolutions up to 256px. Is someone capable of doing a Vista and W8 test? Who takes care of the linux test?
Signed-off-by: Jonas Schnelli <jonas.schnelli@include7.ch>
- new windows .ico contains multiple resolutions up to 256px
- new testnet (green) icon
- new png icon for llinux, etc.
- new doxygen icon
- changed the assets-attribution.txt
Signed-off-by: Jonas Schnelli <jonas.schnelli@include7.ch>
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/27cc0d7fd248fac60705609c51ce25e4db04a758 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
Cute!
0 | @@ -1,5 +1,8 @@ 1 | Icon: src/qt/res/icons/clock*.png, src/qt/res/icons/tx*.png, 2 | - src/qt/res/src/*.svg 3 | + src/qt/res/src/clock_green.svg, src/qt/res/src/clock1.svg 4 | + src/qt/res/src/clock2.svg, src/qt/res/src/clock3.svg
Can you indent these and the 2 below with the above line :)?
Because the old text "src/qt/res/src/*.svg" had covered the newly generated src/qt/res/src/bitcoin.svg i had to "rewrite it arithmetically". :) I think it's okay like this.
37 | @@ -35,7 +38,7 @@ Designer: http://www.everaldo.com 38 | Icon Pack: Crystal SVG 39 | License: LGPL 40 | 41 | -Icon: src/qt/res/icons/bitcoin.png, src/qt/res/icons/toolbar.png 42 | +Icon: src/qt/res/icons/toolbar.png
Who did toolbar_testnet.png btw. and do we need updated version of these also?
I did the toolbar_testnet icon. The toolbar icon is scaled so far that this change doesn't matter to it (and for example, it doesn't have the drop shadow in the first place).
I think the bitcoin_logo_doxygen.png looks a little blurry compared to the former version. I'm not yet sure if I like the new testnet color, I will wait for pull-tester to build and then try it out :). @jonasschnelli Very nice work, I have no passion to be a graphics-artist and love that work you show use here.
I also liked the darker testnet color a bit better. Having said that, it's only the testnet, the poison green is meant to be kind of a warning color :) In Andreas Schildbach's bitcoin-wallet client a different take on the warning pattern is used: https://play.google.com/store/apps/details?id=de.schildbach.wallet_test&hl=en
ACK, we should certainly merge this for 0.8.2
I'm fine with testnet, if you are... ACK for the mainnet icon ;).
In my eye, the testnet color should just be "visible" somehow. Because mostly devs are using the testnet icon, it has – in my eyes – not the same quality requirements. But nevertheless, the quality is good. :)
Signed-off-by: Jonas Schnelli <jonas.schnelli@include7.ch>
@Diapolo: right, the doxygen icon was blurry. It's fixed and pushed now.
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/a653191f748f56addf0cfa219319cfc5358b962d for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
@jonasschnelli I'm now using your current icons with my local build and I think you should also update the toolbar.png and toolbar_testnet.png versions. Specially on testnet the combination of the new color with the old one in the Windows system-tray looks really weird/ugly :). Also I still think the old color was a little more friedly, the new one doesn't fit into the color scheme (at least on Windows).
@Diapolo your right. I did not take care of the testnet toolbar. I will no update the color more according to the old testnet color (was more warm) and also take care of the testnet toolbar.
@jonasschnelli Can you take a look? I think the new icon is missing a little transparency or fading on the outer ring and seems smaller (Or is this intended?) for me on Windows.
(left old / right new)
@Diapolo let me startup my Windows WM...
fixed and placed in PR #2497
preview:
... and the remove of the transparency was a conscious decision.