overhaul of the testnet icon (green color) and the toolbar icons #2497

jonasschnelli commented at 6:06 PM on April 9, 2013: contributor

redefined the green color
created new toolbar icons
updated the assets-attribution.txt

Signed-off-by: Jonas Schnelli jonas.schnelli@include7.ch

overhaul of the testnet icon (green color) and the toolbar icons

- redefined the green color
- created new toolbar icons
- updated the assets-attribution.txt

Signed-off-by: Jonas Schnelli <jonas.schnelli@include7.ch>

f9579c55b3

laanwj commented at 7:44 PM on April 9, 2013: member

Can you rebase? Github doesn't want to merge it for some reason.

jonasschnelli commented at 7:57 PM on April 9, 2013: contributor

Somehow the pull request is closed.. i'll create a new one soon.

laanwj commented at 8:08 PM on April 9, 2013: member

This pull request is still open, it's #2494 that is closed (which has the same title, which is strange).

jonasschnelli commented at 10:44 AM on April 10, 2013: contributor

let's ignore #2494 ...

Diapolo commented at 10:49 AM on April 10, 2013: none

ACK

Edit: @laanwj Is there any chance we could include this new testnet icon into bitcoin-qt.exe? I know the mainnet icon is embedded, but to have both would be really nice.

Edit 2: Ah this is happening in bitcoin-qt.rc. So @jonasschnelli Could you integrate a bitcoin_testnet.ico into this pull :)?

laanwj commented at 10:59 AM on April 10, 2013: member

ACK @diapolo would make sense, I suppose, as the other icon could be selected for shortcuts that start testnet.

I don't think it is necessary for this pull though. It's extra functionality that wasn't there before.

Diapolo commented at 11:14 AM on April 10, 2013: none

@laanwj Yeah sure, could be a separate pull, so this one can be merged.

better quality windows .ICO icon file

- icon quality of the win icon of <256px resolutions are now much better

Signed-off-by: Jonas Schnelli <jonas.schnelli@include7.ch>

4c23743635

jonasschnelli commented at 12:44 PM on April 10, 2013: contributor

also added a new windows ico file (better quality for <256px resolutions). Reported by Diapolo (https://github.com/bitcoin/bitcoin/pull/2477#issuecomment-16167568)

Diapolo commented at 1:13 PM on April 10, 2013: none

Thanks for looking into this :). Are you able to also create a bitcoin_testnet.ico (as mentioned above)?

jonasschnelli commented at 1:14 PM on April 10, 2013: contributor

Yes. Can do. But currently the icon is changed by QT with a 256x256px PNG replacement. Would you then change the code to support ICO files? Or is the 256x256 PNG testnet file not in appropriate quality?

Diapolo commented at 1:22 PM on April 10, 2013: none

I'm talking about the icon file Windows is using to display when using shortcuts and the one the bitcoin-qt.exe is using. The code is here in the ressource file: https://github.com/bitcoin/bitcoin/blob/master/src/qt/res/bitcoin-qt.rc#L1

Dunno if this supports png files.

Edit: It seems the bitcoin.png is JUST used 2 times in bitcoingui.cpp via :icons/bitcoin (see file bitcoin.qrc)!

jonasschnelli commented at 1:28 PM on April 10, 2013: contributor

Hmm.. i hope i still see through. :) The file "icons/bitcoin.ico" is updated (multi-resolution ICO file) and looks fine if it comes to the render of the .exe file as well as of the shortcut version (48x48). Currently there is no bitcoin_testnet.ico and as far as i can see (in the Windows land) theres no code or buld-process script using a such bitcoin_testnet.ico.

But i can just create you a bitcoin_testnet.ico (multiresolution windows icon) and you will look for the rest.

Diapolo commented at 1:32 PM on April 10, 2013: none

@jonasschnelli I would add that icon to bitcoin-qt.exe via another pull :).

jonasschnelli commented at 1:34 PM on April 10, 2013: contributor

i know and i'm sorry,.. was to lazy to create another branch.

Diapolo commented at 1:36 PM on April 10, 2013: none

No problem, I'm fine with fixing small stuff to make that client more perfect!

laanwj referenced this in commit 9a4eaf3cff on Apr 11, 2013

laanwj merged this on Apr 11, 2013

laanwj closed this on Apr 11, 2013

laanwj commented at 4:58 AM on April 11, 2013: member

Manually merged: there was a trivial conflict in assets_attributions.txt

Diapolo commented at 6:38 AM on April 11, 2013: none

@jonasschnelli Can you create a branch with a bitcoin_testnet.ico update? But don't yet open a pull-request here, because I'm trying to create a pull for YOUR branch, which you can then merge and create a pull for us here which includes my change :).

jonasschnelli commented at 7:06 AM on April 11, 2013: contributor

@Diapolo will do that asap

Diapolo commented at 7:27 AM on April 11, 2013: none

@jonasschnelli I want to thank you, I really like he new icon set, good job and keep it up!

jonasschnelli commented at 1:18 PM on April 11, 2013: contributor

@Diapolo branch with new tn ico file: https://github.com/jonasschnelli/bitcoin/tree/new_testnet_ico_file

laudney referenced this in commit cb2c5edee9 on Mar 19, 2014

DrahtBot locked this on Sep 8, 2021