refactor: Use [[maybe_unused]] attribute #24772

1. 
   hebasto commented at 11:57 am on April 5, 2022: member

   This change is required for bitcoin/bitcoin#24773 as it prevents MSVC yelling about “warning C4551: function call missing argument list”.

   But it is useful by itself as it makes code more concise and readable.

2. refactor: Drop unneeded workarounds aimed to silence unused warning

   All of the touched symbols are indeed used regardless of any macros.

   55e0fc8df9
3. refactor: Use [[maybe_unused]] attribute 07ddecb84e
4. fanquake added the label Refactoring on Apr 5, 2022
5. vincenzopalazzo approved
6. 
   vincenzopalazzo commented at 2:53 pm on April 6, 2022: none

   ACK https://github.com/bitcoin/bitcoin/pull/24772/commits/07ddecb84e6097684fa56cfc79c8c2aad76f6604
7. 
   Empact commented at 3:25 pm on April 6, 2022: member

   Code review ACK 07ddecb84e6097684fa56cfc79c8c2aad76f6604
8. w0xlt approved
9. 
   w0xlt commented at 3:32 pm on April 6, 2022: contributor

   ACK 07ddecb
10. 
    laanwj commented at 1:58 pm on April 19, 2022: member

    Code review ACK 07ddecb84e6097684fa56cfc79c8c2aad76f6604
11. laanwj merged this on Apr 19, 2022
12. laanwj closed this on Apr 19, 2022

    ---

13. hebasto deleted the branch on Apr 19, 2022
14. sidhujag referenced this in commit f308cdc773 on Apr 19, 2022
15. DrahtBot locked this on Apr 19, 2023

Contributors
hebasto vincenzopalazzo Empact w0xlt laanwj

Labels
Refactoring