build: Do not modify `common.init.vcxproj` directly #24775

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:220405-toolset changing 3 files +12 −16
  1. hebasto commented at 5:14 PM on April 5, 2022: member

    When building with MSVC, and using a non-default toolset, the following command

    >python build_msvc\msvc-autogen.py -toolset v143
    

    actually modifies the source tree:

    >git diff
    warning: LF will be replaced by CRLF in build_msvc/common.init.vcxproj.
    The file will have its original line endings in your working directory
    diff --git a/build_msvc/common.init.vcxproj b/build_msvc/common.init.vcxproj
    index 0cbe2effd..44b7efff3 100644
    --- a/build_msvc/common.init.vcxproj
    +++ b/build_msvc/common.init.vcxproj
    @@ -39,7 +39,7 @@
       <PropertyGroup Condition="'$(Configuration)'=='Release'" Label="Configuration">
         <LinkIncremental>false</LinkIncremental>
         <UseDebugLibraries>false</UseDebugLibraries>
    -    <PlatformToolset>v142</PlatformToolset>
    +    <PlatformToolset>v143</PlatformToolset>
         <CharacterSet>Unicode</CharacterSet>
         <GenerateManifest>No</GenerateManifest>
         <OutDir>$(SolutionDir)$(Platform)\$(Configuration)\$(ProjectName)\</OutDir>
    @@ -49,7 +49,7 @@
       <PropertyGroup Condition="'$(Configuration)'=='Debug'" Label="Configuration">
         <LinkIncremental>true</LinkIncremental>
         <UseDebugLibraries>true</UseDebugLibraries>
    -    <PlatformToolset>v142</PlatformToolset>
    +    <PlatformToolset>v143</PlatformToolset>
         <CharacterSet>Unicode</CharacterSet>
         <OutDir>$(SolutionDir)$(Platform)\$(Configuration)\$(ProjectName)\</OutDir>
         <IntDir>$(Platform)\$(Configuration)\$(ProjectName)\</IntDir>
    
    

    This PR fixes this bug.

  2. build, refactor: Add set_properties() to msvc-autogen.py 2391fb7850
  3. build: Do not modify `common.init.vcxproj` directly ba0bf79a22
  4. hebasto added the label Bug on Apr 5, 2022
  5. hebasto added the label Windows on Apr 5, 2022
  6. hebasto added the label Build system on Apr 5, 2022
  7. hebasto commented at 5:14 PM on April 5, 2022: member
  8. sipsorcery commented at 6:12 PM on April 5, 2022: member

    tACK ba0bf79a224d92e122f98fda94cb9f77092fea1f.

  9. MarcoFalke merged this on Apr 5, 2022
  10. MarcoFalke closed this on Apr 5, 2022

  11. hebasto deleted the branch on Apr 5, 2022
  12. sidhujag referenced this in commit d97f72173f on Apr 5, 2022
  13. DrahtBot locked this on Apr 5, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 03:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me