Ideally the whole source code is run through clang-tidy, but it can only run if the code is compiled. So install all optional deps for the targets. Hopefully this doesn't increase the run time too much.
ci: Build all optional dependencies in tidy task #24779
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2204-ci-tidy-🏀 changing 1 files +2 −2-
MarcoFalke commented at 9:25 AM on April 6, 2022: member
- DrahtBot added the label Tests on Apr 6, 2022
-
MarcoFalke commented at 10:00 AM on April 6, 2022: member
Looks like this will take twice the time, but that still looks ok currently.
-
fanquake commented at 10:43 AM on April 6, 2022: member
If twice the time is still only 12 minutes, that seems fine. No natpmp or miniupnpc?
-
ci: Build all optional tools in tidy task faa7ae8242
- MarcoFalke force-pushed on Apr 6, 2022
- fanquake approved
-
fanquake commented at 12:29 PM on April 6, 2022: member
ACK faa7ae82425a5eb6d8ef8f5f03fb3c7f6f8ea2ff - runtime is still ~13 minutes.
- fanquake merged this on Apr 6, 2022
- fanquake closed this on Apr 6, 2022
- MarcoFalke deleted the branch on Apr 6, 2022
- sidhujag referenced this in commit 0e13fb2b3d on Apr 6, 2022
- DrahtBot locked this on Apr 6, 2023
Contributors
Labels