Update libsecp256k1 subtree to current master

fanquake commented at 8:22 pm on April 6, 2022: member

The motivation for this bump is some small build cleanups, including dropping the --enable-experimental flag from the libsecp configure invocation, as well as some now-redundant pkg-config variable exporting from our own configure. We also get the benefit of a slightly more efficient libsecp configure due to https://github.com/bitcoin-core/secp256k1/pull/1088.

This also includes a change in our code to migrate from using the now deprecated secp256k1_schnorrsig_sign to secp256k1_schnorrsig_sign32.

Guix Build (on x86_64):

 0b9f6ad90c75f7edd7c4444c6c3401d8b6ab29a8da22ae22ddaedd94688227b5d  guix-build-404c53062bb8/output/aarch64-linux-gnu/SHA256SUMS.part
 1250d47ae299d8385d5590518fa2adaabde76e2566fd27e12bf36b62663d13e13  guix-build-404c53062bb8/output/aarch64-linux-gnu/bitcoin-404c53062bb8-aarch64-linux-gnu-debug.tar.gz
 248d610dc6f5169f925f782571dac2f082695f89008beadad4adef4c1b583a612  guix-build-404c53062bb8/output/aarch64-linux-gnu/bitcoin-404c53062bb8-aarch64-linux-gnu.tar.gz
 38f04ee26e4079719e3935bd0e4287cc11a2a16875bf01e2a63d67492a1fa5367  guix-build-404c53062bb8/output/arm-linux-gnueabihf/SHA256SUMS.part
 47d7d7fcfb032bda92e53abd8d608257f0ef17b1e3e52a1414260b896786fb2dc  guix-build-404c53062bb8/output/arm-linux-gnueabihf/bitcoin-404c53062bb8-arm-linux-gnueabihf-debug.tar.gz
 530bae2ff3d044f4e39f992a68f6b296b7be2aea350bca4a0415c739a32c20bd9  guix-build-404c53062bb8/output/arm-linux-gnueabihf/bitcoin-404c53062bb8-arm-linux-gnueabihf.tar.gz
 65f550fb0b950250eeffce3480ec6403530b0880570a5860ef6c32a3e92eac92f  guix-build-404c53062bb8/output/arm64-apple-darwin/SHA256SUMS.part
 7c10664d13aeec8c860bf72be833c738973ae18e4d28cdf08b2f9bee960ebff1d  guix-build-404c53062bb8/output/arm64-apple-darwin/bitcoin-404c53062bb8-arm64-apple-darwin-unsigned.dmg
 8becab75b11cf4ca6f559f8eef835f3574629f6eb932ac716ed4f8c044a85831f  guix-build-404c53062bb8/output/arm64-apple-darwin/bitcoin-404c53062bb8-arm64-apple-darwin-unsigned.tar.gz
 9bc86433652fe3552f6a13088191364ae7514c9fe3a244da86a6db096bb4922fc  guix-build-404c53062bb8/output/arm64-apple-darwin/bitcoin-404c53062bb8-arm64-apple-darwin.tar.gz
101f585cb9a1356343df4b2726ecfe2598c9903304afb047c047c2cef318555dd3  guix-build-404c53062bb8/output/dist-archive/bitcoin-404c53062bb8.tar.gz
119ede534ba2c6cecb550473eead195627327e826ebb0118e23d60ab482d40e241  guix-build-404c53062bb8/output/powerpc64-linux-gnu/SHA256SUMS.part
1277ddb7d7d639b1dd4508468a8ef27e45b35c8b2f8624584a70e6b64798a4ea7a  guix-build-404c53062bb8/output/powerpc64-linux-gnu/bitcoin-404c53062bb8-powerpc64-linux-gnu-debug.tar.gz
1336178c1f1c12942ff05275daa3570f8b45419ee8d9f391d750afb405219986f0  guix-build-404c53062bb8/output/powerpc64-linux-gnu/bitcoin-404c53062bb8-powerpc64-linux-gnu.tar.gz
148a15a4da7a9a5e00c49d9aeedf3c6fc666c0d230be1369eac7caf4571d5905e0  guix-build-404c53062bb8/output/powerpc64le-linux-gnu/SHA256SUMS.part
15400c58113f2d07c87e03c8528b292c6aca808a2bccae4b041cad3a26a05b6aad  guix-build-404c53062bb8/output/powerpc64le-linux-gnu/bitcoin-404c53062bb8-powerpc64le-linux-gnu-debug.tar.gz
163b9f9d8614ac3a27416e53354b2b0a64d364f91493e9d0f41583a6f492546824  guix-build-404c53062bb8/output/powerpc64le-linux-gnu/bitcoin-404c53062bb8-powerpc64le-linux-gnu.tar.gz
1798506b23ee08ad8af958f816da2e4518d661e88d5c6308de1f5e3b2fc787b86c  guix-build-404c53062bb8/output/riscv64-linux-gnu/SHA256SUMS.part
18c701a7b77cea4fdc2588b511f1b2c71b89c83bfba19fdb2ac113a5a4b14ac392  guix-build-404c53062bb8/output/riscv64-linux-gnu/bitcoin-404c53062bb8-riscv64-linux-gnu-debug.tar.gz
1934d58e6392cd58b3c76e30cd8600c0dbefba7e9c6d5df78c3ef23e81c4e4d26a  guix-build-404c53062bb8/output/riscv64-linux-gnu/bitcoin-404c53062bb8-riscv64-linux-gnu.tar.gz
2092fa30e9c6d81dd1e1514b65d3e1abe68ded897237cd99f66aa760d445109c04  guix-build-404c53062bb8/output/x86_64-apple-darwin/SHA256SUMS.part
21bee180b02f178ae9980ef159f65913a71cbd037c4aff5f2906af5f174a677da3  guix-build-404c53062bb8/output/x86_64-apple-darwin/bitcoin-404c53062bb8-x86_64-apple-darwin-unsigned.dmg
22ad7d18d779ab7a7944817d1f368d0a6bdd174bf1211b0f90180c8ccf04ec4062  guix-build-404c53062bb8/output/x86_64-apple-darwin/bitcoin-404c53062bb8-x86_64-apple-darwin-unsigned.tar.gz
237489d1d5d48ad95cf58bb11b5fdeccadac6fa758784fb498529fca2330abe069  guix-build-404c53062bb8/output/x86_64-apple-darwin/bitcoin-404c53062bb8-x86_64-apple-darwin.tar.gz
2474660fb0ebce2a08b03980a57bffcad62e078dc967a74d2395660ff51c019640  guix-build-404c53062bb8/output/x86_64-linux-gnu/SHA256SUMS.part
25cd377fa6b46276c2f8a32e199e6f9adf6aa67315688656709d6dc0744d54a837  guix-build-404c53062bb8/output/x86_64-linux-gnu/bitcoin-404c53062bb8-x86_64-linux-gnu-debug.tar.gz
26919c521950369d8ad46db2d15b00abb488abfb080d157a41b2db429122a428ed  guix-build-404c53062bb8/output/x86_64-linux-gnu/bitcoin-404c53062bb8-x86_64-linux-gnu.tar.gz
272debca995d432965a8786b6ff74aed42e9e2f1cb0fecbe2d9fc5b850c192fcff  guix-build-404c53062bb8/output/x86_64-w64-mingw32/SHA256SUMS.part
28e33169f684fb031ec18ed39812617d3eb263257f6c7564b8f4c974ad05fe672c  guix-build-404c53062bb8/output/x86_64-w64-mingw32/bitcoin-404c53062bb8-win64-debug.zip
29029d0a4180cb908d517fcf689dcf46d42fbf383e11dc609711617066ae039ab0  guix-build-404c53062bb8/output/x86_64-w64-mingw32/bitcoin-404c53062bb8-win64-setup-unsigned.exe
307e349c688cac66436562c4805f420b0536db5a3b3abf54d0e8c7752f59874a5c  guix-build-404c53062bb8/output/x86_64-w64-mingw32/bitcoin-404c53062bb8-win64-unsigned.tar.gz
311bff98e82e95c93d6060227408502f5e2d8597d526b912cb6dc0a90ae3094a8f  guix-build-404c53062bb8/output/x86_64-w64-mingw32/bitcoin-404c53062bb8-win64.zip

Squashed 'src/secp256k1/' changes from 0559fc6e41..8746600eec

8746600eec Merge bitcoin-core/secp256k1#1093: hash: Make code agnostic of endianness
37d36927df tests: Add tests for _read_be32 and _write_be32
912b7ccc44 Merge bitcoin-core/secp256k1#1094: doc: Clarify configure flags for optional modules
55512d30b7 doc: clean up module help text in configure.ac
d9d94a9969 doc: mention optional modules in README
616b43dd3b util: Remove endianness detection
8d89b9e6e5 hash: Make code agnostic of endianness
d0ad5814a5 Merge bitcoin-core/secp256k1#995: build: stop treating schnorrsig, extrakeys modules as experimental
1ac7e31c5b Merge bitcoin-core/secp256k1#1089: Schnorrsig API improvements
587239dbe3 Merge bitcoin-core/secp256k1#731: Change SHA256 byte counter from size_t to uint64_t
f8d9174357 Add SHA256 bit counter tests
7f09d0f311 README: mention that ARM assembly is experimental
b8f8b99f0f docs: Fix return value for functions that don't have invalid inputs
f813bb0df3 schnorrsig: Adapt example to new API
99e6568fc6 schnorrsig: Rename schnorrsig_sign to schnorsig_sign32 and deprecate
fc94a2da44 Use SECP256K1_DEPRECATED for existing deprecated API functions
3db0560606 Add SECP256K1_DEPRECATED attribute for marking API parts as deprecated
80cf4eea5f build: stop treating schnorrsig, extrakeys modules as experimental
e0508ee9db Merge bitcoin-core/secp256k1#1090: configure: Remove redundant pkg-config code
21b2ebaf74 configure: Remove redundant pkg-config code
0e5cbd01b3 Merge bitcoin-core/secp256k1#1088: configure: Use modern way to set AR
0d253d52e8 configure: Use modern way to set AR
9b514ce1d2 Add test vector for very long SHA256 messages
8e3dde1137 Simplify struct initializer for SHA256 padding
eb28464a8b Change SHA256 byte counter from size_t to uint64_t
ac83be33d0 Merge bitcoin-core/secp256k1#1079: configure: Add hidden --enable-dev-mode to enable all the stuff
e0838d663d configure: Add hidden --enable-dev-mode to enable all the stuff
fabd579dfa configure: Remove redundant code that sets _enable variables
0d4226c051 configure: Use canonical variable prefix _enable consistently
64b34979ed Merge bitcoin-core/secp256k1#748: Add usage examples
7c9502cece Add a copy of the CC0 license to the examples
42e03432e6 Add usage examples to the readme
517644eab1 Optionally compile the examples in autotools, compile+run in travis
422a7cc86a Add a ecdh shared secret example
b0cfbcc143 Add a Schnorr signing and verifying example
fee7d4bf9e Add an ECDSA signing and verifying example
1253a27756 Merge bitcoin-core/secp256k1#1033: Add _fe_half and use in _gej_add_ge and _gej_double
3ef94aa5ba Merge bitcoin-core/secp256k1#1026: ecdh: Add test computing shared_secret=basepoint with random inputs
3531a43b5b ecdh: Make generator_basepoint test depend on global iteration count
c881dd49bd ecdh: Add test computing shared_secret=basepoint with random inputs
077528317d Merge bitcoin-core/secp256k1#1074: ci: Retry brew update a few times to avoid random failures
e51ad3b737 ci: Retry `brew update` a few times to avoid random failures
b1cb969e8a ci: Revert "Attempt to make macOS builds more reliable"
5dcc6f8dbd Merge bitcoin-core/secp256k1#1069: build: Replace use of deprecated autoconf macro AC_PROG_CC_C89
59547943d6 Merge bitcoin-core/secp256k1#1072: ci: Attempt to make macOS builds more reliable
85b00a1c65 Merge bitcoin-core/secp256k1#1068: sage: Fix incompatibility with sage 9.4
ebb1beea78 sage: Ensure that constraints are always fastfracs
d8d54859ed ci: Run sage prover on CI
77cfa98dbc sage: Normalize sign of polynomial factors in prover
eae75869cf sage: Exit with non-zero status in case of failures
d9396a56da ci: Attempt to make macOS builds more reliable
e0db3f8a25 build: Replace use of deprecated autoconf macro AC_PROG_CC_C89
e848c3799c Update sage files for new formulae
d64bb5d4f3 Add fe_half tests for worst-case inputs
b54d843eac sage: Fix printing of errors
4eb8b932ff Further improve doubling formula using fe_half
557b31fac3 Doubling formula using fe_half
2cbb4b1a42 Run more iterations of run_field_misc
9cc5c257ed Add test for secp256k1_fe_half
925f78d55e Add _fe_half and use in _gej_add_ge
e108d0039c sage: Fix incompatibility with sage 9.4
d8a2463246 Merge bitcoin-core/secp256k1#899: Reduce stratch space needed by ecmult_strauss_wnaf.
0a40a4861a Merge bitcoin-core/secp256k1#1049: Faster fixed-input ecmult tests
070e772211 Faster fixed-input ecmult tests
c8aa516b57 Merge bitcoin-core/secp256k1#1064: Modulo-reduce msg32 inside RFC6979 nonce fn to match spec. Fixes #1063
b797a500ec Create a SECP256K1_ECMULT_TABLE_VERIFY macro.
a731200cc3 Replace ECMULT_TABLE_GET_GE_STORAGE macro with a function.
fe34d9f341 Eliminate input_pos state field from ecmult_strauss_wnaf.
0397d00ba0 Eliminate na_1 and na_lam state fields from ecmult_strauss_wnaf.
7ba3ffcca0 Remove the unused pre_a_lam allocations.
b3b57ad6ee Eliminate the pre_a_lam array from ecmult_strauss_wnaf.
ae7ba0f922 Remove the unused prej allocations.
e5c18892db Eliminate the prej array from ecmult_strauss_wnaf.
c9da1baad1 Move secp256k1_fe_one to field.h
45f37b6506 Modulo-reduce msg32 inside RFC6979 nonce fn to match spec. Fixes #1063.
a1102b1219 Merge bitcoin-core/secp256k1#1029: Simpler and faster ecdh skew fixup
e82144edfb Fixup skew before global Z fixup
40b624c90b Add tests for _gej_cmov
8c13a9bfe1 ECDH skews by 0 or 1
1515099433 Simpler and faster ecdh skew fixup
39a36db94a Merge bitcoin-core/secp256k1#1054: tests: Fix test whose result is implementation-defined
a310e79ee5 Merge bitcoin-core/secp256k1#1052: Use xoshiro256++ instead of RFC6979 for tests
423b6d19d3 Merge bitcoin-core/secp256k1#964: Add release-process.md
9281c9f4e1 Merge bitcoin-core/secp256k1#1053: ecmult: move `_ecmult_odd_multiples_table_globalz_windowa`
77a19750b4 Use xoshiro256++ PRNG instead of RFC6979 in tests
5f2efe684e secp256k1_testrand_int(2**N) -> secp256k1_testrand_bits(N)
05e049b73c ecmult: move `_ecmult_odd_multiples_table_globalz_windowa`
3d7cbafb5f tests: Fix test whose result is implementation-defined
3ed0d02bf7 doc: add CHANGELOG template
6f42dc16c8 doc: add release_process.md
0bd3e4243c build: set library version to 0.0.0 explicitly
b4b02fd8c4 build: change libsecp version from 0.1 to 0.1.0-pre
09971a3ffd Merge bitcoin-core/secp256k1#1047: ci: Various improvements
0b83b203e1 Merge bitcoin-core/secp256k1#1030: doc: Fix upper bounds + cleanup in field_5x52_impl.h comment
1287786c7a doc: Add comment to top of field_10x26_impl.h
58da5bd589 doc: Fix upper bounds + cleanup in field_5x52_impl.h comment
b39d431aed Merge bitcoin-core/secp256k1#1044: Add another ecmult_multi test
b4ac1a1d5f ci: Run valgrind/memcheck tasks with 2 CPUs
e70acab601 ci: Use Cirrus "greedy" flag to use idle CPU time when available
d07e30176e ci: Update brew on macOS
22382f0ea0 ci: Test different ecmult window sizes
a69df3ad24 Merge bitcoin-core/secp256k1#816: Improve checks at top of _fe_negate methods
22d25c8e0a Add another ecmult_multi test
515e7953ca Improve checks at top of _fe_negate methods
26a022a3a0 ci: Remove STATICPRECOMPUTATION
10461d8bd3 precompute_ecmult: Always compute all tables up to default WINDOW_G
be6944ade9 Merge bitcoin-core/secp256k1#1042: Follow-ups to making all tables fully static
e05da9e480 Fix c++ build
c45386d994 Cleanup preprocessor indentation in precompute{,d}_ecmult{,_gen}
19d96e15f9 Split off .c file from precomputed_ecmult.h
1a6691adae Split off .c file from precomputed_ecmult_gen.h
bb36331412 Simplify precompute_ecmult_print_*
38cd84a0cb Compute ecmult tables at runtime for tests_exhaustive
e458ec26d6 Move ecmult table computation code to separate file
fc1bf9f15f Split ecmult table computation and printing
31feab053b Rename function secp256k1_ecmult_gen_{create_prec -> compute}_table
725370c3f2 Rename ecmult_gen_prec -> ecmult_gen_compute_table
075252c1b7 Rename ecmult_static_pre_g -> precomputed_ecmult
7cf47f72bc Rename ecmult_gen_static_prec_table -> precomputed_ecmult_gen
f95b8106d0 Rename gen_ecmult_static_pre_g -> precompute_ecmult
bae77685eb Rename gen_ecmult_gen_static_prec_table -> precompute_ecmult_gen

git-subtree-dir: src/secp256k1
git-subtree-split: 8746600eec5e7fcd35dabd480839a3a4bdfee87b

afb7a6fe06

Update secp256k1 subtree to latest upstream master 2619657c99

fanquake added the label Upstream on Apr 6, 2022

MarcoFalke added the label DrahtBot Guix build requested on Apr 7, 2022

fanquake commented at 8:16 am on April 7, 2022: member

@sipsorcery could you take a look at the MSVC failure?

sipsorcery commented at 9:17 pm on April 7, 2022: member

@fanquake I think the msvc failure is the same problem that was fixed on #23432.

build: fix MSVC build after subtree update

Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
Co-authored-by: Aaron Clauson <aaron@sipsorcery.com>

d960d4fd3a

build: remove --enable-experimental from libsecp256k1 configure 2656629767

build: remove some no-longer-needed var unexporting from configure ee30bf7c01

key: use secp256k1_schnorrsig_sign32 over deprecated secp256k1_schnorrsig_sign

The renaming occured in
https://github.com/bitcoin-core/secp256k1/pull/1089.

404c53062b

fanquake force-pushed on Apr 7, 2022

fanquake commented at 9:25 pm on April 7, 2022: member

@fanquake I think the msvc failure is the same problem that was fixed on #23432.

Thanks. Have pulled that commit in here.

DrahtBot commented at 8:13 am on April 8, 2022: member

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#24748 (test/BIP324: functional tests for v2 P2P encryption by stratospher)
#24545 (BIP324: Enable v2 P2P encrypted transport by dhruv)
#23561 (BIP324: Handshake prerequisites by dhruv)
#23432 (BIP324: CPubKey encode/decode to elligator-squared by dhruv)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

in src/key.cpp:291 in 404c53062b

287@@ -288,7 +288,7 @@ bool CKey::SignSchnorr(const uint256& hash, Span<unsigned char> sig, const uint2
288         uint256 tweak = XOnlyPubKey(pubkey_bytes).ComputeTapTweakHash(merkle_root->IsNull() ? nullptr : merkle_root);
289         if (!secp256k1_keypair_xonly_tweak_add(GetVerifyContext(), &keypair, tweak.data())) return false;
290     }
291-    bool ret = secp256k1_schnorrsig_sign(secp256k1_context_sign, sig.data(), hash.data(), &keypair, aux.data());
292+    bool ret = secp256k1_schnorrsig_sign32(secp256k1_context_sign, sig.data(), hash.data(), &keypair, aux.data());

laanwj commented at 1:02 pm on April 8, 2022:

The PR for this function renaming (with further rationale) is: bitcoin-core/secp256k1#1089

laanwj commented at 1:06 pm on April 8, 2022: member

Code review ACK 404c53062bb80853d5967187bdb7b5f7e749de7f, I checked the changes to our tree thoroughly but didn’t review all upstream secp256k1 changes in detail.

Subtree check was successful:

0$ test/lint/git-subtree-check.sh src/secp256k1
1src/secp256k1 in HEAD currently refers to tree 1df8d9a97705fe9a2a3e0bbeb030e9de22739633
2src/secp256k1 in HEAD was last updated in commit afb7a6fe06a33956ef43429d31f5934448f6e671 (tree 1df8d9a97705fe9a2a3e0bbeb030e9de22739633)
3GOOD

fanquake commented at 1:33 pm on April 8, 2022: member

cc @real-or-random @jonasnick

real-or-random approved

real-or-random commented at 11:25 am on April 9, 2022: member

utACK 404c53062bb80853d5967187bdb7b5f7e749de7f I reviewed the diff to Core, I’m with updating to libsecp256k1 master, but I haven’t verified that the libsecp256k1 tree here has been updated correctly

gruve-p commented at 12:52 pm on April 9, 2022: contributor

ACK https://github.com/bitcoin/bitcoin/pull/24792/commits/404c53062bb80853d5967187bdb7b5f7e749de7f

fanquake merged this on Apr 9, 2022

fanquake closed this on Apr 9, 2022

fanquake deleted the branch on Apr 9, 2022

DrahtBot commented at 8:30 pm on April 9, 2022: member

Guix builds

File	commit 38d3d0bfc4cae6b31c5ac30f9b0da458bd9a9e57(master)	commit e9b919df0dcd45c2da8c9477315ea687e134d7f6(master and this pull)
SHA256SUMS.part	`5b338da8888ed74e...`	`c2edca0e338ddc47...`
*-aarch64-linux-gnu-debug.tar.gz	`169181d915ec8a1b...`	`7d81bf3836529791...`
*-aarch64-linux-gnu.tar.gz	`7ceb686ca03481e2...`	`c2cb7579d6388cac...`
*-arm-linux-gnueabihf-debug.tar.gz	`322bc373e08936dc...`	`c360f6669c48d702...`
*-arm-linux-gnueabihf.tar.gz	`1312ea4bb32a2e95...`	`33d527acd6454aae...`
*-arm64-apple-darwin-unsigned.dmg	`1f14f9b49309b65a...`	`6bac32947fa8232a...`
*-arm64-apple-darwin-unsigned.tar.gz	`09abc3c6b900ccd2...`	`48ee7e6bde5d17cb...`
*-arm64-apple-darwin.tar.gz	`6bbdb6f1b9470a8e...`	`ad5aeb56dd356dc5...`
*-powerpc64-linux-gnu-debug.tar.gz	`8eb5fdd4a09e3848...`	`42ed120e5c515f95...`
*-powerpc64-linux-gnu.tar.gz	`22926c107bc7180f...`	`b97d9d21c6d1d992...`
*-powerpc64le-linux-gnu-debug.tar.gz	`2ce49961659115f8...`	`da264585402ab96c...`
*-powerpc64le-linux-gnu.tar.gz	`a4e7ad11fe61f2d3...`	`eabef6ce8b40853d...`
*-riscv64-linux-gnu-debug.tar.gz	`22f977cf97993240...`	`66c4872baabbb469...`
*-riscv64-linux-gnu.tar.gz	`42f28fe61dee331f...`	`def0c3d594725e27...`
*-win64-debug.zip	`cc3ddc0b1b213e13...`	`d835e661b0379d95...`
*-win64-setup-unsigned.exe	`9434f90b613e9ff6...`	`b7807839de1dcf33...`
*-win64-unsigned.tar.gz	`0d3362db53cd0e0c...`	`16f6d6cecc90deb3...`
*-win64.zip	`81e85958fe5ef86b...`	`6cd61d7ba2872764...`
*-x86_64-apple-darwin-unsigned.dmg	`74b78a90e14e8026...`	`e07214eab34990a5...`
*-x86_64-apple-darwin-unsigned.tar.gz	`6be471a6518fc661...`	`60a33031dc378282...`
*-x86_64-apple-darwin.tar.gz	`13253355fb41e82a...`	`31a18390c74178c7...`
*-x86_64-linux-gnu-debug.tar.gz	`9df8f207b22ad2d6...`	`c52435ee174d0ded...`
*-x86_64-linux-gnu.tar.gz	`79347964dbbc0281...`	`143bbc9ce29a4586...`
*.tar.gz	`1ff1ea0b99723d31...`	`975afbb9fae7ffd8...`
guix_build.log	`3c7b9e6a0ca97995...`	`adebc2163ba662c7...`
guix_build.log.diff		`13318f08782ee7fc...`

DrahtBot removed the label DrahtBot Guix build requested on Apr 9, 2022

dunxen commented at 7:09 pm on April 10, 2022: contributor

Hmm. Getting a configure error on this but not on the commit prior. Points to secp256k1 ar-lib auxillary file:

0=== configuring in src/secp256k1 (/Users/dunxen/Code/bitcoin/bitcoin/src/secp256k1)
1configure: running /bin/sh ./configure --disable-option-checking '--prefix=/usr/local'  '--with-gui=yes' '--with-sqlite=yes' '--without-bdb' '--disable-shared' '--with-pic' '--enable-benchmark=no' '--enable-module-recovery' '--enable-module-schnorrsig' --cache-file=/dev/null --srcdir=.
2configure: error: cannot find required auxiliary files: ar-lib
3configure: error: ./configure failed for src/secp256k1

Environment:

macOS 12.3.1 (21E258) (Intel)

~~Should I open a separate issue, or does this look just related to my environment?~~

EDIT: fanquake suggested git clean -fx and then rerunning autogen and configure. That worked!

jonatack commented at 8:00 pm on April 10, 2022: member

EDIT: fanquake suggested git clean -fx and then rerunning autogen and configure. That worked!

Cool. Was going to report that the build is clean for me on Debian. Sometimes it’s a good idea to make clean or make distclean as a first step when running into issues like this.

real-or-random commented at 8:04 pm on April 10, 2022: member

EDIT: fanquake suggested git clean -fx and then rerunning autogen and configure. That worked!

Cool. Was going to report that the build is clean for me on Debian. Sometimes it’s a good idea to make clean or make distclean as a first step when running into issues like this.

In this case, most probably rerunning ./autogen.sh was the right fix. It will create ar-lib and this is indeed new in this revision.

jonatack commented at 8:09 pm on April 10, 2022: member

Good point. My bash alias for fresh rebuilding does autogen && configure && make clean && make.

dunxen commented at 8:10 pm on April 10, 2022: contributor

In this case, most probably rerunning ./autogen.sh was the right fix. It will create ar-lib and this is indeed new in this revision.

Yeah, make clean was not sufficient in this case (but is my normal goto for these types errors admittedly 😅) Definitely ./autogen.sh saved the day!

sidhujag referenced this in commit 71ba9bc5ce on Apr 11, 2022

DrahtBot locked this on Apr 10, 2023

Update libsecp256k1 subtree to current master #24792

Conflicts

Guix builds