Add test case mimicking issue 24765 #24799

pull sipa wants to merge 1 commits into bitcoin:master from sipa:202204_try24765 changing 1 files +6 −0

sipa commented at 3:42 PM on April 7, 2022: member

This adds a functional test for the concern brought up in #24765. It turned out to be a non-issue, but since I wrote it anyway, it can't hurt to add it.
Add test case mimicking issue 24765 395767e9f1
fanquake added the label Tests on Apr 7, 2022

in test/functional/feature_taproot.py:1146 in 395767e9f1

1142 | @@ -1143,6 +1143,12 @@ def predict_sigops_ratio(n, dummy_size):
1143 |          tap = taproot_construct(pubs[0], scripts)
1144 |          add_spender(spenders, "alwaysvalid/notsuccessx", tap=tap, leaf="op_success", inputs=[], standard=False, failure={"leaf": "normal"}) # err_msg differs based on opcode
1145 |  
1146 | +    # == Test case for https://github.com/bitcoin/bitcoin/issues/24765 ==

luke-jr commented at 9:13 PM on April 12, 2022:

Would prefer something more descriptive inline, rather than a link

laanwj commented at 7:22 AM on June 2, 2022:

In addition to a link. I think the link is useful for people that want to know further details. But also agree that a short inline description/title would make sense here.

fanquake commented at 10:09 AM on April 20, 2022: member

@antonilol you might be interested in reviewing this?
antonilol commented at 10:19 AM on April 20, 2022: none

yeah sure why not
antonilol approved
antonilol commented at 10:20 AM on April 20, 2022: none

looks good to me!
antonilol commented at 10:24 AM on April 20, 2022: none

by the way what went wrong was the parity of the taproot key has to be put in front of the internal key in the control block, but i put the parity of the internal key there. statistically 50% of the time it fails and 50% of the time it works. for me it didnt work with the 32 bytes of zeros but when i set a 1 byte at the end it worked (after posting this issue i made the script fully automatic and randomized the keys every time and got a successful spend with the zeros)
MarcoFalke merged this on Aug 1, 2022
MarcoFalke closed this on Aug 1, 2022
sidhujag referenced this in commit c0a55c42fe on Aug 1, 2022
bitcoin locked this on Aug 1, 2023

Contributors

Labels

Linked (view graph)

#24765 non-mandatory-script-verify-flag (Witness program hash mismatch) when trying to spend Taproot output with 32x 0x00 tapbranch