RPC: Switch getblockfrompeer back to standard param name blockhash #24806

1. 
   fanquake commented at 12:25 pm on April 8, 2022: member

   This commit partially reverts 923312fbf6a89efde1739da0b7209694d4f892ba.

   Portion of #24294.

2. RPC: Switch getblockfrompeer back to standard param name blockhash

   This commit partially reverts 923312fbf6a89efde1739da0b7209694d4f892ba.

   88917f93cc
3. fanquake added the label Needs backport (23.x) on Apr 8, 2022
4. fanquake added this to the milestone 23.0 on Apr 8, 2022
5. fanquake referenced this in commit e3e4be9cd5 on Apr 8, 2022
6. 
   MarcoFalke commented at 12:29 pm on April 8, 2022: member

   Running locally to confirm this was the only occurrence:

   0$ git grep '"block_hash"' src/
   1src/rpc/blockchain.cpp:            {"block_hash", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The block hash to try to fetch"},
   2src/rpc/blockchain.cpp:    const uint256& block_hash{ParseHashV(request.params[0], "block_hash")};
   

   review ACK 88917f93cc01b5e881072b0e476b74d20b7673c4

   Didn’t run tests to see if they use a named arg anywhere.

7. 
   ajtowns commented at 12:40 pm on April 8, 2022: member

   ACK 88917f93cc01b5e881072b0e476b74d20b7673c4
8. 
   jonatack commented at 12:42 pm on April 8, 2022: member

   Review-and-grep-only ACK 88917f93cc01b5e881072b0e476b74d20b7673c4
9. fanquake merged this on Apr 8, 2022
10. fanquake closed this on Apr 8, 2022

    ---

11. fanquake deleted the branch on Apr 8, 2022
12. 
    fanquake commented at 12:43 pm on April 8, 2022: member

    Backported in #24807.
13. fanquake removed the label Needs backport (23.x) on Apr 8, 2022
14. sidhujag referenced this in commit 38e8abff86 on Apr 8, 2022
15. laanwj referenced this in commit 308a2022c0 on Apr 8, 2022
16. Fabcien referenced this in commit 9132c4dcfd on Dec 3, 2022
17. DrahtBot locked this on Apr 8, 2023

Contributors
fanquake MarcoFalke ajtowns jonatack

Milestone
23.0